* [PATCH] drm/amdgpu: fix amdgpu_atpx_get_client_id()'s return type
@ 2018-04-24 13:15 Luc Van Oostenryck
2018-04-25 6:29 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:15 UTC (permalink / raw)
To: linux-kernel
Cc: Luc Van Oostenryck, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Kai-Heng Feng, Huang Rui,
Junwei Zhang, amd-gfx, dri-devel
The method struct vga_switcheroo_handler::get_client_id() is defined
as returning an 'enum vga_switcheroo_client_id' but the implementation
in this driver, amdgpu_atpx_get_client_id(), returns an 'int'.
Fix this by returning 'enum vga_switcheroo_client_id' in this driver too.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
index 1ae5ae8c4..1bcb2b247 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
@@ -550,7 +550,7 @@ static int amdgpu_atpx_init(void)
* look up whether we are the integrated or discrete GPU (all asics).
* Returns the client id.
*/
-static int amdgpu_atpx_get_client_id(struct pci_dev *pdev)
+static enum vga_switcheroo_client_id amdgpu_atpx_get_client_id(struct pci_dev *pdev)
{
if (amdgpu_atpx_priv.dhandle == ACPI_HANDLE(&pdev->dev))
return VGA_SWITCHEROO_IGD;
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix amdgpu_atpx_get_client_id()'s return type
@ 2018-04-25 6:29 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2018-04-25 6:29 UTC (permalink / raw)
To: Luc Van Oostenryck
Cc: LKML, David (ChunMing) Zhou, David Airlie, Huang Rui,
amd-gfx list, Junwei Zhang, Kai-Heng Feng,
Maling list - DRI developers, Alex Deucher, Christian König
On Tue, Apr 24, 2018 at 9:15 AM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> The method struct vga_switcheroo_handler::get_client_id() is defined
> as returning an 'enum vga_switcheroo_client_id' but the implementation
> in this driver, amdgpu_atpx_get_client_id(), returns an 'int'.
>
> Fix this by returning 'enum vga_switcheroo_client_id' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Applied the whole set for radeon and amdgpu. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
> index 1ae5ae8c4..1bcb2b247 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
> @@ -550,7 +550,7 @@ static int amdgpu_atpx_init(void)
> * look up whether we are the integrated or discrete GPU (all asics).
> * Returns the client id.
> */
> -static int amdgpu_atpx_get_client_id(struct pci_dev *pdev)
> +static enum vga_switcheroo_client_id amdgpu_atpx_get_client_id(struct pci_dev *pdev)
> {
> if (amdgpu_atpx_priv.dhandle == ACPI_HANDLE(&pdev->dev))
> return VGA_SWITCHEROO_IGD;
> --
> 2.17.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix amdgpu_atpx_get_client_id()'s return type
@ 2018-04-25 6:29 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2018-04-25 6:29 UTC (permalink / raw)
To: Luc Van Oostenryck
Cc: Kai-Heng Feng, David (ChunMing) Zhou, David Airlie, LKML,
amd-gfx list, Alex Deucher, Huang Rui,
Maling list - DRI developers, Junwei Zhang, Christian König
On Tue, Apr 24, 2018 at 9:15 AM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> The method struct vga_switcheroo_handler::get_client_id() is defined
> as returning an 'enum vga_switcheroo_client_id' but the implementation
> in this driver, amdgpu_atpx_get_client_id(), returns an 'int'.
>
> Fix this by returning 'enum vga_switcheroo_client_id' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Applied the whole set for radeon and amdgpu. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
> index 1ae5ae8c4..1bcb2b247 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
> @@ -550,7 +550,7 @@ static int amdgpu_atpx_init(void)
> * look up whether we are the integrated or discrete GPU (all asics).
> * Returns the client id.
> */
> -static int amdgpu_atpx_get_client_id(struct pci_dev *pdev)
> +static enum vga_switcheroo_client_id amdgpu_atpx_get_client_id(struct pci_dev *pdev)
> {
> if (amdgpu_atpx_priv.dhandle == ACPI_HANDLE(&pdev->dev))
> return VGA_SWITCHEROO_IGD;
> --
> 2.17.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-25 6:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:15 [PATCH] drm/amdgpu: fix amdgpu_atpx_get_client_id()'s return type Luc Van Oostenryck
2018-04-25 6:29 ` Alex Deucher
2018-04-25 6:29 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.