All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Wei Wang <wvw@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Wei Wang <wei.vince.wang@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>, Crt Mori <cmo@melexis.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] do not call trace_printk on non-debug build
Date: Wed, 25 Apr 2018 08:12:35 +0200	[thread overview]
Message-ID: <20180425061235.GC595@kroah.com> (raw)
In-Reply-To: <CAGXk5yo44kAku+ZYx=8HzOgkEVC7ARNSER4MvWTCz-i51up=ew@mail.gmail.com>

On Tue, Apr 24, 2018 at 07:02:34PM +0000, Wei Wang wrote:
> We have seen many cases vendor have shipped kernel/drivers with it, and
> have to clean up that every year. This was brought up in an internal
> discussion and Greg suggested have some feedback from upstream about what
> should be taken to prevent this globally besides fixing individual drivers.
>  From him "I think this change makes sense at a high level, but there could
> be non-obvious reasons why this isn't the way things are handled right now."

I said that?  Heh, I normally say things like "fix all the stupid
drivers", you must have caught me on a good day :)

Anyway, the drivers should be fixed, if they are doing foolish things
like this, the core kernel should not be "protecting them from
themselves", that way lies madness, just talk to the Windows kernel
developers about the hoops they jump through for this type of stuff...

thanks,

greg k-h

      parent reply	other threads:[~2018-04-25  6:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 18:08 [PATCH] do not call trace_printk on non-debug build Wei Wang
2018-04-24 18:50 ` Steven Rostedt
2018-04-24 19:02   ` Wei Wang
2018-04-24 19:14     ` Steven Rostedt
2018-04-24 19:20       ` Wei Wang
2018-04-24 19:26         ` Steven Rostedt
2018-04-24 20:39           ` Wei Wang
2018-04-24 20:45             ` Steven Rostedt
2018-04-24 20:48               ` Steven Rostedt
2018-04-24 21:32                 ` Wei Wang
2018-04-25  0:49               ` Randy Dunlap
2018-04-25  4:53           ` Wei Wang
2018-04-27  1:46             ` Steven Rostedt
2018-04-25  6:12     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425061235.GC595@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=cmo@melexis.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=wei.vince.wang@gmail.com \
    --cc=wvw@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.