From: Wei Wang <wvw@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: gregkh@linuxfoundation.org, Wei Wang <wei.vince.wang@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>, Crt Mori <cmo@melexis.com>,
Alexei Starovoitov <ast@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] do not call trace_printk on non-debug build
Date: Tue, 24 Apr 2018 19:02:34 +0000 [thread overview]
Message-ID: <CAGXk5yo44kAku+ZYx=8HzOgkEVC7ARNSER4MvWTCz-i51up=ew@mail.gmail.com> (raw)
In-Reply-To: <20180424145056.7c29ea18@gandalf.local.home>
We have seen many cases vendor have shipped kernel/drivers with it, and
have to clean up that every year. This was brought up in an internal
discussion and Greg suggested have some feedback from upstream about what
should be taken to prevent this globally besides fixing individual drivers.
From him "I think this change makes sense at a high level, but there could
be non-obvious reasons why this isn't the way things are handled right now."
On Tue, Apr 24, 2018 at 11:51 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 24 Apr 2018 11:08:10 -0700
> Wei Wang <wvw@google.com> wrote:
> > From: Wei Wang <wvw@google.com>
> >
> > trace_printk will cause trace_printk_init_buffers executed in kernel
> > start, which will increase memory and also show bad warnings in
> > production kernel.
> >
> NAK!
> Where is trace_printk() being used to trigger this?
> trace_printk() is to be added while debugging, but one should not need
> to enable DEBUG to use it. But it should be removed when finished.
Yeah, ideal case is it *should* be removed, but if this is not for
production use, does it make sense we limit the usage with DEBUG?
> -- Steve
> > Signed-off-by: Wei Wang <wvw@google.com>
next prev parent reply other threads:[~2018-04-24 19:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 18:08 [PATCH] do not call trace_printk on non-debug build Wei Wang
2018-04-24 18:50 ` Steven Rostedt
2018-04-24 19:02 ` Wei Wang [this message]
2018-04-24 19:14 ` Steven Rostedt
2018-04-24 19:20 ` Wei Wang
2018-04-24 19:26 ` Steven Rostedt
2018-04-24 20:39 ` Wei Wang
2018-04-24 20:45 ` Steven Rostedt
2018-04-24 20:48 ` Steven Rostedt
2018-04-24 21:32 ` Wei Wang
2018-04-25 0:49 ` Randy Dunlap
2018-04-25 4:53 ` Wei Wang
2018-04-27 1:46 ` Steven Rostedt
2018-04-25 6:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXk5yo44kAku+ZYx=8HzOgkEVC7ARNSER4MvWTCz-i51up=ew@mail.gmail.com' \
--to=wvw@google.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=cmo@melexis.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wei.vince.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.