All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: devel@driverdev.osuosl.org,
	Janusz Lisiecki <janusz.lisiecki@gmail.com>,
	linux-kernel@vger.kernel.org,
	Sergio Paracuellos <sergio.paracuellos@gmail.com>,
	"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
	Quytelda Kahja <quytelda@tamalin.org>,
	SUNIL KALLUR RAMEGOWDA <kallur.sunil@gmail.com>
Subject: Re: [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type
Date: Wed, 25 Apr 2018 15:50:45 +0200	[thread overview]
Message-ID: <20180425135045.GA28703@kroah.com> (raw)
In-Reply-To: <20180424131824.5164-1-luc.vanoostenryck@gmail.com>

On Tue, Apr 24, 2018 at 03:18:21PM +0200, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
> 
> Fix this by returning 'netdev_tx_t' in this driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
>  drivers/staging/ks7010/ks_wlan_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch does not apply to my tree, please rebase and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-04-25 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 13:18 [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type Luc Van Oostenryck
2018-04-25 13:50 ` Greg Kroah-Hartman [this message]
2018-04-25 16:40 ` Janusz Lisiecki
2018-04-25 16:44 ` Janusz Lisiecki
2018-04-26 20:00   ` Luc Van Oostenryck
2020-06-28 18:39 Luc Van Oostenryck
2020-06-28 18:39 ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425135045.GA28703@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=garsilva@embeddedor.com \
    --cc=janusz.lisiecki@gmail.com \
    --cc=kallur.sunil@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=quytelda@tamalin.org \
    --cc=sergio.paracuellos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.