From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Sergio Paracuellos <sergio.paracuellos@gmail.com>
Subject: Re: [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type
Date: Thu, 26 Apr 2018 22:00:10 +0200 [thread overview]
Message-ID: <20180426200009.lpfmn47d6hz75w6b@ltop.local> (raw)
In-Reply-To: <2203ebe4-63c2-3728-50fa-a30b195d1508@gmail.com>
On Wed, Apr 25, 2018 at 06:44:38PM +0200, Janusz Lisiecki wrote:
> Maybe inside ks_wlan_start_xmit, instead of "return 0;", there should be
> "return NETDEV_TX_OK;" and "return NETDEV_TX_BUSY;" otherwise. It is just
> suggestion.
I see, yes. However, since:
1) this sort of change is really outside the goal of this patch;
2) more change are needed for returning NETDEV_TX_BUSY (most not
free the skb, probably should stop the queue/device, ...);
3) the driver is actively improving by someone just now (Sergio);
I prefer to let this change to Sergio.
I'll resend my (unimportant) change in a few weeks (if still needed).
Cheers,
-- Luc
next prev parent reply other threads:[~2018-04-26 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 13:18 [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type Luc Van Oostenryck
2018-04-25 13:50 ` Greg Kroah-Hartman
2018-04-25 16:40 ` Janusz Lisiecki
2018-04-25 16:44 ` Janusz Lisiecki
2018-04-26 20:00 ` Luc Van Oostenryck [this message]
2020-06-28 18:39 Luc Van Oostenryck
2020-06-28 18:39 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426200009.lpfmn47d6hz75w6b@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=janusz.lisiecki@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.