From: Christoph Hellwig <hch@lst.de> To: Andrew Morton <akpm@linux-foundation.org>, Alexander Viro <viro@zeniv.linux.org.uk> Cc: Alexey Dobriyan <adobriyan@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, linux-acpi@vger.kernel.org, drbd-dev@lists.linbit.com, linux-ide@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, devel@driverdev.osuosl.org, linux-afs@lists.infradead.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/40] net/can: single_open_net needs to be paired with single_release_net Date: Wed, 25 Apr 2018 17:47:48 +0200 [thread overview] Message-ID: <20180425154827.32251-2-hch@lst.de> (raw) In-Reply-To: <20180425154827.32251-1-hch@lst.de> Otherwise we will leak a reference to the network namespace. Signed-off-by: Christoph Hellwig <hch@lst.de> --- net/can/bcm.c | 2 +- net/can/proc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/can/bcm.c b/net/can/bcm.c index ac5e5e34fee3..8073fa14e143 100644 --- a/net/can/bcm.c +++ b/net/can/bcm.c @@ -249,7 +249,7 @@ static const struct file_operations bcm_proc_fops = { .open = bcm_proc_open, .read = seq_read, .llseek = seq_lseek, - .release = single_release, + .release = single_release_net, }; #endif /* CONFIG_PROC_FS */ diff --git a/net/can/proc.c b/net/can/proc.c index fdf704e9bb8c..fde2fd55b826 100644 --- a/net/can/proc.c +++ b/net/can/proc.c @@ -279,7 +279,7 @@ static const struct file_operations can_stats_proc_fops = { .open = can_stats_proc_open, .read = seq_read, .llseek = seq_lseek, - .release = single_release, + .release = single_release_net, }; static int can_reset_stats_proc_show(struct seq_file *m, void *v) @@ -449,7 +449,7 @@ static const struct file_operations can_rcvlist_sff_proc_fops = { .open = can_rcvlist_sff_proc_open, .read = seq_read, .llseek = seq_lseek, - .release = single_release, + .release = single_release_net, }; @@ -492,7 +492,7 @@ static const struct file_operations can_rcvlist_eff_proc_fops = { .open = can_rcvlist_eff_proc_open, .read = seq_read, .llseek = seq_lseek, - .release = single_release, + .release = single_release_net, }; /* -- 2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Andrew Morton <akpm@linux-foundation.org>, Alexander Viro <viro@zeniv.linux.org.uk> Cc: linux-rtc@vger.kernel.org, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, jfs-discussion@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Jiri Slaby <jslaby@suse.com>, linux-ext4@vger.kernel.org, Alexey Dobriyan <adobriyan@gmail.com>, megaraidlinux.pdl@broadcom.com, drbd-dev@lists.linbit.com Subject: [PATCH 01/40] net/can: single_open_net needs to be paired with single_release_net Date: Wed, 25 Apr 2018 17:47:48 +0200 [thread overview] Message-ID: <20180425154827.32251-2-hch@lst.de> (raw) In-Reply-To: <20180425154827.32251-1-hch@lst.de> Otherwise we will leak a reference to the network namespace. Signed-off-by: Christoph Hellwig <hch@lst.de> --- net/can/bcm.c | 2 +- net/can/proc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/can/bcm.c b/net/can/bcm.c index ac5e5e34fee3..8073fa14e143 100644 --- a/net/can/bcm.c +++ b/net/can/bcm.c @@ -249,7 +249,7 @@ static const struct file_operations bcm_proc_fops = { .open = bcm_proc_open, .read = seq_read, .llseek = seq_lseek, - .release = single_release, + .release = single_release_net, }; #endif /* CONFIG_PROC_FS */ diff --git a/net/can/proc.c b/net/can/proc.c index fdf704e9bb8c..fde2fd55b826 100644 --- a/net/can/proc.c +++ b/net/can/proc.c @@ -279,7 +279,7 @@ static const struct file_operations can_stats_proc_fops = { .open = can_stats_proc_open, .read = seq_read, .llseek = seq_lseek, - .release = single_release, + .release = single_release_net, }; static int can_reset_stats_proc_show(struct seq_file *m, void *v) @@ -449,7 +449,7 @@ static const struct file_operations can_rcvlist_sff_proc_fops = { .open = can_rcvlist_sff_proc_open, .read = seq_read, .llseek = seq_lseek, - .release = single_release, + .release = single_release_net, }; @@ -492,7 +492,7 @@ static const struct file_operations can_rcvlist_eff_proc_fops = { .open = can_rcvlist_eff_proc_open, .read = seq_read, .llseek = seq_lseek, - .release = single_release, + .release = single_release_net, }; /* -- 2.17.0 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-04-25 15:47 UTC|newest] Thread overview: 170+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-25 15:47 simplify procfs code for seq_file instances V2 Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig [this message] 2018-04-25 15:47 ` [PATCH 01/40] net/can: single_open_net needs to be paired with single_release_net Christoph Hellwig 2018-04-25 15:47 ` [PATCH 02/40] proc: simplify proc_register calling conventions Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` [PATCH 03/40] proc: add a proc_create_reg helper Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` [PATCH 04/40] proc: introduce proc_create_seq{,_data} Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` [PATCH 05/40] proc: introduce proc_create_seq_private Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` [PATCH 06/40] proc: introduce proc_create_single{,_data} Christoph Hellwig 2018-04-26 1:45 ` Finn Thain 2018-04-26 1:45 ` Finn Thain [not found] ` <alpine.LNX.2.21.1804261118050.8-i19888lE8tflDoPlx7XIcw@public.gmane.org> 2018-05-15 13:58 ` [PATCH 06/40] proc: introduce proc_create_single{, _data} Christoph Hellwig 2018-05-15 13:58 ` [PATCH 06/40] proc: introduce proc_create_single{,_data} Christoph Hellwig 2018-05-15 13:58 ` Christoph Hellwig 2018-04-25 15:47 ` [PATCH 07/40] ipv{4,6}/udp{,lite}: simplify proc registration Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` [PATCH 08/40] ipv{4,6}/tcp: simplify procfs registration Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` [PATCH 09/40] ipv{4,6}/ping: simplify proc file creation Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:47 ` [PATCH 10/40] ipv{4, 6}/raw: simplify ѕeq_file code Christoph Hellwig 2018-04-25 15:47 ` [PATCH 10/40] ipv{4,6}/raw: " Christoph Hellwig 2018-04-25 15:47 ` [PATCH 10/40] ipv{4, 6}/raw: " Christoph Hellwig 2018-04-25 15:47 ` [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-05-05 12:37 ` Eric W. Biederman 2018-05-05 12:37 ` Eric W. Biederman [not found] ` <878t8y46sy.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> 2018-05-15 14:56 ` Christoph Hellwig 2018-05-15 14:56 ` Christoph Hellwig 2018-05-15 14:56 ` Christoph Hellwig 2018-05-17 5:28 ` Eric W. Biederman 2018-05-17 5:28 ` Eric W. Biederman 2018-05-17 5:28 ` Eric W. Biederman [not found] ` <871seakg0u.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> 2018-05-17 6:42 ` Christoph Hellwig 2018-05-17 6:42 ` Christoph Hellwig 2018-05-17 6:42 ` Christoph Hellwig 2018-05-17 19:14 ` Eric W. Biederman 2018-05-17 19:14 ` Eric W. Biederman 2018-04-25 15:47 ` [PATCH 12/40] net/kcm: simplify proc registration Christoph Hellwig 2018-04-25 15:47 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 13/40] netfilter/x_tables: simplify ѕeq_file code Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 14/40] net: move seq_file_single_net to <linux/seq_file_net.h> Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 15/40] proc: introduce proc_create_net{,_data} Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 16/40] proc: introduce proc_create_net_single Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 17/40] acpi/battery: simplify procfs code Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 18/40] sgi-gru: " Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 19/40] megaraid: " Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 20/40] sg: " Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 21/40] afs: " Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-30 23:20 ` [PATCH 0/3] afs: Network-namespacing and proc David Howells 2018-04-30 23:20 ` [PATCH 1/3] afs: Rearrange fs/afs/proc.c David Howells 2018-05-15 13:43 ` Christoph Hellwig 2018-04-30 23:20 ` [PATCH 2/3] proc: Add a way to make network proc files writable David Howells 2018-05-15 13:48 ` Christoph Hellwig 2018-05-15 14:16 ` David Howells 2018-04-30 23:20 ` [PATCH 3/3] afs: Implement namespacing David Howells 2018-05-15 13:53 ` Christoph Hellwig 2018-05-15 14:28 ` 'Adding' a writable proc file under /proc/net/afs/ [was [PATCH 3/3] afs: Implement namespacing] David Howells 2018-04-25 15:48 ` [PATCH 22/40] ext4: simplify procfs code Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 23/40] jfs: " Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 24/40] staging/rtl8192u: " Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 25/40] resource: switch to proc_create_seq_data Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 26/40] drbd: switch to proc_create_single Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 27/40] rtc/proc: switch to proc_create_single_data Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 18:25 ` Alexandre Belloni 2018-04-25 18:25 ` Alexandre Belloni 2018-04-25 18:25 ` Alexandre Belloni 2018-04-25 15:48 ` [PATCH 28/40] bonding: switch to proc_create_seq_data Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 29/40] hostap: switch to proc_create_{seq,single}_data Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 30/40] neigh: switch to proc_create_seq_data Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 31/40] netfilter/xt_hashlimit: switch to proc_create_{seq, single}_data Christoph Hellwig 2018-04-25 15:48 ` [PATCH 31/40] netfilter/xt_hashlimit: switch to proc_create_{seq,single}_data Christoph Hellwig 2018-04-25 15:48 ` [PATCH 31/40] netfilter/xt_hashlimit: switch to proc_create_{seq, single}_data Christoph Hellwig 2018-04-25 15:48 ` [PATCH 32/40] netfilter/x_tables: switch to proc_create_seq_private Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 33/40] bluetooth: switch to proc_create_seq_data Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 34/40] atm: simplify procfs code Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-05-05 12:51 ` Eric W. Biederman 2018-05-05 12:51 ` Eric W. Biederman 2018-05-05 12:51 ` Eric W. Biederman [not found] ` <87r2mq2rll.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> 2018-05-15 14:12 ` Christoph Hellwig 2018-05-15 14:12 ` Christoph Hellwig 2018-05-15 14:12 ` Christoph Hellwig 2018-05-17 1:15 ` Eric W. Biederman 2018-05-17 1:15 ` Eric W. Biederman 2018-04-25 15:48 ` [PATCH 35/40] atm: switch to proc_create_seq_private Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 36/40] isdn: replace ->proc_fops with ->proc_show Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 37/40] proc: don't detour through seq->private to get the inode Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 38/40] ide: remove ide_driver_proc_write Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-05-05 13:09 ` Eric W. Biederman 2018-05-05 13:09 ` Eric W. Biederman 2018-05-05 13:09 ` Eric W. Biederman 2018-04-25 15:48 ` [PATCH 39/40] ide: replace ->proc_fops with ->proc_show Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` [PATCH 40/40] tty: " Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-25 15:48 ` Christoph Hellwig 2018-04-30 13:19 ` [PATCH 04/40] proc: introduce proc_create_seq{,_data} David Howells 2018-04-30 13:19 ` David Howells 2018-04-30 13:19 ` David Howells [not found] ` <26540.1525094365-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> 2018-05-15 14:42 ` [PATCH 04/40] proc: introduce proc_create_seq{, _data} Christoph Hellwig 2018-05-15 14:42 ` [PATCH 04/40] proc: introduce proc_create_seq{,_data} Christoph Hellwig 2018-04-30 15:38 ` simplify procfs code for seq_file instances V2 David Howells 2018-05-06 17:19 ` Alexey Dobriyan 2018-05-06 17:19 ` Alexey Dobriyan 2018-05-06 17:19 ` Alexey Dobriyan 2018-05-06 17:45 ` Al Viro 2018-05-09 16:53 ` Alexey Dobriyan 2018-05-09 16:53 ` Alexey Dobriyan 2018-05-15 14:03 ` Christoph Hellwig 2018-05-15 14:03 ` Christoph Hellwig 2018-05-15 14:03 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180425154827.32251-2-hch@lst.de \ --to=hch@lst.de \ --cc=a.zummo@towertech.it \ --cc=adobriyan@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=alexandre.belloni@bootlin.com \ --cc=devel@driverdev.osuosl.org \ --cc=drbd-dev@lists.linbit.com \ --cc=gregkh@linuxfoundation.org \ --cc=jfs-discussion@lists.sourceforge.net \ --cc=jslaby@suse.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-afs@lists.infradead.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=megaraidlinux.pdl@broadcom.com \ --cc=netdev@vger.kernel.org \ --cc=netfilter-devel@vger.kernel.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.