From: Borislav Petkov <bp@suse.de>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
robh+dt@kernel.org, dan.j.williams@intel.com,
nicolas.pitre@linaro.org, josh@joshtriplett.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Brijesh Singh" <brijesh.singh@amd.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Wei Yang" <richard.weiyang@gmail.com>
Subject: Re: [PATCH v3 2/3] resource: add walk_system_ram_res_rev()
Date: Thu, 26 Apr 2018 13:09:05 +0200 [thread overview]
Message-ID: <20180426110905.GH15043@pd.tnic> (raw)
In-Reply-To: <20180426085649.GC18395@localhost.localdomain>
On Thu, Apr 26, 2018 at 04:56:49PM +0800, Baoquan He wrote:
> Sorry for that, I just ran scripts/get_maintainer.pl to get expert's
> name and added them into each patch. The reason this change is made is
> in patch 3/3. Test robot reported a code bug on the latest kernel, will
> repost and CC everyone in all patches.
>
>
> Rob Herring asked the same question in v2, I explained to him. The
> discussion can be found here:
> https://lkml.org/lkml/2018/4/10/484
... and when I open that link, the first paragraph says:
"This is the explanation I made when Andrew helped to review the v1 post:
https://lkml.org/lkml/2018/3/23/78"
Do you see the absurdity of the link chasing of your explanation?!
Instead, the explanation *WHY* should be in the commit message of the
patch - not in mail replies when people ask you about it.
Also, do not use lkml.org when referencing a mail on lkml but
use the Message-ID of the header. We have a proper redirector at
https://lkml.kernel.org/r/<Message-ID>
Now lemme read the reason finally...
"We need unify these two interfaces on behaviour since they are the same
on essense from the users' point of view... "
That's not a good enough reason for me to cause code churn. If the only
reason is: because the one does it top-down and the other bottom-up, I'm
not convinced.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2018-04-26 11:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 0:18 [PATCH v3 0/3] resource: Use list_head to link sibling resource Baoquan He
2018-04-19 0:18 ` [PATCH v3 1/3] " Baoquan He
2018-04-19 0:18 ` Baoquan He
2018-04-19 0:18 ` Baoquan He
2018-04-19 0:18 ` Baoquan He
2018-04-26 1:18 ` Wei Yang
2018-04-26 1:18 ` Wei Yang
2018-04-26 1:18 ` Wei Yang
2018-04-26 1:18 ` Wei Yang
2018-05-07 1:14 ` Baoquan He
2018-05-07 1:14 ` Baoquan He
2018-05-07 1:14 ` Baoquan He
2018-05-07 1:14 ` Baoquan He
2018-05-08 11:48 ` Wei Yang
2018-05-08 11:48 ` Wei Yang
2018-05-08 11:48 ` Wei Yang
2018-05-08 11:48 ` Wei Yang
2018-05-08 12:11 ` Baoquan He
2018-05-08 12:11 ` Baoquan He
2018-05-08 12:11 ` Baoquan He
2018-05-08 23:41 ` Wei Yang
2018-05-08 23:41 ` Wei Yang
2018-05-08 23:41 ` Wei Yang
2018-05-08 23:41 ` Wei Yang
2018-04-26 3:01 ` kbuild test robot
2018-04-26 3:01 ` kbuild test robot
2018-04-26 3:01 ` kbuild test robot
2018-05-06 6:31 ` Baoquan He
2018-05-06 6:31 ` Baoquan He
2018-05-06 6:31 ` Baoquan He
2018-05-06 6:31 ` Baoquan He
2018-04-26 3:23 ` kbuild test robot
2018-04-26 3:23 ` kbuild test robot
2018-04-26 3:23 ` kbuild test robot
2018-05-06 6:30 ` Baoquan He
2018-05-06 6:30 ` Baoquan He
2018-05-06 6:30 ` Baoquan He
2018-05-06 6:30 ` Baoquan He
2018-04-19 0:18 ` [PATCH v3 2/3] resource: add walk_system_ram_res_rev() Baoquan He
2018-04-19 10:07 ` Borislav Petkov
2018-04-26 8:56 ` Baoquan He
2018-04-26 11:09 ` Borislav Petkov [this message]
2018-04-26 13:22 ` Baoquan He
2018-05-04 10:16 ` Borislav Petkov
2018-05-06 6:19 ` Baoquan He
2018-04-19 0:18 ` [PATCH v3 3/3] kexec_file: Load kernel at top of system RAM if required Baoquan He
2018-04-19 0:18 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426110905.GH15043@pd.tnic \
--to=bp@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=brijesh.singh@amd.com \
--cc=dan.j.williams@intel.com \
--cc=jglisse@redhat.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=richard.weiyang@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.