From: Wei Yang <richard.weiyang@gmail.com>
To: Baoquan He <bhe@redhat.com>
Cc: nicolas.pitre@linaro.org, "Brijesh Singh" <brijesh.singh@amd.com>,
devicetree@vger.kernel.org, "David Airlie" <airlied@linux.ie>,
linux-pci@vger.kernel.org, "Wei Yang" <richard.weiyang@gmail.com>,
"Keith Busch" <keith.busch@intel.com>,
"Yaowei Bai" <baiyaowei@cmss.chinamobile.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
linux-nvdimm@lists.01.org,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
linux-input@vger.kernel.org, "Borislav Petkov" <bp@suse.de>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
josh@joshtriplett.org, "Jérôme Glisse" <jglisse@redhat.com>,
robh+dt@kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jonathan Derrick" <jonathan.derrick@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource
Date: Wed, 9 May 2018 08:41:23 +0900 [thread overview]
Message-ID: <20180508234123.GA23307@WeideMacBook-Pro.local> (raw)
In-Reply-To: <20180508121123.GI30581@MiWiFi-R3L-srv>
On Tue, May 08, 2018 at 08:11:23PM +0800, Baoquan He wrote:
>On 05/08/18 at 08:48pm, Wei Yang wrote:
>> On Mon, May 07, 2018 at 09:14:29AM +0800, Baoquan He wrote:
>> >Hi Wei Yang,
>> >
>> >On 04/26/18 at 09:18am, Wei Yang wrote:
>> >> On Thu, Apr 19, 2018 at 08:18:46AM +0800, Baoquan He wrote:
>> >> >The struct resource uses singly linked list to link siblings. It's not
>> >> >easy to do reverse iteration on sibling list. So replace it with list_head.
>> >> >
>> >>
>> >> Hi, Baoquan
>> >>
>> >> Besides changing the data structure, I have another proposal to do the reverse
>> >> iteration. Which means it would not affect other users, if you just want a
>> >> reverse iteration.
>> >>
>> >> BTW, I don't think Andrew suggest to use linked-list directly. What he wants
>> >> is a better solution to your first proposal in
>> >> https://patchwork.kernel.org/patch/10300819/.
>> >>
>> >> Below is my proposal of resource reverse iteration without changing current
>> >> design.
>> >
>> >I got your mail and read it, then interrupted by other thing and forgot
>> >replying, sorry.
>> >
>> >I am fine with your code change. As I said before, I have tried to change
>> >code per reviewers' comment, then let reviewers decide which way is
>> >better. Please feel free to post formal patches and joining discussion
>> >about this issue.
>>
>> Yep, while I don't have a real requirement to add the reverse version, so what
>> is the proper way to send a patch?
>>
>> A patch reply to this thread is ok?
>
>I am not sure either. Since my patches are still under reviewing. And
>you have pasted your patch. It depends on maintainers, mainly Andrew and
>other reviewers who have concerns.
Ok, thanks.
--
Wei Yang
Help you, Help me
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Wei Yang <richard.weiyang@gmail.com>
To: Baoquan He <bhe@redhat.com>
Cc: nicolas.pitre@linaro.org, "Brijesh Singh" <brijesh.singh@amd.com>,
devicetree@vger.kernel.org, "David Airlie" <airlied@linux.ie>,
linux-pci@vger.kernel.org, "Wei Yang" <richard.weiyang@gmail.com>,
"Keith Busch" <keith.busch@intel.com>,
"Yaowei Bai" <baiyaowei@cmss.chinamobile.com>,
"Frank Rowand" <frowand.list@gmail.com>,
dan.j.williams@intel.com,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
linux-nvdimm@lists.01.org,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
linux-input@vger.kernel.org, "Borislav Petkov" <bp@suse.de>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
josh@joshtriplett.org, "Jérôme Glisse" <jglisse@redhat.com>,
robh+dt@kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jonathan Derrick" <jonathan.derrick@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource
Date: Wed, 9 May 2018 08:41:23 +0900 [thread overview]
Message-ID: <20180508234123.GA23307@WeideMacBook-Pro.local> (raw)
In-Reply-To: <20180508121123.GI30581@MiWiFi-R3L-srv>
On Tue, May 08, 2018 at 08:11:23PM +0800, Baoquan He wrote:
>On 05/08/18 at 08:48pm, Wei Yang wrote:
>> On Mon, May 07, 2018 at 09:14:29AM +0800, Baoquan He wrote:
>> >Hi Wei Yang,
>> >
>> >On 04/26/18 at 09:18am, Wei Yang wrote:
>> >> On Thu, Apr 19, 2018 at 08:18:46AM +0800, Baoquan He wrote:
>> >> >The struct resource uses singly linked list to link siblings. It's not
>> >> >easy to do reverse iteration on sibling list. So replace it with list_head.
>> >> >
>> >>
>> >> Hi, Baoquan
>> >>
>> >> Besides changing the data structure, I have another proposal to do the reverse
>> >> iteration. Which means it would not affect other users, if you just want a
>> >> reverse iteration.
>> >>
>> >> BTW, I don't think Andrew suggest to use linked-list directly. What he wants
>> >> is a better solution to your first proposal in
>> >> https://patchwork.kernel.org/patch/10300819/.
>> >>
>> >> Below is my proposal of resource reverse iteration without changing current
>> >> design.
>> >
>> >I got your mail and read it, then interrupted by other thing and forgot
>> >replying, sorry.
>> >
>> >I am fine with your code change. As I said before, I have tried to change
>> >code per reviewers' comment, then let reviewers decide which way is
>> >better. Please feel free to post formal patches and joining discussion
>> >about this issue.
>>
>> Yep, while I don't have a real requirement to add the reverse version, so what
>> is the proper way to send a patch?
>>
>> A patch reply to this thread is ok?
>
>I am not sure either. Since my patches are still under reviewing. And
>you have pasted your patch. It depends on maintainers, mainly Andrew and
>other reviewers who have concerns.
Ok, thanks.
--
Wei Yang
Help you, Help me
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Wei Yang <richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
"Brijesh Singh" <brijesh.singh-5C7GfCeVMHo@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"David Airlie" <airlied-cv59FeDIM0c@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Wei Yang"
<richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Keith Busch"
<keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Yaowei Bai"
<baiyaowei-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org>,
"K. Y. Srinivasan" <kys-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
"Frank Rowand"
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Lorenzo Pieralisi"
<lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>,
"Stephen Hemminger"
<sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
"Patrik Jakobsson"
<patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Borislav Petkov" <bp-l3A5Bk7waGM@public.gmane.org>,
"Tom Lendacky" <thomas.lendacky-5C7GfCeVMHo@public.gmane.org>,
"Haiyang Zhang"
<haiyangz-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org,
"Jérôme Glisse" <jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
"Bjorn Helgaas"
<bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"Jonathan Derrick"
<jonathan.derrick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource
Date: Wed, 9 May 2018 08:41:23 +0900 [thread overview]
Message-ID: <20180508234123.GA23307@WeideMacBook-Pro.local> (raw)
In-Reply-To: <20180508121123.GI30581@MiWiFi-R3L-srv>
On Tue, May 08, 2018 at 08:11:23PM +0800, Baoquan He wrote:
>On 05/08/18 at 08:48pm, Wei Yang wrote:
>> On Mon, May 07, 2018 at 09:14:29AM +0800, Baoquan He wrote:
>> >Hi Wei Yang,
>> >
>> >On 04/26/18 at 09:18am, Wei Yang wrote:
>> >> On Thu, Apr 19, 2018 at 08:18:46AM +0800, Baoquan He wrote:
>> >> >The struct resource uses singly linked list to link siblings. It's not
>> >> >easy to do reverse iteration on sibling list. So replace it with list_head.
>> >> >
>> >>
>> >> Hi, Baoquan
>> >>
>> >> Besides changing the data structure, I have another proposal to do the reverse
>> >> iteration. Which means it would not affect other users, if you just want a
>> >> reverse iteration.
>> >>
>> >> BTW, I don't think Andrew suggest to use linked-list directly. What he wants
>> >> is a better solution to your first proposal in
>> >> https://patchwork.kernel.org/patch/10300819/.
>> >>
>> >> Below is my proposal of resource reverse iteration without changing current
>> >> design.
>> >
>> >I got your mail and read it, then interrupted by other thing and forgot
>> >replying, sorry.
>> >
>> >I am fine with your code change. As I said before, I have tried to change
>> >code per reviewers' comment, then let reviewers decide which way is
>> >better. Please feel free to post formal patches and joining discussion
>> >about this issue.
>>
>> Yep, while I don't have a real requirement to add the reverse version, so what
>> is the proper way to send a patch?
>>
>> A patch reply to this thread is ok?
>
>I am not sure either. Since my patches are still under reviewing. And
>you have pasted your patch. It depends on maintainers, mainly Andrew and
>other reviewers who have concerns.
Ok, thanks.
--
Wei Yang
Help you, Help me
WARNING: multiple messages have this Message-ID (diff)
From: Wei Yang <richard.weiyang@gmail.com>
To: Baoquan He <bhe@redhat.com>
Cc: "Wei Yang" <richard.weiyang@gmail.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
robh+dt@kernel.org, dan.j.williams@intel.com,
nicolas.pitre@linaro.org, josh@joshtriplett.org,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"K. Y. Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Keith Busch" <keith.busch@intel.com>,
"Jonathan Derrick" <jonathan.derrick@intel.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Brijesh Singh" <brijesh.singh@amd.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Borislav Petkov" <bp@suse.de>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Yaowei Bai" <baiyaowei@cmss.chinamobile.com>,
devel@linuxdriverproject.org, linux-input@vger.kernel.org,
linux-nvdimm@lists.01.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource
Date: Wed, 9 May 2018 08:41:23 +0900 [thread overview]
Message-ID: <20180508234123.GA23307@WeideMacBook-Pro.local> (raw)
In-Reply-To: <20180508121123.GI30581@MiWiFi-R3L-srv>
On Tue, May 08, 2018 at 08:11:23PM +0800, Baoquan He wrote:
>On 05/08/18 at 08:48pm, Wei Yang wrote:
>> On Mon, May 07, 2018 at 09:14:29AM +0800, Baoquan He wrote:
>> >Hi Wei Yang,
>> >
>> >On 04/26/18 at 09:18am, Wei Yang wrote:
>> >> On Thu, Apr 19, 2018 at 08:18:46AM +0800, Baoquan He wrote:
>> >> >The struct resource uses singly linked list to link siblings. It's not
>> >> >easy to do reverse iteration on sibling list. So replace it with list_head.
>> >> >
>> >>
>> >> Hi, Baoquan
>> >>
>> >> Besides changing the data structure, I have another proposal to do the reverse
>> >> iteration. Which means it would not affect other users, if you just want a
>> >> reverse iteration.
>> >>
>> >> BTW, I don't think Andrew suggest to use linked-list directly. What he wants
>> >> is a better solution to your first proposal in
>> >> https://patchwork.kernel.org/patch/10300819/.
>> >>
>> >> Below is my proposal of resource reverse iteration without changing current
>> >> design.
>> >
>> >I got your mail and read it, then interrupted by other thing and forgot
>> >replying, sorry.
>> >
>> >I am fine with your code change. As I said before, I have tried to change
>> >code per reviewers' comment, then let reviewers decide which way is
>> >better. Please feel free to post formal patches and joining discussion
>> >about this issue.
>>
>> Yep, while I don't have a real requirement to add the reverse version, so what
>> is the proper way to send a patch?
>>
>> A patch reply to this thread is ok?
>
>I am not sure either. Since my patches are still under reviewing. And
>you have pasted your patch. It depends on maintainers, mainly Andrew and
>other reviewers who have concerns.
Ok, thanks.
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2018-05-08 23:41 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 0:18 [PATCH v3 0/3] resource: Use list_head to link sibling resource Baoquan He
2018-04-19 0:18 ` [PATCH v3 1/3] " Baoquan He
2018-04-19 0:18 ` Baoquan He
2018-04-19 0:18 ` Baoquan He
2018-04-19 0:18 ` Baoquan He
2018-04-26 1:18 ` Wei Yang
2018-04-26 1:18 ` Wei Yang
2018-04-26 1:18 ` Wei Yang
2018-04-26 1:18 ` Wei Yang
2018-05-07 1:14 ` Baoquan He
2018-05-07 1:14 ` Baoquan He
2018-05-07 1:14 ` Baoquan He
2018-05-07 1:14 ` Baoquan He
2018-05-08 11:48 ` Wei Yang
2018-05-08 11:48 ` Wei Yang
2018-05-08 11:48 ` Wei Yang
2018-05-08 11:48 ` Wei Yang
2018-05-08 12:11 ` Baoquan He
2018-05-08 12:11 ` Baoquan He
2018-05-08 12:11 ` Baoquan He
2018-05-08 23:41 ` Wei Yang [this message]
2018-05-08 23:41 ` Wei Yang
2018-05-08 23:41 ` Wei Yang
2018-05-08 23:41 ` Wei Yang
2018-04-26 3:01 ` kbuild test robot
2018-04-26 3:01 ` kbuild test robot
2018-04-26 3:01 ` kbuild test robot
2018-05-06 6:31 ` Baoquan He
2018-05-06 6:31 ` Baoquan He
2018-05-06 6:31 ` Baoquan He
2018-05-06 6:31 ` Baoquan He
2018-04-26 3:23 ` kbuild test robot
2018-04-26 3:23 ` kbuild test robot
2018-04-26 3:23 ` kbuild test robot
2018-05-06 6:30 ` Baoquan He
2018-05-06 6:30 ` Baoquan He
2018-05-06 6:30 ` Baoquan He
2018-05-06 6:30 ` Baoquan He
2018-04-19 0:18 ` [PATCH v3 2/3] resource: add walk_system_ram_res_rev() Baoquan He
2018-04-19 10:07 ` Borislav Petkov
2018-04-26 8:56 ` Baoquan He
2018-04-26 11:09 ` Borislav Petkov
2018-04-26 13:22 ` Baoquan He
2018-05-04 10:16 ` Borislav Petkov
2018-05-06 6:19 ` Baoquan He
2018-04-19 0:18 ` [PATCH v3 3/3] kexec_file: Load kernel at top of system RAM if required Baoquan He
2018-04-19 0:18 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508234123.GA23307@WeideMacBook-Pro.local \
--to=richard.weiyang@gmail.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=bhe@redhat.com \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=devel@linuxdriverproject.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jglisse@redhat.com \
--cc=jonathan.derrick@intel.com \
--cc=josh@joshtriplett.org \
--cc=keith.busch@intel.com \
--cc=kys@microsoft.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nicolas.pitre@linaro.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.