From: Greg KH <greg@kroah.com>
To: Dmitry Shmidt <dimitrysh@google.com>
Cc: stable@vger.kernel.org
Subject: Re: console: Drop added "static" for newport_con
Date: Thu, 26 Apr 2018 21:26:54 +0200 [thread overview]
Message-ID: <20180426192654.GA31241@kroah.com> (raw)
In-Reply-To: <CAH7ZN-zxdfWO=x_2CyuydgoZyuMc8jxob33OPjbedLEOXNFQ1g@mail.gmail.com>
On Thu, Apr 26, 2018 at 12:19:17PM -0700, Dmitry Shmidt wrote:
> On Thu, Apr 26, 2018 at 11:37 AM, Greg KH <greg@kroah.com> wrote:
> > On Thu, Apr 26, 2018 at 10:46:50AM -0700, Dmitry Shmidt wrote:
> >> Please add this patch to stable 4.14
> >>
> >> commit f54450ad1942287cc76b38021c0441fc4901d2de
> >> Author: Kees Cook <keescook@chromium.org>
> >> Date: Tue Feb 27 13:11:21 2018 -0800
> >>
> >> console: Drop added "static" for newport_con
> >>
> >> Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally
> >> added "static" to newport_con instance of struct consw, while trying to
> >> normalize the declarations. This, however, needed to stay non-static as it
> >> has an extern.
> >>
> >> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> >> Fixes: 4fe505119778 ("console: Expand dummy functions for CFI")
> >> Signed-off-by: Kees Cook <keescook@chromium.org>
> >> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> >
> > Why does 4.14.y need it?
>
> https://kernelci.org/build/android/branch/android-4.14/kernel/ASB-2018-04-05_4.14-637-gbb60f28e486c/
Why would I care about an android-specific branch for the kernel.org
releases? :)
> Errors Summary
>
> 2drivers/video/console/newport_con.c:683:27: error: static declaration
> of 'newport_con' follows non-static declaration
Ok, but:
> > It really fixes commit c396a5bf457f ("console: Expand dummy functions
> > for CFI") which only showed up in 4.17-rc1.
As this commit is not in the 4.14.y tree, why should it be applied
there?
Still confused,
greg k-h
next prev parent reply other threads:[~2018-04-26 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 17:46 console: Drop added "static" for newport_con Dmitry Shmidt
2018-04-26 18:37 ` Greg KH
2018-04-26 19:19 ` Dmitry Shmidt
2018-04-26 19:26 ` Greg KH [this message]
2018-04-26 19:32 ` Dmitry Shmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426192654.GA31241@kroah.com \
--to=greg@kroah.com \
--cc=dimitrysh@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.