* [RFC PATCH f2fs] f2fs: release_discard_addr() can be static
2018-04-26 19:57 [f2fs:dev-test 40/41] fs/f2fs/segment.c:1601:6: sparse: symbol 'release_discard_addr' was not declared. Should it be static? kbuild test robot
@ 2018-04-26 19:57 ` kbuild test robot
2018-04-27 2:38 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-04-26 19:57 UTC (permalink / raw)
To: Chao Yu, Chao Yu; +Cc: Jaegeuk Kim, kbuild-all, linux-f2fs-devel
Fixes: 6f89409e87ce ("f2fs: introduce release_discard_addr() for cleanup")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 8652cfd..a0fce5e 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1598,7 +1598,7 @@ static bool add_discard_addrs(struct f2fs_sb_info *sbi, struct cp_control *cpc,
return false;
}
-void release_discard_addr(struct discard_entry *entry)
+static void release_discard_addr(struct discard_entry *entry)
{
list_del(&entry->list);
kmem_cache_free(discard_entry_slab, entry);
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [f2fs:dev-test 40/41] fs/f2fs/segment.c:1601:6: sparse: symbol 'release_discard_addr' was not declared. Should it be static?
@ 2018-04-26 19:57 kbuild test robot
2018-04-26 19:57 ` [RFC PATCH f2fs] f2fs: release_discard_addr() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-04-26 19:57 UTC (permalink / raw)
To: Chao Yu, Chao Yu; +Cc: Jaegeuk Kim, kbuild-all, linux-f2fs-devel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
head: 57ef368c8663e2198fadc0cfecdf67e0fe11e65a
commit: 6f89409e87ce2a41baa5650c978857f306c02859 [40/41] f2fs: introduce release_discard_addr() for cleanup
reproduce:
# apt-get install sparse
git checkout 6f89409e87ce2a41baa5650c978857f306c02859
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
fs/f2fs/segment.c:1052:26: sparse: expression using sizeof(void)
fs/f2fs/segment.c:1052:26: sparse: expression using sizeof(void)
>> fs/f2fs/segment.c:1601:6: sparse: symbol 'release_discard_addr' was not declared. Should it be static?
fs/f2fs/segment.c:2420:27: sparse: expression using sizeof(void)
fs/f2fs/segment.h:373:28: sparse: expression using sizeof(void)
fs/f2fs/segment.h:373:28: sparse: expression using sizeof(void)
fs/f2fs/segment.c:3368:36: sparse: expression using sizeof(void)
fs/f2fs/segment.c:3368:36: sparse: expression using sizeof(void)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH f2fs] f2fs: release_discard_addr() can be static
2018-04-26 19:57 ` [RFC PATCH f2fs] f2fs: release_discard_addr() can be static kbuild test robot
@ 2018-04-27 2:38 ` Chao Yu
0 siblings, 0 replies; 3+ messages in thread
From: Chao Yu @ 2018-04-27 2:38 UTC (permalink / raw)
To: kbuild test robot, Chao Yu; +Cc: Jaegeuk Kim, kbuild-all, linux-f2fs-devel
Hi Fengguang, thanks for the fix.
To Jaegeuk, could you please merge it to original patch?
Thanks,
On 2018/4/27 3:57, kbuild test robot wrote:
>
> Fixes: 6f89409e87ce ("f2fs: introduce release_discard_addr() for cleanup")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 8652cfd..a0fce5e 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1598,7 +1598,7 @@ static bool add_discard_addrs(struct f2fs_sb_info *sbi, struct cp_control *cpc,
> return false;
> }
>
> -void release_discard_addr(struct discard_entry *entry)
> +static void release_discard_addr(struct discard_entry *entry)
> {
> list_del(&entry->list);
> kmem_cache_free(discard_entry_slab, entry);
>
> .
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-27 2:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 19:57 [f2fs:dev-test 40/41] fs/f2fs/segment.c:1601:6: sparse: symbol 'release_discard_addr' was not declared. Should it be static? kbuild test robot
2018-04-26 19:57 ` [RFC PATCH f2fs] f2fs: release_discard_addr() can be static kbuild test robot
2018-04-27 2:38 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.