* [PATCH V2] ARM: dts: da850-evm: add WP and CD to MMC
@ 2018-04-27 2:24 Adam Ford
2018-05-01 11:03 ` Sekhar Nori
0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2018-04-27 2:24 UTC (permalink / raw)
To: linux-arm-kernel
The legacy mode uses the write protect and card detect but DT
has not. This patch enables the pinmuxing and detection for
WP and CD.
Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2: Rebase on davinci master and remove GPIO pinmuxing
arch/arm/boot/dts/da850-evm.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 4c59dab3362e..a56d43d53ba1 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -107,6 +107,8 @@
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&mmc0_pins>;
+ cd-gpios = <&gpio 64 GPIO_ACTIVE_LOW>;
+ wp-gpios = <&gpio 65 GPIO_ACTIVE_HIGH>;
};
spi1: spi at 30e000 {
status = "okay";
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH V2] ARM: dts: da850-evm: add WP and CD to MMC
2018-04-27 2:24 [PATCH V2] ARM: dts: da850-evm: add WP and CD to MMC Adam Ford
@ 2018-05-01 11:03 ` Sekhar Nori
0 siblings, 0 replies; 2+ messages in thread
From: Sekhar Nori @ 2018-05-01 11:03 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 27 April 2018 07:54 AM, Adam Ford wrote:
> The legacy mode uses the write protect and card detect but DT
> has not. This patch enables the pinmuxing and detection for
> WP and CD.
patch description should be readable without reference to headline. So
"MMC" should appear somewhere in the description too. Also, you are not
doing pinmuxing anymore. I think the reference to that should be dropped
or refer to the fact that this happening through gpio-ranges property.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-01 11:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27 2:24 [PATCH V2] ARM: dts: da850-evm: add WP and CD to MMC Adam Ford
2018-05-01 11:03 ` Sekhar Nori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.