* [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.
@ 2018-04-27 15:20 ` Tarick Bedeir
0 siblings, 0 replies; 4+ messages in thread
From: Tarick Bedeir @ 2018-04-27 15:20 UTC (permalink / raw)
To: tariqt; +Cc: Greg Thelen, netdev, linux-rdma, linux-kernel, Tarick Bedeir
Avoid exiting the function with a lingering sysfs file (if the first
call to device_create_file() fails while the second succeeds), and avoid
calling devlink_port_unregister() twice.
In other words, either mlx4_init_port_info() succeeds and returns zero, or
it fails, returns non-zero, and requires no cleanup.
Signed-off-by: Tarick Bedeir <tarick@google.com>
---
drivers/net/ethernet/mellanox/mlx4/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index 4d84cab77105..e8a3a45d0b53 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -3007,6 +3007,7 @@ static int mlx4_init_port_info(struct mlx4_dev *dev, int port)
mlx4_err(dev, "Failed to create file for port %d\n", port);
devlink_port_unregister(&info->devlink_port);
info->port = -1;
+ return err;
}
sprintf(info->dev_mtu_name, "mlx4_port%d_mtu", port);
@@ -3028,9 +3029,10 @@ static int mlx4_init_port_info(struct mlx4_dev *dev, int port)
&info->port_attr);
devlink_port_unregister(&info->devlink_port);
info->port = -1;
+ return err;
}
- return err;
+ return 0;
}
static void mlx4_cleanup_port_info(struct mlx4_port_info *info)
--
2.17.0.441.gb46fe60e1d-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.
@ 2018-04-27 15:20 ` Tarick Bedeir
0 siblings, 0 replies; 4+ messages in thread
From: Tarick Bedeir @ 2018-04-27 15:20 UTC (permalink / raw)
To: tariqt, gthelen, netdev, linux-rdma, linux-kernel, tarick
Cc: Greg Thelen, netdev, linux-rdma, linux-kernel, Tarick Bedeir
Avoid exiting the function with a lingering sysfs file (if the first
call to device_create_file() fails while the second succeeds), and avoid
calling devlink_port_unregister() twice.
In other words, either mlx4_init_port_info() succeeds and returns zero, or
it fails, returns non-zero, and requires no cleanup.
Signed-off-by: Tarick Bedeir <tarick@google.com>
---
drivers/net/ethernet/mellanox/mlx4/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index 4d84cab77105..e8a3a45d0b53 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -3007,6 +3007,7 @@ static int mlx4_init_port_info(struct mlx4_dev *dev, int port)
mlx4_err(dev, "Failed to create file for port %d\n", port);
devlink_port_unregister(&info->devlink_port);
info->port = -1;
+ return err;
}
sprintf(info->dev_mtu_name, "mlx4_port%d_mtu", port);
@@ -3028,9 +3029,10 @@ static int mlx4_init_port_info(struct mlx4_dev *dev, int port)
&info->port_attr);
devlink_port_unregister(&info->devlink_port);
info->port = -1;
+ return err;
}
- return err;
+ return 0;
}
static void mlx4_cleanup_port_info(struct mlx4_port_info *info)
--
2.17.0.441.gb46fe60e1d-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.
2018-04-27 15:20 ` Tarick Bedeir
(?)
@ 2018-05-02 13:31 ` Tariq Toukan
2018-05-13 7:02 ` Tariq Toukan
-1 siblings, 1 reply; 4+ messages in thread
From: Tariq Toukan @ 2018-05-02 13:31 UTC (permalink / raw)
To: Tarick Bedeir, tariqt, gthelen, netdev, linux-rdma, linux-kernel
On 27/04/2018 6:20 PM, Tarick Bedeir wrote:
> Avoid exiting the function with a lingering sysfs file (if the first
> call to device_create_file() fails while the second succeeds), and avoid
> calling devlink_port_unregister() twice.
>
> In other words, either mlx4_init_port_info() succeeds and returns zero, or
> it fails, returns non-zero, and requires no cleanup.
>
> Signed-off-by: Tarick Bedeir <tarick@google.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index 4d84cab77105..e8a3a45d0b53 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -3007,6 +3007,7 @@ static int mlx4_init_port_info(struct mlx4_dev *dev, int port)
> mlx4_err(dev, "Failed to create file for port %d\n", port);
> devlink_port_unregister(&info->devlink_port);
> info->port = -1;
> + return err;
> }
>
> sprintf(info->dev_mtu_name, "mlx4_port%d_mtu", port);
> @@ -3028,9 +3029,10 @@ static int mlx4_init_port_info(struct mlx4_dev *dev, int port)
> &info->port_attr);
> devlink_port_unregister(&info->devlink_port);
> info->port = -1;
> + return err;
> }
>
> - return err;
> + return 0;
> }
>
> static void mlx4_cleanup_port_info(struct mlx4_port_info *info)
>
Acked-by: Tariq Toukan <tariqt@mellanox.com>
Thanks Tarick.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.
2018-05-02 13:31 ` Tariq Toukan
@ 2018-05-13 7:02 ` Tariq Toukan
0 siblings, 0 replies; 4+ messages in thread
From: Tariq Toukan @ 2018-05-13 7:02 UTC (permalink / raw)
To: Tarick Bedeir, gthelen, netdev, linux-rdma, linux-kernel
On 02/05/2018 4:31 PM, Tariq Toukan wrote:
>
>
> On 27/04/2018 6:20 PM, Tarick Bedeir wrote:
>> Avoid exiting the function with a lingering sysfs file (if the first
>> call to device_create_file() fails while the second succeeds), and avoid
>> calling devlink_port_unregister() twice.
>>
>> In other words, either mlx4_init_port_info() succeeds and returns
>> zero, or
>> it fails, returns non-zero, and requires no cleanup.
>>
>> Signed-off-by: Tarick Bedeir <tarick@google.com>
>> ---
>> drivers/net/ethernet/mellanox/mlx4/main.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c
>> b/drivers/net/ethernet/mellanox/mlx4/main.c
>> index 4d84cab77105..e8a3a45d0b53 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
>> @@ -3007,6 +3007,7 @@ static int mlx4_init_port_info(struct mlx4_dev
>> *dev, int port)
>> mlx4_err(dev, "Failed to create file for port %d\n", port);
>> devlink_port_unregister(&info->devlink_port);
>> info->port = -1;
>> + return err;
>> }
>> sprintf(info->dev_mtu_name, "mlx4_port%d_mtu", port);
>> @@ -3028,9 +3029,10 @@ static int mlx4_init_port_info(struct mlx4_dev
>> *dev, int port)
>> &info->port_attr);
>> devlink_port_unregister(&info->devlink_port);
>> info->port = -1;
>> + return err;
>> }
>> - return err;
>> + return 0;
>> }
>> static void mlx4_cleanup_port_info(struct mlx4_port_info *info)
>>
> Acked-by: Tariq Toukan <tariqt@mellanox.com>
>
> Thanks Tarick.
Actually, you need to add a Fixes line:
Fixes: 096335b3f983 ("mlx4_core: Allow dynamic MTU configuration for IB
ports")
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-13 7:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27 15:20 [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info Tarick Bedeir
2018-04-27 15:20 ` Tarick Bedeir
2018-05-02 13:31 ` Tariq Toukan
2018-05-13 7:02 ` Tariq Toukan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.