[igt-dev] [PATCH igt 1/3] lib: sync with the newer i915_pciids.h from the Kernel (KBL + ICL)

[igt-dev] [PATCH igt 1/3] lib: sync with the newer i915_pciids.h from the Kernel (KBL + ICL)

[Paulo Zanoni]

I just copied the Kernel file into the IGT repository.

New IDs:
- KBL GT2 sku from 672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")
- ICL IDs from d55cb4fa2cf0 ("drm/i915/icl: Add the ICL PCI IDs")

Cc: Matt Atwood <matthew.s.atwood@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 lib/i915_pciids.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index 0b2ba46f..bab70ff6 100644
--- a/lib/i915_pciids.h
+++ b/lib/i915_pciids.h
@@ -349,6 +349,7 @@
 #define INTEL_KBL_GT2_IDS(info)	\
 	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
 	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
+	INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
 	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
@@ -431,4 +432,16 @@
 	INTEL_VGA_DEVICE(0x5A44, info), \
 	INTEL_VGA_DEVICE(0x5A4C, info)
 
+/* ICL */
+#define INTEL_ICL_11_IDS(info) \
+	INTEL_VGA_DEVICE(0x8A50, info), \
+	INTEL_VGA_DEVICE(0x8A51, info), \
+	INTEL_VGA_DEVICE(0x8A5C, info), \
+	INTEL_VGA_DEVICE(0x8A5D, info), \
+	INTEL_VGA_DEVICE(0x8A52, info), \
+	INTEL_VGA_DEVICE(0x8A5A, info), \
+	INTEL_VGA_DEVICE(0x8A5B, info), \
+	INTEL_VGA_DEVICE(0x8A71, info), \
+	INTEL_VGA_DEVICE(0x8A70, info)
+
 #endif /* _I915_PCIIDS_H */
-- 
2.14.3

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH igt 2/3] lib: Add Icelake platform definition

[Paulo Zanoni]

From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

v2 (made by Paulo): PCI IDs are now part of a previous patch, so we
can move the ICL_ICL_11_IDs macro to this patch and avoid the
compilation warining on unused intel_icelake_info.

Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 lib/intel_chipset.h     | 3 +++
 lib/intel_device_info.c | 8 ++++++++
 2 files changed, 11 insertions(+)

diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
index 9250f4f9..40170b7b 100644
--- a/lib/intel_chipset.h
+++ b/lib/intel_chipset.h
@@ -67,6 +67,7 @@ struct intel_device_info {
 	bool is_geminilake : 1;
 	bool is_coffeelake : 1;
 	bool is_cannonlake : 1;
+	bool is_icelake : 1;
 	const char *codename;
 };
 
@@ -163,6 +164,7 @@ void intel_check_pch(void);
 #define IS_GEMINILAKE(devid)	(intel_get_device_info(devid)->is_geminilake)
 #define IS_COFFEELAKE(devid)	(intel_get_device_info(devid)->is_coffeelake)
 #define IS_CANNONLAKE(devid)	(intel_get_device_info(devid)->is_cannonlake)
+#define IS_ICELAKE(devid)	(intel_get_device_info(devid)->is_icelake)
 
 #define IS_GEN(devid, x)	(intel_get_device_info(devid)->gen & (1u << ((x)-1)))
 #define AT_LEAST_GEN(devid, x)	(intel_get_device_info(devid)->gen & -(1u << ((x)-1)))
@@ -176,6 +178,7 @@ void intel_check_pch(void);
 #define IS_GEN8(devid)		IS_GEN(devid, 8)
 #define IS_GEN9(devid)		IS_GEN(devid, 9)
 #define IS_GEN10(devid)		IS_GEN(devid, 10)
+#define IS_GEN11(devid)		IS_GEN(devid, 11)
 
 #define IS_MOBILE(devid)	(intel_get_device_info(devid)->is_mobile)
 #define IS_965(devid)		AT_LEAST_GEN(devid, 4)
diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index 1c710733..cc417ed5 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -283,6 +283,12 @@ static const struct intel_device_info intel_cannonlake_info = {
 	.codename = "cannonlake"
 };
 
+static const struct intel_device_info intel_icelake_info = {
+	.gen = BIT(10),
+	.is_icelake = true,
+	.codename = "icelake"
+};
+
 static const struct pci_id_match intel_device_match[] = {
 	INTEL_I810_IDS(&intel_i810_info),
 	INTEL_I815_IDS(&intel_i815_info),
@@ -351,6 +357,8 @@ static const struct pci_id_match intel_device_match[] = {
 
 	INTEL_CNL_IDS(&intel_cannonlake_info),
 
+	INTEL_ICL_11_IDS(&intel_icelake_info),
+
 	INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),
 };
 
-- 
2.14.3

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH igt 3/3] lib/instdone.c: Add Gen11 Support

[Paulo Zanoni]

From: Javier Villavicencio <javier.villavicencio@intel.com>

Bspec: 11431

Signed-off-by: Javier Villavicencio <javier.villavicencio@intel.com>
---
 lib/instdone.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/lib/instdone.c b/lib/instdone.c
index 510fce64..a83f8836 100644
--- a/lib/instdone.c
+++ b/lib/instdone.c
@@ -417,10 +417,20 @@ init_gen8_instdone(void)
 	init_gen75_instdone();
 }
 
+static void
+init_gen11_instdone(void)
+{
+	gen6_instdone1_bit(1 << 24, "TSG1");
+	gen6_instdone1_bit(1 << 11, "TDG1");
+	init_gen8_instdone();
+}
+
 bool
 init_instdone_definitions(uint32_t devid)
 {
-	if (IS_GEN8(devid) || IS_GEN9(devid) || IS_GEN10(devid)) {
+	if (IS_GEN11(devid)) {
+		init_gen11_instdone();
+	} else if (IS_GEN8(devid) || IS_GEN9(devid) || IS_GEN10(devid)) {
 		init_gen8_instdone();
 	} else if (IS_GEN7(devid)) {
 		init_gen7_instdone();
-- 
2.14.3

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt 2/3] lib: Add Icelake platform definition

[Antonio Argenziano]

On 27/04/18 13:01, Paulo Zanoni wrote:
> From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> 
> v2 (made by Paulo): PCI IDs are now part of a previous patch, so we
> can move the ICL_ICL_11_IDs macro to this patch and avoid the

/s/ICL_ICL_11_IDs/INTEL_ICL_11_IDS ?

The rest looks good.

Thanks,
Antonio

> compilation warining on unused intel_icelake_info.
> 
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>   lib/intel_chipset.h     | 3 +++
>   lib/intel_device_info.c | 8 ++++++++
>   2 files changed, 11 insertions(+)
> 
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index 9250f4f9..40170b7b 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -67,6 +67,7 @@ struct intel_device_info {
>   	bool is_geminilake : 1;
>   	bool is_coffeelake : 1;
>   	bool is_cannonlake : 1;
> +	bool is_icelake : 1;
>   	const char *codename;
>   };
>   
> @@ -163,6 +164,7 @@ void intel_check_pch(void);
>   #define IS_GEMINILAKE(devid)	(intel_get_device_info(devid)->is_geminilake)
>   #define IS_COFFEELAKE(devid)	(intel_get_device_info(devid)->is_coffeelake)
>   #define IS_CANNONLAKE(devid)	(intel_get_device_info(devid)->is_cannonlake)
> +#define IS_ICELAKE(devid)	(intel_get_device_info(devid)->is_icelake)
>   
>   #define IS_GEN(devid, x)	(intel_get_device_info(devid)->gen & (1u << ((x)-1)))
>   #define AT_LEAST_GEN(devid, x)	(intel_get_device_info(devid)->gen & -(1u << ((x)-1)))
> @@ -176,6 +178,7 @@ void intel_check_pch(void);
>   #define IS_GEN8(devid)		IS_GEN(devid, 8)
>   #define IS_GEN9(devid)		IS_GEN(devid, 9)
>   #define IS_GEN10(devid)		IS_GEN(devid, 10)
> +#define IS_GEN11(devid)		IS_GEN(devid, 11)
>   
>   #define IS_MOBILE(devid)	(intel_get_device_info(devid)->is_mobile)
>   #define IS_965(devid)		AT_LEAST_GEN(devid, 4)
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 1c710733..cc417ed5 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -283,6 +283,12 @@ static const struct intel_device_info intel_cannonlake_info = {
>   	.codename = "cannonlake"
>   };
>   
> +static const struct intel_device_info intel_icelake_info = {
> +	.gen = BIT(10),
> +	.is_icelake = true,
> +	.codename = "icelake"
> +};
> +
>   static const struct pci_id_match intel_device_match[] = {
>   	INTEL_I810_IDS(&intel_i810_info),
>   	INTEL_I815_IDS(&intel_i815_info),
> @@ -351,6 +357,8 @@ static const struct pci_id_match intel_device_match[] = {
>   
>   	INTEL_CNL_IDS(&intel_cannonlake_info),
>   
> +	INTEL_ICL_11_IDS(&intel_icelake_info),
> +
>   	INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),
>   };
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt 3/3] lib/instdone.c: Add Gen11 Support

[Antonio Argenziano]

On 27/04/18 13:01, Paulo Zanoni wrote:
> From: Javier Villavicencio <javier.villavicencio@intel.com>
> 
> Bspec: 11431
> 
> Signed-off-by: Javier Villavicencio <javier.villavicencio@intel.com>

For the whole series:

Acked-by: Antonio Argenziano <antonio.argenziano@intel.com>

> ---
>   lib/instdone.c | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/instdone.c b/lib/instdone.c
> index 510fce64..a83f8836 100644
> --- a/lib/instdone.c
> +++ b/lib/instdone.c
> @@ -417,10 +417,20 @@ init_gen8_instdone(void)
>   	init_gen75_instdone();
>   }
>   
> +static void
> +init_gen11_instdone(void)
> +{
> +	gen6_instdone1_bit(1 << 24, "TSG1");
> +	gen6_instdone1_bit(1 << 11, "TDG1");
> +	init_gen8_instdone();
> +}
> +
>   bool
>   init_instdone_definitions(uint32_t devid)
>   {
> -	if (IS_GEN8(devid) || IS_GEN9(devid) || IS_GEN10(devid)) {
> +	if (IS_GEN11(devid)) {
> +		init_gen11_instdone();
> +	} else if (IS_GEN8(devid) || IS_GEN9(devid) || IS_GEN10(devid)) {
>   		init_gen8_instdone();
>   	} else if (IS_GEN7(devid)) {
>   		init_gen7_instdone();
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt 1/3] lib: sync with the newer i915_pciids.h from the Kernel (KBL + ICL)

[Souza, Jose]

On Fri, 2018-04-27 at 13:01 -0700, Paulo Zanoni wrote:
> I just copied the Kernel file into the IGT repository.
> 
> New IDs:
> - KBL GT2 sku from 672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")
> - ICL IDs from d55cb4fa2cf0 ("drm/i915/icl: Add the ICL PCI IDs")
> 
> Cc: Matt Atwood <matthew.s.atwood@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Reviewed-by: Jose Roberto de Souza <jose.souza@intel.com>

> ---
>  lib/i915_pciids.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index 0b2ba46f..bab70ff6 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -349,6 +349,7 @@
>  #define INTEL_KBL_GT2_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
>  	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
> +	INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \
>  	INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
>  	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
>  	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
> @@ -431,4 +432,16 @@
>  	INTEL_VGA_DEVICE(0x5A44, info), \
>  	INTEL_VGA_DEVICE(0x5A4C, info)
>  
> +/* ICL */
> +#define INTEL_ICL_11_IDS(info) \
> +	INTEL_VGA_DEVICE(0x8A50, info), \
> +	INTEL_VGA_DEVICE(0x8A51, info), \
> +	INTEL_VGA_DEVICE(0x8A5C, info), \
> +	INTEL_VGA_DEVICE(0x8A5D, info), \
> +	INTEL_VGA_DEVICE(0x8A52, info), \
> +	INTEL_VGA_DEVICE(0x8A5A, info), \
> +	INTEL_VGA_DEVICE(0x8A5B, info), \
> +	INTEL_VGA_DEVICE(0x8A71, info), \
> +	INTEL_VGA_DEVICE(0x8A70, info)
> +
>  #endif /* _I915_PCIIDS_H */
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/3] lib: sync with the newer i915_pciids.h from the Kernel (KBL + ICL)

[Patchwork]

== Series Details ==

Series: series starting with [1/3] lib: sync with the newer i915_pciids.h from the Kernel (KBL + ICL)
URL   : https://patchwork.freedesktop.org/series/42428/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4112 -> IGTPW_1306 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42428/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1306 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-cnl-psr:         PASS -> DMESG-WARN (fdo#104951)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-ivb-3520m:       DMESG-WARN (fdo#106084) -> PASS

    
  fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
  fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084


== Participating hosts (39 -> 35) ==

  Missing    (4): fi-hsw-4770r fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq 


== Build changes ==

    * IGT: IGT_4452 -> IGTPW_1306

  CI_DRM_4112: 423a00794c9d9610a71d8a02cd3bc17c6fe5fae1 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1306: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1306/
  IGT_4452: 29ae12bd764e3b1876356e7628a32192b4ec9066 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4452: 04a2952c5b3782eb03cb136bb16d89daaf243f14 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1306/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/3] lib: sync with the newer i915_pciids.h from the Kernel (KBL + ICL)

[Patchwork]

== Series Details ==

Series: series starting with [1/3] lib: sync with the newer i915_pciids.h from the Kernel (KBL + ICL)
URL   : https://patchwork.freedesktop.org/series/42428/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4452_full -> IGTPW_1306_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1306_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1306_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42428/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1306_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd2:
      shard-kbl:          SKIP -> PASS

    igt@kms_busy@extended-pageflip-hang-oldfb-render-b:
      shard-snb:          SKIP -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
      shard-snb:          PASS -> SKIP +3

    
== Known issues ==

  Here are the changes found in IGTPW_1306_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_store@cachelines-bsd:
      shard-hsw:          PASS -> FAIL (fdo#100007)

    igt@kms_color@pipe-a-ctm-0-25:
      shard-kbl:          PASS -> DMESG-WARN (fdo#105602, fdo#103558) +8

    igt@kms_flip@2x-flip-vs-blocking-wf-vblank:
      shard-hsw:          PASS -> FAIL (fdo#100368) +1

    igt@kms_flip@flip-vs-wf_vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105312)

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-hsw:          PASS -> FAIL (fdo#103928)

    igt@kms_flip@plain-flip-ts-check-interruptible:
      shard-glk:          PASS -> FAIL (fdo#100368) +1

    igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
      shard-apl:          PASS -> FAIL (fdo#103167)

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    
    ==== Possible fixes ====

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@kms_flip@absolute-wf_vblank-interruptible:
      shard-apl:          FAIL (fdo#106087) -> PASS

    igt@kms_flip@dpms-vs-vblank-race-interruptible:
      shard-glk:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#102887) -> PASS

    igt@kms_flip@plain-flip-fb-recreate:
      shard-hsw:          FAIL (fdo#100368) -> PASS +1

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    
  fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
  fdo#105312 https://bugs.freedesktop.org/show_bug.cgi?id=105312
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106087 https://bugs.freedesktop.org/show_bug.cgi?id=106087


== Participating hosts (8 -> 5) ==

  Missing    (3): pig-skl-6600 pig-glk-j4005 pig-hsw-4770r 


== Build changes ==

    * IGT: IGT_4452 -> IGTPW_1306
    * Linux: CI_DRM_4109 -> CI_DRM_4112

  CI_DRM_4109: e701a0e6315dc85615f83b2ee14d9cb2f425d97d @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4112: 423a00794c9d9610a71d8a02cd3bc17c6fe5fae1 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1306: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1306/
  IGT_4452: 29ae12bd764e3b1876356e7628a32192b4ec9066 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4452: 04a2952c5b3782eb03cb136bb16d89daaf243f14 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1306/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt 3/3] lib/instdone.c: Add Gen11 Support

[Paulo Zanoni]

Em Sex, 2018-04-27 às 13:01 -0700, Paulo Zanoni escreveu:
> From: Javier Villavicencio <javier.villavicencio@intel.com>
> 
> Bspec: 11431

I'm not an expert in this area, but the bits seem to match the spec,
so:

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> 
> Signed-off-by: Javier Villavicencio <javier.villavicencio@intel.com>
> ---
>  lib/instdone.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/instdone.c b/lib/instdone.c
> index 510fce64..a83f8836 100644
> --- a/lib/instdone.c
> +++ b/lib/instdone.c
> @@ -417,10 +417,20 @@ init_gen8_instdone(void)
>  	init_gen75_instdone();
>  }
>  
> +static void
> +init_gen11_instdone(void)
> +{
> +	gen6_instdone1_bit(1 << 24, "TSG1");
> +	gen6_instdone1_bit(1 << 11, "TDG1");
> +	init_gen8_instdone();
> +}
> +
>  bool
>  init_instdone_definitions(uint32_t devid)
>  {
> -	if (IS_GEN8(devid) || IS_GEN9(devid) || IS_GEN10(devid)) {
> +	if (IS_GEN11(devid)) {
> +		init_gen11_instdone();
> +	} else if (IS_GEN8(devid) || IS_GEN9(devid) ||
> IS_GEN10(devid)) {
>  		init_gen8_instdone();
>  	} else if (IS_GEN7(devid)) {
>  		init_gen7_instdone();
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt 1/3] lib: sync with the newer i915_pciids.h from the Kernel (KBL + ICL)

[Paulo Zanoni]

Em Sex, 2018-04-27 às 16:59 -0700, Souza, Jose escreveu:
> On Fri, 2018-04-27 at 13:01 -0700, Paulo Zanoni wrote:
> > I just copied the Kernel file into the IGT repository.
> > 
> > New IDs:
> > - KBL GT2 sku from 672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")
> > - ICL IDs from d55cb4fa2cf0 ("drm/i915/icl: Add the ICL PCI IDs")
> > 
> > Cc: Matt Atwood <matthew.s.atwood@intel.com>
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Reviewed-by: Jose Roberto de Souza <jose.souza@intel.com>

Series merged. Thanks everybody for the help.

> 
> > ---
> >  lib/i915_pciids.h | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> > index 0b2ba46f..bab70ff6 100644
> > --- a/lib/i915_pciids.h
> > +++ b/lib/i915_pciids.h
> > @@ -349,6 +349,7 @@
> >  #define INTEL_KBL_GT2_IDS(info)	\
> >  	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
> >  	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
> > +	INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \
> >  	INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
> >  	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
> >  	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
> > @@ -431,4 +432,16 @@
> >  	INTEL_VGA_DEVICE(0x5A44, info), \
> >  	INTEL_VGA_DEVICE(0x5A4C, info)
> >  
> > +/* ICL */
> > +#define INTEL_ICL_11_IDS(info) \
> > +	INTEL_VGA_DEVICE(0x8A50, info), \
> > +	INTEL_VGA_DEVICE(0x8A51, info), \
> > +	INTEL_VGA_DEVICE(0x8A5C, info), \
> > +	INTEL_VGA_DEVICE(0x8A5D, info), \
> > +	INTEL_VGA_DEVICE(0x8A52, info), \
> > +	INTEL_VGA_DEVICE(0x8A5A, info), \
> > +	INTEL_VGA_DEVICE(0x8A5B, info), \
> > +	INTEL_VGA_DEVICE(0x8A71, info), \
> > +	INTEL_VGA_DEVICE(0x8A70, info)
> > +
> >  #endif /* _I915_PCIIDS_H */
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev