From: Martin KaFai Lau <kafai@fb.com> To: Dan Carpenter <dan.carpenter@oracle.com>, Daniel Borkmann <daniel@iogearbox.net> Cc: Alexei Starovoitov <ast@kernel.org>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org> Subject: Re: [PATCH 2/2] bpf: btf: remove a couple conditions Date: Fri, 27 Apr 2018 14:26:50 -0700 [thread overview] Message-ID: <20180427212648.zskc5bk2hunkwvsg@kafai-mbp.dhcp.thefacebook.com> (raw) In-Reply-To: <20180427203135.mjkqoofbanozxzkd@mwanda> On Fri, Apr 27, 2018 at 11:31:36PM +0300, Dan Carpenter wrote: > On Fri, Apr 27, 2018 at 10:21:17PM +0200, Daniel Borkmann wrote: > > On 04/27/2018 09:39 PM, Dan Carpenter wrote: > > > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: > > >> On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: > > >>> On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: > > >>>> We know "err" is zero so we can remove these and pull the code in one > > >>>> indent level. > > >>>> > > >>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > >>> Thanks for the simplification! > > >>> > > >>> Acked-by: Martin KaFai Lau <kafai@fb.com> > > >> btw, it should be for bpf-next. Please tag the subject with bpf-next when > > >> you respin. Thanks! > > > > Dan, thanks a lot for your fixes! Please respin with addressing Martin's > > feedback when you get a chance. > > > > My understanding is that he'd prefer we just ignore the static checker > warning since it's a false positive. Right, I think patch 1 is not needed. I would prefer to use a comment in those cases. > Should I instead initialize the > size to zero or something just to silence it? > > regards, > dan carpenter >
WARNING: multiple messages have this Message-ID (diff)
From: Martin KaFai Lau <kafai@fb.com> To: Dan Carpenter <dan.carpenter@oracle.com>, Daniel Borkmann <daniel@iogearbox.net> Cc: Alexei Starovoitov <ast@kernel.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/2] bpf: btf: remove a couple conditions Date: Fri, 27 Apr 2018 21:26:50 +0000 [thread overview] Message-ID: <20180427212648.zskc5bk2hunkwvsg@kafai-mbp.dhcp.thefacebook.com> (raw) In-Reply-To: <20180427203135.mjkqoofbanozxzkd@mwanda> On Fri, Apr 27, 2018 at 11:31:36PM +0300, Dan Carpenter wrote: > On Fri, Apr 27, 2018 at 10:21:17PM +0200, Daniel Borkmann wrote: > > On 04/27/2018 09:39 PM, Dan Carpenter wrote: > > > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: > > >> On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: > > >>> On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: > > >>>> We know "err" is zero so we can remove these and pull the code in one > > >>>> indent level. > > >>>> > > >>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > >>> Thanks for the simplification! > > >>> > > >>> Acked-by: Martin KaFai Lau <kafai@fb.com> > > >> btw, it should be for bpf-next. Please tag the subject with bpf-next when > > >> you respin. Thanks! > > > > Dan, thanks a lot for your fixes! Please respin with addressing Martin's > > feedback when you get a chance. > > > > My understanding is that he'd prefer we just ignore the static checker > warning since it's a false positive. Right, I think patch 1 is not needed. I would prefer to use a comment in those cases. > Should I instead initialize the > size to zero or something just to silence it? > > regards, > dan carpenter >
next prev parent reply other threads:[~2018-04-27 21:27 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-27 14:04 [PATCH 2/2] bpf: btf: remove a couple conditions Dan Carpenter 2018-04-27 14:04 ` Dan Carpenter 2018-04-27 17:20 ` Martin KaFai Lau 2018-04-27 17:20 ` Martin KaFai Lau 2018-04-27 17:55 ` Martin KaFai Lau 2018-04-27 17:55 ` Martin KaFai Lau 2018-04-27 19:39 ` Dan Carpenter 2018-04-27 19:39 ` Dan Carpenter 2018-04-27 20:21 ` Daniel Borkmann 2018-04-27 20:21 ` Daniel Borkmann 2018-04-27 20:31 ` Dan Carpenter 2018-04-27 20:31 ` Dan Carpenter 2018-04-27 21:26 ` Martin KaFai Lau [this message] 2018-04-27 21:26 ` Martin KaFai Lau 2018-04-28 1:27 ` Martin KaFai Lau 2018-04-28 1:27 ` Martin KaFai Lau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180427212648.zskc5bk2hunkwvsg@kafai-mbp.dhcp.thefacebook.com \ --to=kafai@fb.com \ --cc=ast@kernel.org \ --cc=dan.carpenter@oracle.com \ --cc=daniel@iogearbox.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.