* [PATCH] i2c: rcar: enhance comment to avoid regressions
@ 2018-04-28 20:01 Wolfram Sang
2018-04-30 9:16 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2018-04-28 20:01 UTC (permalink / raw)
To: linux-i2c
Cc: linux-renesas-soc, Yoshihiro Shimoda, Kuninori Morimoto, Wolfram Sang
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Give a clear testcase for people wishing to change this code. It is also
a reminder for me if people ask about it.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/busses/i2c-rcar.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
index c6915b835396..9d8d5b91220f 100644
--- a/drivers/i2c/busses/i2c-rcar.c
+++ b/drivers/i2c/busses/i2c-rcar.c
@@ -542,6 +542,8 @@ static void rcar_i2c_irq_recv(struct rcar_i2c_priv *priv, u32 msr)
* If next received data is the _LAST_, go to STOP phase. Might be
* overwritten by REP START when setting up a new msg. Not elegant
* but the only stable sequence for REP START I have found so far.
+ * If you want to change this code, make sure sending one transfer with
+ * four messages (WR-RD-WR-RD) works!
*/
if (priv->pos + 1 >= msg->len)
rcar_i2c_write(priv, ICMCR, RCAR_BUS_PHASE_STOP);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: rcar: enhance comment to avoid regressions
2018-04-28 20:01 [PATCH] i2c: rcar: enhance comment to avoid regressions Wolfram Sang
@ 2018-04-30 9:16 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2018-04-30 9:16 UTC (permalink / raw)
To: linux-i2c
Cc: linux-renesas-soc, Yoshihiro Shimoda, Kuninori Morimoto, Wolfram Sang
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
On Sat, Apr 28, 2018 at 10:01:02PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Give a clear testcase for people wishing to change this code. It is also
> a reminder for me if people ask about it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-30 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-28 20:01 [PATCH] i2c: rcar: enhance comment to avoid regressions Wolfram Sang
2018-04-30 9:16 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.