* [PATCH] drm/rect: Fix drm_rect_rotation_inv() docs
@ 2018-04-26 14:16 Ville Syrjala
2018-04-30 15:07 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Ville Syrjala @ 2018-04-26 14:16 UTC (permalink / raw)
To: dri-devel
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
An overeager sed has corrupted the drm_rect_rotation_inv()
documentation. Fix it up.
Looks like it wasn't entirely correct before the sed fail
either. We were missing _rect_ from the function names, which
also explains why the sed hit these by accident.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_rect.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_rect.c b/drivers/gpu/drm/drm_rect.c
index 9817c1445ba9..a3783ecea297 100644
--- a/drivers/gpu/drm/drm_rect.c
+++ b/drivers/gpu/drm/drm_rect.c
@@ -373,8 +373,8 @@ EXPORT_SYMBOL(drm_rect_rotate);
* them when doing a rotatation and its inverse.
* That is, if you do ::
*
- * DRM_MODE_PROP_ROTATE(&r, width, height, rotation);
- * DRM_MODE_ROTATE_inv(&r, width, height, rotation);
+ * drm_rect_rotate(&r, width, height, rotation);
+ * drm_rect_rotate_inv(&r, width, height, rotation);
*
* you will always get back the original rectangle.
*/
--
2.16.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/rect: Fix drm_rect_rotation_inv() docs
2018-04-26 14:16 [PATCH] drm/rect: Fix drm_rect_rotation_inv() docs Ville Syrjala
@ 2018-04-30 15:07 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2018-04-30 15:07 UTC (permalink / raw)
To: Ville Syrjala; +Cc: dri-devel
On Thu, Apr 26, 2018 at 05:16:31PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> An overeager sed has corrupted the drm_rect_rotation_inv()
> documentation. Fix it up.
>
> Looks like it wasn't entirely correct before the sed fail
> either. We were missing _rect_ from the function names, which
> also explains why the sed hit these by accident.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_rect.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_rect.c b/drivers/gpu/drm/drm_rect.c
> index 9817c1445ba9..a3783ecea297 100644
> --- a/drivers/gpu/drm/drm_rect.c
> +++ b/drivers/gpu/drm/drm_rect.c
> @@ -373,8 +373,8 @@ EXPORT_SYMBOL(drm_rect_rotate);
> * them when doing a rotatation and its inverse.
> * That is, if you do ::
> *
> - * DRM_MODE_PROP_ROTATE(&r, width, height, rotation);
> - * DRM_MODE_ROTATE_inv(&r, width, height, rotation);
> + * drm_rect_rotate(&r, width, height, rotation);
> + * drm_rect_rotate_inv(&r, width, height, rotation);
> *
> * you will always get back the original rectangle.
> */
> --
> 2.16.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-30 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 14:16 [PATCH] drm/rect: Fix drm_rect_rotation_inv() docs Ville Syrjala
2018-04-30 15:07 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.