* [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
@ 2018-03-20 14:17 Wei Yongjun
2018-03-22 14:06 ` Jarkko Sakkinen
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Wei Yongjun @ 2018-03-20 14:17 UTC (permalink / raw)
To: kernel-janitors
Fixes the following sparse warning:
drivers/firmware/efi/libstub/tpm.c:62:6: warning:
symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/firmware/efi/libstub/tpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/libstub/tpm.c b/drivers/firmware/efi/libstub/tpm.c
index 9d08cea..caa37a6 100644
--- a/drivers/firmware/efi/libstub/tpm.c
+++ b/drivers/firmware/efi/libstub/tpm.c
@@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t *sys_table_arg)
#endif
-void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
+static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
{
efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID;
efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID;
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
2018-03-20 14:17 [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static Wei Yongjun
@ 2018-03-22 14:06 ` Jarkko Sakkinen
2018-03-22 14:09 ` Jarkko Sakkinen
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Jarkko Sakkinen @ 2018-03-22 14:06 UTC (permalink / raw)
To: kernel-janitors
On Tue, 2018-03-20 at 14:17 +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/firmware/efi/libstub/tpm.c:62:6: warning:
> symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be
> static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/firmware/efi/libstub/tpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/tpm.c
> b/drivers/firmware/efi/libstub/tpm.c
> index 9d08cea..caa37a6 100644
> --- a/drivers/firmware/efi/libstub/tpm.c
> +++ b/drivers/firmware/efi/libstub/tpm.c
> @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t
> *sys_table_arg)
>
> #endif
>
> -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
> +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
> {
> efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID;
> efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID;
>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
2018-03-20 14:17 [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static Wei Yongjun
2018-03-22 14:06 ` Jarkko Sakkinen
@ 2018-03-22 14:09 ` Jarkko Sakkinen
2018-04-16 11:05 ` Ard Biesheuvel
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Jarkko Sakkinen @ 2018-03-22 14:09 UTC (permalink / raw)
To: kernel-janitors
On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote:
> On Tue, 2018-03-20 at 14:17 +0000, Wei Yongjun wrote:
> > Fixes the following sparse warning:
> >
> > drivers/firmware/efi/libstub/tpm.c:62:6: warning:
> > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be
> > static?
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> > drivers/firmware/efi/libstub/tpm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/efi/libstub/tpm.c
> > b/drivers/firmware/efi/libstub/tpm.c
> > index 9d08cea..caa37a6 100644
> > --- a/drivers/firmware/efi/libstub/tpm.c
> > +++ b/drivers/firmware/efi/libstub/tpm.c
> > @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t
> > *sys_table_arg)
> >
> > #endif
> >
> > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
> > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t
> > *sys_table_arg)
> > {
> > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID;
> > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID;
> >
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Applied.
/Jarkko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
2018-03-20 14:17 [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static Wei Yongjun
2018-03-22 14:06 ` Jarkko Sakkinen
2018-03-22 14:09 ` Jarkko Sakkinen
@ 2018-04-16 11:05 ` Ard Biesheuvel
2018-04-23 19:38 ` Jarkko Sakkinen
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Ard Biesheuvel @ 2018-04-16 11:05 UTC (permalink / raw)
To: kernel-janitors
On 22 March 2018 at 15:09, Jarkko Sakkinen
<jarkko.sakkinen@linux.intel.com> wrote:
> On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote:
>> On Tue, 2018-03-20 at 14:17 +0000, Wei Yongjun wrote:
>> > Fixes the following sparse warning:
>> >
>> > drivers/firmware/efi/libstub/tpm.c:62:6: warning:
>> > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be
>> > static?
>> >
>> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> > ---
>> > drivers/firmware/efi/libstub/tpm.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/firmware/efi/libstub/tpm.c
>> > b/drivers/firmware/efi/libstub/tpm.c
>> > index 9d08cea..caa37a6 100644
>> > --- a/drivers/firmware/efi/libstub/tpm.c
>> > +++ b/drivers/firmware/efi/libstub/tpm.c
>> > @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t
>> > *sys_table_arg)
>> >
>> > #endif
>> >
>> > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
>> > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t
>> > *sys_table_arg)
>> > {
>> > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID;
>> > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID;
>> >
>>
>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> Applied.
>
Applied to?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
2018-03-20 14:17 [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static Wei Yongjun
` (2 preceding siblings ...)
2018-04-16 11:05 ` Ard Biesheuvel
@ 2018-04-23 19:38 ` Jarkko Sakkinen
2018-04-24 6:39 ` Ard Biesheuvel
2018-05-01 11:41 ` Jarkko Sakkinen
5 siblings, 0 replies; 7+ messages in thread
From: Jarkko Sakkinen @ 2018-04-23 19:38 UTC (permalink / raw)
To: kernel-janitors
On Mon, Apr 16, 2018 at 01:05:24PM +0200, Ard Biesheuvel wrote:
> On 22 March 2018 at 15:09, Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> > On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote:
> >> On Tue, 2018-03-20 at 14:17 +0000, Wei Yongjun wrote:
> >> > Fixes the following sparse warning:
> >> >
> >> > drivers/firmware/efi/libstub/tpm.c:62:6: warning:
> >> > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be
> >> > static?
> >> >
> >> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> >> > ---
> >> > drivers/firmware/efi/libstub/tpm.c | 2 +-
> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/firmware/efi/libstub/tpm.c
> >> > b/drivers/firmware/efi/libstub/tpm.c
> >> > index 9d08cea..caa37a6 100644
> >> > --- a/drivers/firmware/efi/libstub/tpm.c
> >> > +++ b/drivers/firmware/efi/libstub/tpm.c
> >> > @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t
> >> > *sys_table_arg)
> >> >
> >> > #endif
> >> >
> >> > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
> >> > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t
> >> > *sys_table_arg)
> >> > {
> >> > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID;
> >> > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID;
> >> >
> >>
> >> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > Applied.
> >
>
> Applied to?
Mistake, efi maintainers should pick this one up. Sorry (my reviewed tag
still holds).
/Jarkko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
2018-03-20 14:17 [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static Wei Yongjun
` (3 preceding siblings ...)
2018-04-23 19:38 ` Jarkko Sakkinen
@ 2018-04-24 6:39 ` Ard Biesheuvel
2018-05-01 11:41 ` Jarkko Sakkinen
5 siblings, 0 replies; 7+ messages in thread
From: Ard Biesheuvel @ 2018-04-24 6:39 UTC (permalink / raw)
To: kernel-janitors
On 23 April 2018 at 21:38, Jarkko Sakkinen
<jarkko.sakkinen@linux.intel.com> wrote:
> On Mon, Apr 16, 2018 at 01:05:24PM +0200, Ard Biesheuvel wrote:
>> On 22 March 2018 at 15:09, Jarkko Sakkinen
>> <jarkko.sakkinen@linux.intel.com> wrote:
>> > On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote:
>> >> On Tue, 2018-03-20 at 14:17 +0000, Wei Yongjun wrote:
>> >> > Fixes the following sparse warning:
>> >> >
>> >> > drivers/firmware/efi/libstub/tpm.c:62:6: warning:
>> >> > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be
>> >> > static?
>> >> >
>> >> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> >> > ---
>> >> > drivers/firmware/efi/libstub/tpm.c | 2 +-
>> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >> >
>> >> > diff --git a/drivers/firmware/efi/libstub/tpm.c
>> >> > b/drivers/firmware/efi/libstub/tpm.c
>> >> > index 9d08cea..caa37a6 100644
>> >> > --- a/drivers/firmware/efi/libstub/tpm.c
>> >> > +++ b/drivers/firmware/efi/libstub/tpm.c
>> >> > @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t
>> >> > *sys_table_arg)
>> >> >
>> >> > #endif
>> >> >
>> >> > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
>> >> > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t
>> >> > *sys_table_arg)
>> >> > {
>> >> > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID;
>> >> > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID;
>> >> >
>> >>
>> >> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>> >
>> > Applied.
>> >
>>
>> Applied to?
>
> Mistake, efi maintainers should pick this one up. Sorry (my reviewed tag
> still holds).
>
Thanks. I have queued this up in efi/next
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
2018-03-20 14:17 [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static Wei Yongjun
` (4 preceding siblings ...)
2018-04-24 6:39 ` Ard Biesheuvel
@ 2018-05-01 11:41 ` Jarkko Sakkinen
5 siblings, 0 replies; 7+ messages in thread
From: Jarkko Sakkinen @ 2018-05-01 11:41 UTC (permalink / raw)
To: kernel-janitors
On Tue, Apr 24, 2018 at 08:39:09AM +0200, Ard Biesheuvel wrote:
> On 23 April 2018 at 21:38, Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> > On Mon, Apr 16, 2018 at 01:05:24PM +0200, Ard Biesheuvel wrote:
> >> On 22 March 2018 at 15:09, Jarkko Sakkinen
> >> <jarkko.sakkinen@linux.intel.com> wrote:
> >> > On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote:
> >> >> On Tue, 2018-03-20 at 14:17 +0000, Wei Yongjun wrote:
> >> >> > Fixes the following sparse warning:
> >> >> >
> >> >> > drivers/firmware/efi/libstub/tpm.c:62:6: warning:
> >> >> > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be
> >> >> > static?
> >> >> >
> >> >> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> >> >> > ---
> >> >> > drivers/firmware/efi/libstub/tpm.c | 2 +-
> >> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >> >
> >> >> > diff --git a/drivers/firmware/efi/libstub/tpm.c
> >> >> > b/drivers/firmware/efi/libstub/tpm.c
> >> >> > index 9d08cea..caa37a6 100644
> >> >> > --- a/drivers/firmware/efi/libstub/tpm.c
> >> >> > +++ b/drivers/firmware/efi/libstub/tpm.c
> >> >> > @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t
> >> >> > *sys_table_arg)
> >> >> >
> >> >> > #endif
> >> >> >
> >> >> > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
> >> >> > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t
> >> >> > *sys_table_arg)
> >> >> > {
> >> >> > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID;
> >> >> > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID;
> >> >> >
> >> >>
> >> >> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >> >
> >> > Applied.
> >> >
> >>
> >> Applied to?
> >
> > Mistake, efi maintainers should pick this one up. Sorry (my reviewed tag
> > still holds).
> >
>
> Thanks. I have queued this up in efi/next
And sorry for the confusion! Had a lot of traffic that point..
/Jarkko
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-05-01 11:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-20 14:17 [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static Wei Yongjun
2018-03-22 14:06 ` Jarkko Sakkinen
2018-03-22 14:09 ` Jarkko Sakkinen
2018-04-16 11:05 ` Ard Biesheuvel
2018-04-23 19:38 ` Jarkko Sakkinen
2018-04-24 6:39 ` Ard Biesheuvel
2018-05-01 11:41 ` Jarkko Sakkinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.