All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rcar-vin: remove generic gen3 compatible string
@ 2018-04-24 23:43 Niklas Söderlund
  2018-04-25  7:09 ` Simon Horman
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Niklas Söderlund @ 2018-04-24 23:43 UTC (permalink / raw)
  To: Rob Herring, Laurent Pinchart, Hans Verkuil, linux-media, devicetree
  Cc: linux-renesas-soc, Niklas Söderlund

The compatible string "renesas,rcar-gen3-vin" was added before the
Gen3 driver code was added but it's not possible to use. Each SoC in the
Gen3 series require SoC specific knowledge in the driver to function.
Remove it before it is added to any device tree descriptions.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 Documentation/devicetree/bindings/media/rcar_vin.txt | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
index ba31431d4b1fbdbb..a19517e1c669eb35 100644
--- a/Documentation/devicetree/bindings/media/rcar_vin.txt
+++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
@@ -24,7 +24,6 @@ on Gen3 platforms to a CSI-2 receiver.
    - "renesas,vin-r8a77970" for the R8A77970 device
    - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 or RZ/G1 compatible
      device.
-   - "renesas,rcar-gen3-vin" for a generic R-Car Gen3 compatible device.
 
    When compatible with the generic version nodes must list the
    SoC-specific version corresponding to the platform first
-- 
2.17.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] rcar-vin: remove generic gen3 compatible string
  2018-04-24 23:43 [PATCH] rcar-vin: remove generic gen3 compatible string Niklas Söderlund
@ 2018-04-25  7:09 ` Simon Horman
  2018-04-26 23:09 ` Laurent Pinchart
  2018-05-01 14:11   ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2018-04-25  7:09 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: Rob Herring, Laurent Pinchart, Hans Verkuil, linux-media,
	devicetree, linux-renesas-soc

On Wed, Apr 25, 2018 at 01:43:21AM +0200, Niklas Söderlund wrote:
> The compatible string "renesas,rcar-gen3-vin" was added before the
> Gen3 driver code was added but it's not possible to use. Each SoC in the
> Gen3 series require SoC specific knowledge in the driver to function.
> Remove it before it is added to any device tree descriptions.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  Documentation/devicetree/bindings/media/rcar_vin.txt | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index ba31431d4b1fbdbb..a19517e1c669eb35 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -24,7 +24,6 @@ on Gen3 platforms to a CSI-2 receiver.
>     - "renesas,vin-r8a77970" for the R8A77970 device
>     - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 or RZ/G1 compatible
>       device.
> -   - "renesas,rcar-gen3-vin" for a generic R-Car Gen3 compatible device.
>  
>     When compatible with the generic version nodes must list the
>     SoC-specific version corresponding to the platform first
> -- 
> 2.17.0
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rcar-vin: remove generic gen3 compatible string
  2018-04-24 23:43 [PATCH] rcar-vin: remove generic gen3 compatible string Niklas Söderlund
  2018-04-25  7:09 ` Simon Horman
@ 2018-04-26 23:09 ` Laurent Pinchart
  2018-05-01 14:11   ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2018-04-26 23:09 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: Rob Herring, Hans Verkuil, linux-media, devicetree, linux-renesas-soc

Hi Niklas,

Thank you for the patch.

On Wednesday, 25 April 2018 02:43:21 EEST Niklas Söderlund wrote:
> The compatible string "renesas,rcar-gen3-vin" was added before the
> Gen3 driver code was added but it's not possible to use. Each SoC in the
> Gen3 series require SoC specific knowledge in the driver to function.
> Remove it before it is added to any device tree descriptions.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  Documentation/devicetree/bindings/media/rcar_vin.txt | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt
> b/Documentation/devicetree/bindings/media/rcar_vin.txt index
> ba31431d4b1fbdbb..a19517e1c669eb35 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -24,7 +24,6 @@ on Gen3 platforms to a CSI-2 receiver.
>     - "renesas,vin-r8a77970" for the R8A77970 device
>     - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 or RZ/G1 compatible
>       device.
> -   - "renesas,rcar-gen3-vin" for a generic R-Car Gen3 compatible device.
> 
>     When compatible with the generic version nodes must list the
>     SoC-specific version corresponding to the platform first


-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rcar-vin: remove generic gen3 compatible string
  2018-04-24 23:43 [PATCH] rcar-vin: remove generic gen3 compatible string Niklas Söderlund
@ 2018-05-01 14:11   ` Rob Herring
  2018-04-26 23:09 ` Laurent Pinchart
  2018-05-01 14:11   ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2018-05-01 14:11 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: Laurent Pinchart, Hans Verkuil, linux-media, devicetree,
	linux-renesas-soc

On Wed, Apr 25, 2018 at 01:43:21AM +0200, Niklas S�derlund wrote:
> The compatible string "renesas,rcar-gen3-vin" was added before the
> Gen3 driver code was added but it's not possible to use. Each SoC in the
> Gen3 series require SoC specific knowledge in the driver to function.
> Remove it before it is added to any device tree descriptions.
> 
> Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>  Documentation/devicetree/bindings/media/rcar_vin.txt | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rcar-vin: remove generic gen3 compatible string
@ 2018-05-01 14:11   ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2018-05-01 14:11 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: Laurent Pinchart, Hans Verkuil, linux-media, devicetree,
	linux-renesas-soc

On Wed, Apr 25, 2018 at 01:43:21AM +0200, Niklas Söderlund wrote:
> The compatible string "renesas,rcar-gen3-vin" was added before the
> Gen3 driver code was added but it's not possible to use. Each SoC in the
> Gen3 series require SoC specific knowledge in the driver to function.
> Remove it before it is added to any device tree descriptions.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>  Documentation/devicetree/bindings/media/rcar_vin.txt | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-05-01 14:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 23:43 [PATCH] rcar-vin: remove generic gen3 compatible string Niklas Söderlund
2018-04-25  7:09 ` Simon Horman
2018-04-26 23:09 ` Laurent Pinchart
2018-05-01 14:11 ` Rob Herring
2018-05-01 14:11   ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.