From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dennis Dalessandro <dennis.dalessandro@intel.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
Don Hiatt <don.hiatt@intel.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
stable@vger.kernel.org,
"Michael J. Ruhl" <michael.j.ruhl@intel.com>
Subject: Re: [PATCH for-rc v2 1/6] IB/hfi1: Fix handling of FECN marked multicast packet
Date: Tue, 1 May 2018 12:05:31 -0600 [thread overview]
Message-ID: <20180501180531.GB17027@ziepe.ca> (raw)
In-Reply-To: <20180501123532.24520.80857.stgit@scvm10.sc.intel.com>
On Tue, May 01, 2018 at 05:35:36AM -0700, Dennis Dalessandro wrote:
> @@ -719,7 +719,7 @@ void return_cnp(struct hfi1_ibport *ibp, struct rvt_qp *qp, u32 remote_qpn,
>
> lrh0 |= (sc5 & 0xf) << 12 | sl << 4;
>
> - bth0 = pkey | (IB_OPCODE_CNP << 24);
> + bth0 = (u32)pkey | (IB_OPCODE_CNP << 24);
What do you think this cast does??
void return_cnp_16B(struct hfi1_ibport *ibp, struct rvt_qp *qp,
u32 remote_qpn, u32 pkey, u32 slid, u32 dlid,
u8 sc5, const struct ib_grh *old_grh)
{
Jason
next prev parent reply other threads:[~2018-05-01 18:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 12:35 [PATCH for-rc v2 0/6] IB/hfi1,rdmavt: Fixes for the 4.17 RC Dennis Dalessandro
2018-05-01 12:35 ` Dennis Dalessandro
2018-05-01 12:35 ` [PATCH for-rc v2 1/6] IB/hfi1: Fix handling of FECN marked multicast packet Dennis Dalessandro
2018-05-01 18:05 ` Jason Gunthorpe [this message]
2018-05-01 21:58 ` Marciniszyn, Mike
2018-05-02 2:24 ` Doug Ledford
2018-05-03 12:54 ` Marciniszyn, Mike
2018-05-03 19:08 ` Doug Ledford
2018-05-03 19:25 ` Doug Ledford
2018-05-01 12:35 ` [PATCH for-rc v2 3/6] IB/hfi1: Fix loss of BECN with AHG Dennis Dalessandro
2018-05-01 12:35 ` [PATCH for-rc v2 4/6] IB/hfi1: Fix NULL pointer dereference when invalid num_vls is used Dennis Dalessandro
2018-05-01 17:18 ` [PATCH for-rc v2 0/6] IB/hfi1,rdmavt: Fixes for the 4.17 RC Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501180531.GB17027@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=don.hiatt@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=mike.marciniszyn@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.