From: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>
To: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"Dalessandro, Dennis" <dennis.dalessandro@intel.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"Hiatt, Don" <don.hiatt@intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Ruhl, Michael J" <michael.j.ruhl@intel.com>
Subject: RE: [PATCH for-rc v2 1/6] IB/hfi1: Fix handling of FECN marked multicast packet
Date: Thu, 3 May 2018 12:54:22 +0000 [thread overview]
Message-ID: <32E1700B9017364D9B60AED9960492BC62829957@fmsmsx120.amr.corp.intel.com> (raw)
In-Reply-To: <1525227892.11756.131.camel@redhat.com>
> >
> > But I see Doug pulled the fix?
>
> It's in my wip branch, so until I merge it into the official for-rc
> branch, I can still fix up minor things like this.
>
The patch works without the cast.
How do you want to do this:
- A v2 -> v3 of the patch?
- Manually delete the cast in your wip branch?
Here is the diff hunk for removing the cast from return_cnp:
diff --git a/drivers/infiniband/hw/hfi1/ud.c b/drivers/infiniband/hw/hfi1/ud.c
index 9aa7d87..6ad203f 100644
--- a/drivers/infiniband/hw/hfi1/ud.c
+++ b/drivers/infiniband/hw/hfi1/ud.c
@@ -719,7 +719,7 @@ void return_cnp(struct hfi1_ibport *ibp, struct rvt_qp *qp, u32 remote_qpn,
lrh0 |= (sc5 & 0xf) << 12 | sl << 4;
- bth0 = (u32)pkey | (IB_OPCODE_CNP << 24);
+ bth0 = pkey | (IB_OPCODE_CNP << 24);
ohdr->bth[0] = cpu_to_be32(bth0);
ohdr->bth[1] = cpu_to_be32(remote_qpn | (1 << IB_BECN_SHIFT));
Mike
next prev parent reply other threads:[~2018-05-03 12:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 12:35 [PATCH for-rc v2 0/6] IB/hfi1,rdmavt: Fixes for the 4.17 RC Dennis Dalessandro
2018-05-01 12:35 ` Dennis Dalessandro
2018-05-01 12:35 ` [PATCH for-rc v2 1/6] IB/hfi1: Fix handling of FECN marked multicast packet Dennis Dalessandro
2018-05-01 18:05 ` Jason Gunthorpe
2018-05-01 21:58 ` Marciniszyn, Mike
2018-05-02 2:24 ` Doug Ledford
2018-05-03 12:54 ` Marciniszyn, Mike [this message]
2018-05-03 19:08 ` Doug Ledford
2018-05-03 19:25 ` Doug Ledford
2018-05-01 12:35 ` [PATCH for-rc v2 3/6] IB/hfi1: Fix loss of BECN with AHG Dennis Dalessandro
2018-05-01 12:35 ` [PATCH for-rc v2 4/6] IB/hfi1: Fix NULL pointer dereference when invalid num_vls is used Dennis Dalessandro
2018-05-01 17:18 ` [PATCH for-rc v2 0/6] IB/hfi1,rdmavt: Fixes for the 4.17 RC Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32E1700B9017364D9B60AED9960492BC62829957@fmsmsx120.amr.corp.intel.com \
--to=mike.marciniszyn@intel.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=don.hiatt@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.