All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: David Collins <collinsd@codeaurora.org>
Cc: Doug Anderson <dianders@chromium.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-msm@vger.kernel.org,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v2 2/2] regulator: add QCOM RPMh regulator driver
Date: Wed, 2 May 2018 06:02:58 +0900	[thread overview]
Message-ID: <20180501210258.GG2714@sirena.org.uk> (raw)
In-Reply-To: <f98416ac-230c-0362-ed50-a7f92ff283d7@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On Wed, Apr 25, 2018 at 02:04:56PM -0700, David Collins wrote:

> > Using -EAGAIN for "I can't ever read the configuration from this
> > regulator" doesn't seem right - it's not like any number of retries
> > will ever manage to read the value back.

> In this case, the _regulator_get_voltage() call can succeed, but only
> after a voltage is explicitly requested from the framework side.  The

...

> Do you still have reservations about using -EAGAIN for this purpose?  If
> so, which error code would you suggest using?

Yes, that's clearly a problem - -EAGAIN is more for situations where you
can just immediately retry like signal interruptions.  If the caller
repetedly sits and tries to read the voltage it'll never succeed unless
something else comes along and sets something.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] regulator: add QCOM RPMh regulator driver
Date: Wed, 2 May 2018 06:02:58 +0900	[thread overview]
Message-ID: <20180501210258.GG2714@sirena.org.uk> (raw)
In-Reply-To: <f98416ac-230c-0362-ed50-a7f92ff283d7@codeaurora.org>

On Wed, Apr 25, 2018 at 02:04:56PM -0700, David Collins wrote:

> > Using -EAGAIN for "I can't ever read the configuration from this
> > regulator" doesn't seem right - it's not like any number of retries
> > will ever manage to read the value back.

> In this case, the _regulator_get_voltage() call can succeed, but only
> after a voltage is explicitly requested from the framework side.  The

...

> Do you still have reservations about using -EAGAIN for this purpose?  If
> so, which error code would you suggest using?

Yes, that's clearly a problem - -EAGAIN is more for situations where you
can just immediately retry like signal interruptions.  If the caller
repetedly sits and tries to read the voltage it'll never succeed unless
something else comes along and sets something.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180502/c3175675/attachment.sig>

  reply	other threads:[~2018-05-01 21:02 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-14  2:50 [PATCH v2 0/2] regulator: add QCOM RPMh regulator driver David Collins
2018-04-14  2:50 ` David Collins
2018-04-14  2:50 ` [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings David Collins
2018-04-14  2:50   ` David Collins
2018-04-14  2:50   ` David Collins
2018-04-16 20:57   ` Rob Herring
2018-04-16 20:57     ` Rob Herring
2018-04-16 22:06     ` David Collins
2018-04-16 22:06       ` David Collins
2018-04-17 20:06   ` Doug Anderson
2018-04-17 20:06     ` Doug Anderson
2018-04-18 21:44     ` David Collins
2018-04-18 21:44       ` David Collins
2018-05-02 16:37   ` Doug Anderson
2018-05-02 16:37     ` Doug Anderson
2018-05-03  0:13     ` David Collins
2018-05-03  0:13       ` David Collins
2018-05-03 15:01       ` Doug Anderson
2018-05-03 15:01         ` Doug Anderson
2018-04-14  2:50 ` [PATCH v2 2/2] regulator: add QCOM RPMh regulator driver David Collins
2018-04-14  2:50   ` David Collins
2018-04-17 18:23   ` [v2,2/2] " Matthias Kaehlcke
2018-04-17 18:23     ` Matthias Kaehlcke
2018-04-17 19:15     ` David Collins
2018-04-17 19:15       ` David Collins
2018-04-17 19:47       ` Matthias Kaehlcke
2018-04-17 19:47         ` Matthias Kaehlcke
2018-04-18 21:34         ` David Collins
2018-04-18 21:34           ` David Collins
2018-04-18 17:02     ` Mark Brown
2018-04-18 17:02       ` Mark Brown
2018-04-17 20:02   ` [PATCH v2 2/2] " Doug Anderson
2018-04-17 20:02     ` Doug Anderson
2018-04-18 23:30     ` David Collins
2018-04-18 23:30       ` David Collins
2018-04-19  6:04       ` Stephen Boyd
2018-04-19  6:04         ` Stephen Boyd
2018-04-19 16:16       ` Doug Anderson
2018-04-19 16:16         ` Doug Anderson
2018-04-20 22:08         ` David Collins
2018-04-20 22:08           ` David Collins
2018-04-24 17:45           ` Mark Brown
2018-04-24 17:45             ` Mark Brown
2018-04-24 21:09             ` David Collins
2018-04-24 21:09               ` David Collins
2018-04-25 10:31               ` Mark Brown
2018-04-25 10:31                 ` Mark Brown
2018-04-25 21:04                 ` David Collins
2018-04-25 21:04                   ` David Collins
2018-05-01 21:02                   ` Mark Brown [this message]
2018-05-01 21:02                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180501210258.GG2714@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=collinsd@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mka@chromium.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.