* [PATCH] 8139too: Use disable_irq_nosync() in rtl8139_poll_controller()
@ 2018-05-02 11:30 Sebastian Andrzej Siewior
2018-05-02 17:22 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-05-02 11:30 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Ingo Molnar, Thomas Gleixner, Sebastian Andrzej Siewior
From: Ingo Molnar <mingo@elte.hu>
Use disable_irq_nosync() instead of disable_irq() as this might be
called in atomic context with netpoll.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/net/ethernet/realtek/8139too.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/8139too.c b/drivers/net/ethernet/realtek/8139too.c
index d24b47b8e0b2..d118da5a10a2 100644
--- a/drivers/net/ethernet/realtek/8139too.c
+++ b/drivers/net/ethernet/realtek/8139too.c
@@ -2224,7 +2224,7 @@ static void rtl8139_poll_controller(struct net_device *dev)
struct rtl8139_private *tp = netdev_priv(dev);
const int irq = tp->pci_dev->irq;
- disable_irq(irq);
+ disable_irq_nosync(irq);
rtl8139_interrupt(irq, dev);
enable_irq(irq);
}
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] 8139too: Use disable_irq_nosync() in rtl8139_poll_controller()
2018-05-02 11:30 [PATCH] 8139too: Use disable_irq_nosync() in rtl8139_poll_controller() Sebastian Andrzej Siewior
@ 2018-05-02 17:22 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-05-02 17:22 UTC (permalink / raw)
To: bigeasy; +Cc: netdev, mingo, tglx
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Wed, 2 May 2018 13:30:57 +0200
> From: Ingo Molnar <mingo@elte.hu>
>
> Use disable_irq_nosync() instead of disable_irq() as this might be
> called in atomic context with netpoll.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-02 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 11:30 [PATCH] 8139too: Use disable_irq_nosync() in rtl8139_poll_controller() Sebastian Andrzej Siewior
2018-05-02 17:22 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.