From: Vinod Koul <vinod.koul@intel.com>
To: Frank Mori Hess <fmh6jj@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
r.baldyga@hackerion.com
Subject: Revert "dmaengine: pl330: add DMA_PAUSE feature"
Date: Wed, 2 May 2018 10:02:30 +0530 [thread overview]
Message-ID: <20180502043230.GQ6014@localhost> (raw)
On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote:
> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d.
>
> The pl330.c pause implementation violates the dmaengine requirement
> for no data loss, since it relies on the DMAKILL
> instruction. However, DMAKILL discards in-flight data from the
> dma controller's fifo. This is documented in the dma-330 manual
> and I have observed it with hardware doing device-to-memory burst
> transfers. The discarded data may or may not show up in the
> residue count, depending on timing (resulting in data corruption
> effectively).
I am dropping the orignal patch for queue, so no need for revert patch.
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Frank Mori Hess <fmh6jj@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
r.baldyga@hackerion.com
Subject: Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"
Date: Wed, 2 May 2018 10:02:30 +0530 [thread overview]
Message-ID: <20180502043230.GQ6014@localhost> (raw)
In-Reply-To: <2484918.HKVQc3yJkt@bear>
On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote:
> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d.
>
> The pl330.c pause implementation violates the dmaengine requirement
> for no data loss, since it relies on the DMAKILL
> instruction. However, DMAKILL discards in-flight data from the
> dma controller's fifo. This is documented in the dma-330 manual
> and I have observed it with hardware doing device-to-memory burst
> transfers. The discarded data may or may not show up in the
> residue count, depending on timing (resulting in data corruption
> effectively).
I am dropping the orignal patch for queue, so no need for revert patch.
--
~Vinod
next reply other threads:[~2018-05-02 4:32 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 4:32 Vinod Koul [this message]
2018-05-02 4:32 ` [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature" Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-05-29 7:09 Vinod Koul
2018-05-29 7:09 ` Vinod
2018-05-29 5:17 Marek Szyprowski
2018-05-29 5:17 ` Marek Szyprowski
2018-05-23 5:39 Vinod Koul
2018-05-23 5:39 ` Vinod
2018-05-22 14:27 Frank Mori Hess
2018-05-22 14:27 ` Frank Mori Hess
2018-05-22 3:37 Vinod Koul
2018-05-22 3:37 ` Vinod Koul
2018-05-22 0:56 Frank Mori Hess
2018-05-22 0:56 ` Frank Mori Hess
2018-05-21 9:16 Vinod Koul
2018-05-21 9:16 ` Vinod Koul
2018-05-18 19:01 Frank Mori Hess
2018-05-18 19:01 ` Frank Mori Hess
2018-05-18 18:56 Frank Mori Hess
2018-05-18 18:56 ` Frank Mori Hess
2018-05-18 7:21 Vinod Koul
2018-05-18 7:21 ` Vinod
2018-05-18 6:28 Marek Szyprowski
2018-05-18 6:28 ` Marek Szyprowski
2018-05-18 4:03 Vinod Koul
2018-05-18 4:03 ` Vinod
2018-05-17 17:22 Lars-Peter Clausen
2018-05-17 17:22 ` Lars-Peter Clausen
2018-05-17 16:20 Frank Mori Hess
2018-05-17 16:20 ` Frank Mori Hess
2018-05-17 4:19 Vinod Koul
2018-05-17 4:19 ` Vinod Koul
2018-05-15 15:50 Frank Mori Hess
2018-05-15 15:50 ` Frank Mori Hess
2018-05-15 13:45 Vinod Koul
2018-05-15 13:45 ` Vinod
2018-05-15 12:24 Marek Szyprowski
2018-05-15 12:24 ` Marek Szyprowski
2018-05-15 6:21 Vinod Koul
2018-05-15 6:21 ` Vinod
2018-05-11 15:57 Frank Mori Hess
2018-05-11 15:57 ` Frank Mori Hess
2018-05-11 12:57 Marek Szyprowski
2018-05-11 12:57 ` Marek Szyprowski
2018-05-10 16:04 Frank Mori Hess
2018-05-10 16:04 ` Frank Mori Hess
2018-05-10 8:31 Marek Szyprowski
2018-05-10 8:31 ` Marek Szyprowski
2018-05-09 17:48 Frank Mori Hess
2018-05-09 17:48 ` Frank Mori Hess
2018-05-09 13:19 Marek Szyprowski
2018-05-09 13:19 ` Marek Szyprowski
2018-05-09 6:59 Vinod Koul
2018-05-09 6:59 ` Vinod Koul
2018-05-08 14:36 Frank Mori Hess
2018-05-08 14:36 ` Frank Mori Hess
2018-05-08 9:04 Marek Szyprowski
2018-05-08 9:04 ` Marek Szyprowski
2018-05-03 16:35 Vinod Koul
2018-05-03 16:35 ` [PATCH] " Vinod Koul
2018-05-03 9:01 Vinod Koul
2018-05-03 9:01 ` [PATCH] " Vinod Koul
2018-05-02 14:37 Frank Mori Hess
2018-05-02 14:37 ` [PATCH] " Frank Mori Hess
2018-04-28 21:50 Frank Mori Hess
2018-04-28 21:50 ` [PATCH] " Frank Mori Hess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502043230.GQ6014@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fmh6jj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=r.baldyga@hackerion.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.