From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Vladislav Yasevich <vyasevich@gmail.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, mst@redhat.com,
jasowang@redhat.com, nhorman@tuxdriver.com,
Vladislav Yasevich <vyasevic@redhat.com>
Subject: Re: [PATCH V2 net-next 4/6] tun: Add support for SCTP checksum offload
Date: Wed, 2 May 2018 11:56:07 -0300 [thread overview]
Message-ID: <20180502145607.GH5105@localhost.localdomain> (raw)
In-Reply-To: <20180502145347.GG5105@localhost.localdomain>
On Wed, May 02, 2018 at 11:53:47AM -0300, Marcelo Ricardo Leitner wrote:
> On Tue, May 01, 2018 at 10:07:37PM -0400, Vladislav Yasevich wrote:
> > Adds a new tun offload flag to allow for SCTP checksum offload.
> > The flag has to be set by the user and defaults to "no offload".
>
> I'm confused here:
>
> > +++ b/drivers/net/tun.c
> > @@ -216,7 +216,7 @@ struct tun_struct {
> > struct net_device *dev;
> > netdev_features_t set_features;
> > #define TUN_USER_FEATURES (NETIF_F_HW_CSUM|NETIF_F_TSO_ECN|NETIF_F_TSO| \
> > - NETIF_F_TSO6)
> > + NETIF_F_TSO6|NETIF_F_SCTP_CRC)
>
> Doesn't adding it here mean it defaults to "offload", instead?
>
> later on, it does:
> dev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST |
> TUN_USER_FEATURES | NETIF_F_HW_VLAN_CTAG_TX |
> NETIF_F_HW_VLAN_STAG_TX;
Missed to paste the next line too:
dev->features = dev->hw_features | NETIF_F_LLTX;
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Vladislav Yasevich <vyasevich@gmail.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, mst@redhat.com,
jasowang@redhat.com, nhorman@tuxdriver.com,
Vladislav Yasevich <vyasevic@redhat.com>
Subject: Re: [PATCH V2 net-next 4/6] tun: Add support for SCTP checksum offload
Date: Wed, 02 May 2018 14:56:07 +0000 [thread overview]
Message-ID: <20180502145607.GH5105@localhost.localdomain> (raw)
In-Reply-To: <20180502145347.GG5105@localhost.localdomain>
On Wed, May 02, 2018 at 11:53:47AM -0300, Marcelo Ricardo Leitner wrote:
> On Tue, May 01, 2018 at 10:07:37PM -0400, Vladislav Yasevich wrote:
> > Adds a new tun offload flag to allow for SCTP checksum offload.
> > The flag has to be set by the user and defaults to "no offload".
>
> I'm confused here:
>
> > +++ b/drivers/net/tun.c
> > @@ -216,7 +216,7 @@ struct tun_struct {
> > struct net_device *dev;
> > netdev_features_t set_features;
> > #define TUN_USER_FEATURES (NETIF_F_HW_CSUM|NETIF_F_TSO_ECN|NETIF_F_TSO| \
> > - NETIF_F_TSO6)
> > + NETIF_F_TSO6|NETIF_F_SCTP_CRC)
>
> Doesn't adding it here mean it defaults to "offload", instead?
>
> later on, it does:
> dev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST |
> TUN_USER_FEATURES | NETIF_F_HW_VLAN_CTAG_TX |
> NETIF_F_HW_VLAN_STAG_TX;
Missed to paste the next line too:
dev->features = dev->hw_features | NETIF_F_LLTX;
next prev parent reply other threads:[~2018-05-02 14:56 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 2:07 [PATCH V2 net-next 0/6] virtio-net: Add SCTP checksum offload support Vladislav Yasevich
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 2:07 ` [PATCH V2 net-next 1/6] virtio: Add support for SCTP checksum offloading Vladislav Yasevich
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 3:16 ` Michael S. Tsirkin
2018-05-02 3:16 ` [virtio-dev] " Michael S. Tsirkin
2018-05-02 3:16 ` Michael S. Tsirkin
2018-05-02 13:00 ` [virtio-dev] " Vlad Yasevich
2018-05-02 14:14 ` Marcelo Ricardo Leitner
2018-05-02 14:14 ` Marcelo Ricardo Leitner
2018-05-02 14:21 ` Michael S. Tsirkin
2018-05-02 14:21 ` Michael S. Tsirkin
2018-05-02 14:21 ` [virtio-dev] " Michael S. Tsirkin
2018-05-02 14:21 ` Michael S. Tsirkin
2018-05-02 14:34 ` Marcelo Ricardo Leitner
2018-05-02 14:34 ` Marcelo Ricardo Leitner
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 2:07 ` [PATCH V2 net-next 2/6] sctp: Handle sctp packets with CHECKSUM_PARTIAL Vladislav Yasevich
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 14:38 ` Marcelo Ricardo Leitner
2018-05-02 14:38 ` Marcelo Ricardo Leitner
2018-08-20 14:54 ` Marcelo Ricardo Leitner
2018-08-20 14:54 ` Marcelo Ricardo Leitner
2018-08-20 15:39 ` David Laight
2018-08-20 15:39 ` David Laight
2018-08-20 15:39 ` David Laight
2018-05-02 2:07 ` [PATCH V2 net-next 3/6] sctp: Build sctp offload support into the base kernel Vladislav Yasevich
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 2:07 ` [PATCH V2 net-next 4/6] tun: Add support for SCTP checksum offload Vladislav Yasevich
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 14:53 ` Marcelo Ricardo Leitner
2018-05-02 14:53 ` Marcelo Ricardo Leitner
2018-05-02 14:56 ` Marcelo Ricardo Leitner [this message]
2018-05-02 14:56 ` Marcelo Ricardo Leitner
2018-05-02 17:17 ` Vlad Yasevich
2018-05-02 17:17 ` Vlad Yasevich
2018-05-02 17:17 ` [virtio-dev] " Vlad Yasevich
2018-05-02 17:17 ` Vlad Yasevich
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 2:07 ` [PATCH V2 net-next 5/6] macvlan/macvtap: " Vladislav Yasevich
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 3:24 ` Michael S. Tsirkin
2018-05-02 3:24 ` Michael S. Tsirkin
2018-05-02 3:24 ` [virtio-dev] " Michael S. Tsirkin
2018-05-02 3:24 ` Michael S. Tsirkin
2018-05-02 13:27 ` Vlad Yasevich
2018-05-02 13:27 ` Vlad Yasevich
2018-05-02 13:27 ` [virtio-dev] " Vlad Yasevich
2018-05-02 13:27 ` Vlad Yasevich
2018-05-02 13:46 ` Michael S. Tsirkin
2018-05-02 13:46 ` Michael S. Tsirkin
2018-05-02 13:46 ` [virtio-dev] " Michael S. Tsirkin
2018-05-02 13:46 ` Michael S. Tsirkin
2018-05-02 14:00 ` Vlad Yasevich
2018-05-02 14:00 ` [virtio-dev] " Vlad Yasevich
2018-05-02 14:00 ` Vlad Yasevich
2018-05-02 14:17 ` Michael S. Tsirkin
2018-05-02 14:17 ` [virtio-dev] " Michael S. Tsirkin
2018-05-02 14:17 ` Michael S. Tsirkin
2018-05-02 14:25 ` Vlad Yasevich
2018-05-02 14:25 ` Vlad Yasevich
2018-05-02 14:25 ` [virtio-dev] " Vlad Yasevich
2018-05-02 14:25 ` Vlad Yasevich
2018-05-02 14:00 ` Vlad Yasevich
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 2:07 ` [PATCH V2 net-next 6/6] ipvlan: " Vladislav Yasevich
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 8:12 ` Davide Caratti
2018-05-02 8:12 ` Davide Caratti
2018-05-02 2:07 ` Vladislav Yasevich
2018-05-02 21:57 ` [PATCH V2 net-next 0/6] virtio-net: Add SCTP checksum offload support Marcelo Ricardo Leitner
2018-05-02 21:57 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502145607.GH5105@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=jasowang@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=vyasevic@redhat.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.