All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Max Reitz <mreitz@redhat.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH 0/4] block/xen_disk: legacy code removal and cleanup
Date: Wed, 2 May 2018 16:58:16 +0100	[thread overview]
Message-ID: <20180502155816.GD14376__16134.4050466598$1525276633$gmane$org@perard> (raw)
In-Reply-To: <1525089699-13411-1-git-send-email-paul.durrant@citrix.com>

On Mon, Apr 30, 2018 at 01:01:35PM +0100, Paul Durrant wrote:
> The grant copy operation was added to libxengnttab in Xen 4.8.0 (released
> nearly 18 months ago) but the xen_disk PV backend QEMU is still carrying
> a significant amount of code purely to remain compatible with older
> versions of Xen.
> 
> As can be inferred from the diff stats below, removing this support for
> older versions of Xen from QEMU reduces the size of the xen_disk source by
> more than 350 lines (~25%). The majority of this is done in patches #1
> and #2. Further simplifications are made in patch #3 and then some cosmetic
> work is done in patch #4.

FIY, I don't like this patch series. We've been checking that QEMU
builds against older version. I've check that it builds against 4.5 and
newer.

Also the fact that FreeBSD doesn't have support for grant copy probably
mean that it is too soon to remove the compatibility code from qemu.

Regards,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-05-02 15:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 12:01 [Qemu-devel] [PATCH 0/4] block/xen_disk: legacy code removal and cleanup Paul Durrant
2018-04-30 12:01 ` Paul Durrant
2018-04-30 12:01 ` [Qemu-devel] [PATCH 1/4] block/xen_disk: remove persistent grant code Paul Durrant
2018-04-30 12:01   ` Paul Durrant
2018-04-30 12:01 ` [Qemu-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap Paul Durrant
2018-04-30 12:01   ` Paul Durrant
2018-04-30 15:12   ` [Qemu-devel] [Xen-devel] " Roger Pau Monné
2018-04-30 15:12     ` Roger Pau Monné
2018-04-30 15:16     ` [Qemu-devel] [Xen-devel] " Paul Durrant
2018-04-30 15:16       ` Paul Durrant
2018-04-30 15:28       ` [Qemu-devel] [Xen-devel] " Roger Pau Monné
2018-04-30 15:28         ` Roger Pau Monné
2018-04-30 15:30         ` [Qemu-devel] [Xen-devel] " Paul Durrant
2018-04-30 15:30           ` Paul Durrant
2018-05-01 10:29           ` Wei Liu
2018-05-01 10:29           ` [Qemu-devel] [Xen-devel] " Wei Liu
2018-05-01 10:31             ` Paul Durrant
2018-05-01 10:31             ` [Qemu-devel] [Xen-devel] " Paul Durrant
2018-04-30 12:01 ` [Qemu-devel] [PATCH 3/4] block/xen_disk: use a single entry iovec Paul Durrant
2018-04-30 12:01   ` Paul Durrant
2018-04-30 12:01 ` [Qemu-devel] [PATCH 4/4] block/xen_disk: be consistent with use of xendev and blkdev->xendev Paul Durrant
2018-04-30 12:01   ` Paul Durrant
2018-05-02 15:58 ` Anthony PERARD [this message]
2018-05-02 15:58 ` [Qemu-devel] [PATCH 0/4] block/xen_disk: legacy code removal and cleanup Anthony PERARD
2018-05-02 16:03   ` Paul Durrant
2018-05-02 16:03   ` [Qemu-devel] " Paul Durrant
2018-05-03  9:55     ` Anthony PERARD
2018-05-03  9:55     ` Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180502155816.GD14376__16134.4050466598$1525276633$gmane$org@perard' \
    --to=anthony.perard@citrix.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=paul.durrant@citrix.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.