From: Paul Durrant <Paul.Durrant@citrix.com> To: Roger Pau Monne <roger.pau@citrix.com> Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "qemu-block@nongnu.org" <qemu-block@nongnu.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Anthony Perard <anthony.perard@citrix.com>, Kevin Wolf <kwolf@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, Max Reitz <mreitz@redhat.com> Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap Date: Mon, 30 Apr 2018 15:16:52 +0000 [thread overview] Message-ID: <dfeffd8d0d9f46fbbed1abb2bdaccd27@AMSPEX02CL03.citrite.net> (raw) In-Reply-To: <20180430151145.iyou5pisaclvvn3v@MacBook-Pro-de-Roger.local> > -----Original Message----- > From: Roger Pau Monne > Sent: 30 April 2018 16:12 > To: Paul Durrant <Paul.Durrant@citrix.com> > Cc: xen-devel@lists.xenproject.org; qemu-block@nongnu.org; qemu- > devel@nongnu.org; Anthony Perard <anthony.perard@citrix.com>; Kevin > Wolf <kwolf@redhat.com>; Stefano Stabellini <sstabellini@kernel.org>; Max > Reitz <mreitz@redhat.com> > Subject: Re: [Xen-devel] [PATCH 2/4] block/xen_disk: remove use of grant > map/unmap > > On Mon, Apr 30, 2018 at 01:01:37PM +0100, Paul Durrant wrote: > > The grant copy operation was added to libxengnttab in Xen 4.8.0. If grant > > copy is available then data from the guest will be copied rather than > > mapped. > > The xen_disk source can be significantly simplified by removing this now > > redundant code. > > Hm, I know this is a PITA, but FreeBSD gntdev hasn't implemented the > grant-copy operation yet. > > I could try to implement it, but I can't make any promises on the time > ATM, since I'm quite busy. > I guess we could carry a compat patch in QEMU that implements grant copy by doing a map/memcpy/unmap , but QEMU feels like the wrong place for that. I could try putting together a similar patch for the freebsd.c component of libxengnttab in the xen source rather than it simply failing with ENOSYS as it does now. Would either of those help? Cheers, Paul > Thanks, Roger.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Durrant <Paul.Durrant@citrix.com> To: Roger Pau Monne <roger.pau@citrix.com> Cc: Kevin Wolf <kwolf@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, "qemu-block@nongnu.org" <qemu-block@nongnu.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>, Anthony Perard <anthony.perard@citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Subject: Re: [PATCH 2/4] block/xen_disk: remove use of grant map/unmap Date: Mon, 30 Apr 2018 15:16:52 +0000 [thread overview] Message-ID: <dfeffd8d0d9f46fbbed1abb2bdaccd27@AMSPEX02CL03.citrite.net> (raw) In-Reply-To: <20180430151145.iyou5pisaclvvn3v@MacBook-Pro-de-Roger.local> > -----Original Message----- > From: Roger Pau Monne > Sent: 30 April 2018 16:12 > To: Paul Durrant <Paul.Durrant@citrix.com> > Cc: xen-devel@lists.xenproject.org; qemu-block@nongnu.org; qemu- > devel@nongnu.org; Anthony Perard <anthony.perard@citrix.com>; Kevin > Wolf <kwolf@redhat.com>; Stefano Stabellini <sstabellini@kernel.org>; Max > Reitz <mreitz@redhat.com> > Subject: Re: [Xen-devel] [PATCH 2/4] block/xen_disk: remove use of grant > map/unmap > > On Mon, Apr 30, 2018 at 01:01:37PM +0100, Paul Durrant wrote: > > The grant copy operation was added to libxengnttab in Xen 4.8.0. If grant > > copy is available then data from the guest will be copied rather than > > mapped. > > The xen_disk source can be significantly simplified by removing this now > > redundant code. > > Hm, I know this is a PITA, but FreeBSD gntdev hasn't implemented the > grant-copy operation yet. > > I could try to implement it, but I can't make any promises on the time > ATM, since I'm quite busy. > I guess we could carry a compat patch in QEMU that implements grant copy by doing a map/memcpy/unmap , but QEMU feels like the wrong place for that. I could try putting together a similar patch for the freebsd.c component of libxengnttab in the xen source rather than it simply failing with ENOSYS as it does now. Would either of those help? Cheers, Paul > Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-04-30 15:54 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-30 12:01 [Qemu-devel] [PATCH 0/4] block/xen_disk: legacy code removal and cleanup Paul Durrant 2018-04-30 12:01 ` Paul Durrant 2018-04-30 12:01 ` [Qemu-devel] [PATCH 1/4] block/xen_disk: remove persistent grant code Paul Durrant 2018-04-30 12:01 ` Paul Durrant 2018-04-30 12:01 ` [Qemu-devel] [PATCH 2/4] block/xen_disk: remove use of grant map/unmap Paul Durrant 2018-04-30 12:01 ` Paul Durrant 2018-04-30 15:12 ` [Qemu-devel] [Xen-devel] " Roger Pau Monné 2018-04-30 15:12 ` Roger Pau Monné 2018-04-30 15:16 ` Paul Durrant [this message] 2018-04-30 15:16 ` Paul Durrant 2018-04-30 15:28 ` [Qemu-devel] [Xen-devel] " Roger Pau Monné 2018-04-30 15:28 ` Roger Pau Monné 2018-04-30 15:30 ` [Qemu-devel] [Xen-devel] " Paul Durrant 2018-04-30 15:30 ` Paul Durrant 2018-05-01 10:29 ` Wei Liu 2018-05-01 10:29 ` [Qemu-devel] [Xen-devel] " Wei Liu 2018-05-01 10:31 ` Paul Durrant 2018-05-01 10:31 ` [Qemu-devel] [Xen-devel] " Paul Durrant 2018-04-30 12:01 ` [Qemu-devel] [PATCH 3/4] block/xen_disk: use a single entry iovec Paul Durrant 2018-04-30 12:01 ` Paul Durrant 2018-04-30 12:01 ` [Qemu-devel] [PATCH 4/4] block/xen_disk: be consistent with use of xendev and blkdev->xendev Paul Durrant 2018-04-30 12:01 ` Paul Durrant 2018-05-02 15:58 ` [PATCH 0/4] block/xen_disk: legacy code removal and cleanup Anthony PERARD 2018-05-02 15:58 ` [Qemu-devel] " Anthony PERARD 2018-05-02 16:03 ` Paul Durrant 2018-05-02 16:03 ` [Qemu-devel] " Paul Durrant 2018-05-03 9:55 ` Anthony PERARD 2018-05-03 9:55 ` Anthony PERARD
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dfeffd8d0d9f46fbbed1abb2bdaccd27@AMSPEX02CL03.citrite.net \ --to=paul.durrant@citrix.com \ --cc=anthony.perard@citrix.com \ --cc=kwolf@redhat.com \ --cc=mreitz@redhat.com \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=roger.pau@citrix.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.