From: "Michael S. Tsirkin" <mst@redhat.com> To: "Samudrala, Sridhar" <sridhar.samudrala@intel.com> Cc: Jiri Pirko <jiri@resnulli.us>, stephen@networkplumber.org, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, aaron.f.brown@intel.com Subject: Re: [PATCH net-next v9 2/4] net: Introduce generic failover module Date: Wed, 2 May 2018 23:30:02 +0300 [thread overview] Message-ID: <20180502232907-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <052e2c60-dc4c-d6a0-0159-fc1821cb4365@intel.com> On Wed, May 02, 2018 at 10:51:12AM -0700, Samudrala, Sridhar wrote: > > > On 5/2/2018 9:15 AM, Jiri Pirko wrote: > > Sat, Apr 28, 2018 at 11:06:01AM CEST, jiri@resnulli.us wrote: > > > Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudrala@intel.com wrote: > > [...] > > > > > > > > + > > > > + err = netdev_rx_handler_register(slave_dev, net_failover_handle_frame, > > > > + failover_dev); > > > > + if (err) { > > > > + netdev_err(slave_dev, "can not register failover rx handler (err = %d)\n", > > > > + err); > > > > + goto err_handler_register; > > > > + } > > > > + > > > > + err = netdev_upper_dev_link(slave_dev, failover_dev, NULL); > > > Please use netdev_master_upper_dev_link(). > > Don't forget to fillup struct netdev_lag_upper_info - NETDEV_LAG_TX_TYPE_ACTIVEBACKUP > > > > > > Also, please call netdev_lower_state_changed() when the active slave > > device changes from primary->backup of backup->primary and whenever link > > state of a slave changes > > > Sure. will look into it. Do you think this will help with the issue > you saw with having to change mac on standy twice to get the init scripts > working? We are now going to block changing the mac on both standby and > failover. > > Also, i was wondering if we should set dev->flags to IFF_MASTER on failover > and IFF_SLAVE on primary and standby. We do need a way to find things out, that's for sure. How does userspace know it's a failover config and find the failover device right now? > netvsc does this. > Does this help with the init scripts and network manager to skip slave > devices for dhcp requests? Try it?
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: "Samudrala, Sridhar" <sridhar.samudrala@intel.com> Cc: Jiri Pirko <jiri@resnulli.us>, stephen@networkplumber.org, davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com, aaron.f.brown@intel.com Subject: [virtio-dev] Re: [PATCH net-next v9 2/4] net: Introduce generic failover module Date: Wed, 2 May 2018 23:30:02 +0300 [thread overview] Message-ID: <20180502232907-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <052e2c60-dc4c-d6a0-0159-fc1821cb4365@intel.com> On Wed, May 02, 2018 at 10:51:12AM -0700, Samudrala, Sridhar wrote: > > > On 5/2/2018 9:15 AM, Jiri Pirko wrote: > > Sat, Apr 28, 2018 at 11:06:01AM CEST, jiri@resnulli.us wrote: > > > Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudrala@intel.com wrote: > > [...] > > > > > > > > + > > > > + err = netdev_rx_handler_register(slave_dev, net_failover_handle_frame, > > > > + failover_dev); > > > > + if (err) { > > > > + netdev_err(slave_dev, "can not register failover rx handler (err = %d)\n", > > > > + err); > > > > + goto err_handler_register; > > > > + } > > > > + > > > > + err = netdev_upper_dev_link(slave_dev, failover_dev, NULL); > > > Please use netdev_master_upper_dev_link(). > > Don't forget to fillup struct netdev_lag_upper_info - NETDEV_LAG_TX_TYPE_ACTIVEBACKUP > > > > > > Also, please call netdev_lower_state_changed() when the active slave > > device changes from primary->backup of backup->primary and whenever link > > state of a slave changes > > > Sure. will look into it. Do you think this will help with the issue > you saw with having to change mac on standy twice to get the init scripts > working? We are now going to block changing the mac on both standby and > failover. > > Also, i was wondering if we should set dev->flags to IFF_MASTER on failover > and IFF_SLAVE on primary and standby. We do need a way to find things out, that's for sure. How does userspace know it's a failover config and find the failover device right now? > netvsc does this. > Does this help with the init scripts and network manager to skip slave > devices for dhcp requests? Try it? --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-05-02 20:30 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-27 17:06 [PATCH net-next v9 0/4] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala 2018-04-27 17:06 ` [virtio-dev] " Sridhar Samudrala 2018-04-27 17:06 ` [PATCH net-next v9 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala 2018-04-27 17:06 ` [virtio-dev] " Sridhar Samudrala 2018-04-28 7:50 ` Jiri Pirko 2018-04-28 7:50 ` Jiri Pirko 2018-04-30 2:47 ` Samudrala, Sridhar 2018-04-30 2:47 ` [virtio-dev] " Samudrala, Sridhar 2018-04-30 7:03 ` Jiri Pirko 2018-04-30 19:14 ` Samudrala, Sridhar 2018-04-30 19:14 ` Samudrala, Sridhar 2018-04-30 19:14 ` [virtio-dev] " Samudrala, Sridhar 2018-04-30 2:47 ` Samudrala, Sridhar 2018-04-27 17:06 ` Sridhar Samudrala 2018-04-27 17:06 ` [PATCH net-next v9 2/4] net: Introduce generic failover module Sridhar Samudrala 2018-04-27 17:06 ` Sridhar Samudrala 2018-04-27 17:06 ` [virtio-dev] " Sridhar Samudrala 2018-04-27 17:53 ` Jiri Pirko 2018-04-27 17:53 ` Jiri Pirko 2018-04-28 8:15 ` Jiri Pirko 2018-04-30 2:47 ` Samudrala, Sridhar 2018-04-30 2:47 ` [virtio-dev] " Samudrala, Sridhar 2018-04-30 2:47 ` Samudrala, Sridhar 2018-04-28 8:15 ` Jiri Pirko 2018-04-28 9:06 ` Jiri Pirko 2018-04-30 3:03 ` Samudrala, Sridhar 2018-04-30 3:03 ` [virtio-dev] " Samudrala, Sridhar 2018-04-30 3:03 ` Samudrala, Sridhar 2018-05-02 16:15 ` Jiri Pirko 2018-05-02 17:51 ` Samudrala, Sridhar 2018-05-02 17:51 ` Samudrala, Sridhar 2018-05-02 17:51 ` [virtio-dev] " Samudrala, Sridhar 2018-05-02 20:30 ` Michael S. Tsirkin 2018-05-02 20:30 ` Michael S. Tsirkin [this message] 2018-05-02 20:30 ` [virtio-dev] " Michael S. Tsirkin 2018-05-02 21:36 ` Samudrala, Sridhar 2018-05-02 21:36 ` [virtio-dev] " Samudrala, Sridhar 2018-05-02 21:39 ` Jiri Pirko 2018-05-02 21:39 ` Jiri Pirko 2018-05-02 21:39 ` Jiri Pirko 2018-05-02 21:39 ` Jiri Pirko 2018-05-02 16:15 ` Jiri Pirko 2018-04-27 17:06 ` [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala 2018-04-27 17:06 ` Sridhar Samudrala 2018-04-27 17:06 ` [virtio-dev] " Sridhar Samudrala 2018-04-28 8:24 ` Jiri Pirko 2018-04-30 3:00 ` Samudrala, Sridhar 2018-04-30 3:00 ` [virtio-dev] " Samudrala, Sridhar 2018-04-30 7:12 ` Jiri Pirko 2018-04-30 7:12 ` Jiri Pirko 2018-04-30 19:26 ` Samudrala, Sridhar 2018-04-30 19:26 ` [virtio-dev] " Samudrala, Sridhar 2018-05-01 7:33 ` Jiri Pirko 2018-05-01 7:33 ` Jiri Pirko 2018-04-30 19:26 ` Samudrala, Sridhar 2018-04-30 3:00 ` Samudrala, Sridhar 2018-04-28 9:42 ` Jiri Pirko 2018-04-28 9:42 ` Jiri Pirko 2018-04-29 8:56 ` Siwei Liu 2018-04-29 8:56 ` Siwei Liu 2018-04-29 8:56 ` [virtio-dev] " Siwei Liu 2018-04-29 13:45 ` Jiri Pirko 2018-04-29 13:45 ` Jiri Pirko 2018-04-30 4:16 ` Samudrala, Sridhar 2018-04-30 4:16 ` Samudrala, Sridhar 2018-04-30 4:16 ` [virtio-dev] " Samudrala, Sridhar 2018-04-30 7:20 ` Jiri Pirko 2018-05-02 0:20 ` Samudrala, Sridhar 2018-05-02 0:20 ` Samudrala, Sridhar 2018-05-02 0:20 ` [virtio-dev] " Samudrala, Sridhar 2018-05-02 7:50 ` Jiri Pirko 2018-05-02 7:50 ` Jiri Pirko 2018-05-02 15:34 ` Samudrala, Sridhar 2018-05-02 15:34 ` Samudrala, Sridhar 2018-05-02 15:34 ` [virtio-dev] " Samudrala, Sridhar 2018-05-02 16:05 ` Jiri Pirko 2018-05-02 15:47 ` Michael S. Tsirkin 2018-05-02 15:47 ` [virtio-dev] " Michael S. Tsirkin 2018-05-02 16:04 ` Jiri Pirko 2018-05-02 16:04 ` Jiri Pirko 2018-05-02 15:47 ` Michael S. Tsirkin 2018-04-30 7:20 ` Jiri Pirko 2018-04-27 17:07 ` [PATCH net-next v9 4/4] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala 2018-04-27 17:07 ` Sridhar Samudrala 2018-04-27 17:07 ` [virtio-dev] " Sridhar Samudrala 2018-04-27 17:45 ` [PATCH net-next v9 0/4] Enable virtio_net to act as a standby for a passthru device Jiri Pirko 2018-04-27 17:45 ` Jiri Pirko 2018-04-27 17:53 ` Samudrala, Sridhar 2018-04-27 17:53 ` Samudrala, Sridhar 2018-04-27 17:53 ` [virtio-dev] " Samudrala, Sridhar 2018-04-27 19:38 ` Jiri Pirko 2018-04-27 19:38 ` Jiri Pirko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180502232907-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=aaron.f.brown@intel.com \ --cc=alexander.h.duyck@intel.com \ --cc=davem@davemloft.net \ --cc=jasowang@redhat.com \ --cc=jesse.brandeburg@intel.com \ --cc=jiri@resnulli.us \ --cc=kubakici@wp.pl \ --cc=loseweigh@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=sridhar.samudrala@intel.com \ --cc=stephen@networkplumber.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.