* [CI] drm/i915/execlists: Emit i915_trace_request_out for preemption @ 2018-05-02 23:02 Chris Wilson 2018-05-03 0:06 ` ✓ Fi.CI.BAT: success for " Patchwork 2018-05-03 8:38 ` ✓ Fi.CI.IGT: " Patchwork 0 siblings, 2 replies; 3+ messages in thread From: Chris Wilson @ 2018-05-02 23:02 UTC (permalink / raw) To: intel-gfx Move the tracepoint into the common execlists_context_schedule_out() and call it from preemption completion as well. A small bit of refactoring code should help with when tracing, or else we end up with requests mysteriously disappearing and some being emitted to HW multiple times. Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> --- drivers/gpu/drm/i915/intel_lrc.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index e04798e98db2..3d747d1c3d4d 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c @@ -398,10 +398,11 @@ execlists_context_schedule_in(struct i915_request *rq) } static inline void -execlists_context_schedule_out(struct i915_request *rq) +execlists_context_schedule_out(struct i915_request *rq, unsigned long status) { intel_engine_context_out(rq->engine); - execlists_context_status_change(rq, INTEL_CONTEXT_SCHEDULE_OUT); + execlists_context_status_change(rq, status); + trace_i915_request_out(rq); } static void @@ -772,12 +773,10 @@ execlists_cancel_port_requests(struct intel_engine_execlists * const execlists) intel_engine_get_seqno(rq->engine)); GEM_BUG_ON(!execlists->active); - intel_engine_context_out(rq->engine); - - execlists_context_status_change(rq, - i915_request_completed(rq) ? - INTEL_CONTEXT_SCHEDULE_OUT : - INTEL_CONTEXT_SCHEDULE_PREEMPTED); + execlists_context_schedule_out(rq, + i915_request_completed(rq) ? + INTEL_CONTEXT_SCHEDULE_OUT : + INTEL_CONTEXT_SCHEDULE_PREEMPTED); i915_request_put(rq); @@ -1105,8 +1104,8 @@ static void execlists_submission_tasklet(unsigned long data) */ GEM_BUG_ON(!i915_request_completed(rq)); - execlists_context_schedule_out(rq); - trace_i915_request_out(rq); + execlists_context_schedule_out(rq, + INTEL_CONTEXT_SCHEDULE_OUT); i915_request_put(rq); GEM_TRACE("%s completed ctx=%d\n", -- 2.17.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/execlists: Emit i915_trace_request_out for preemption 2018-05-02 23:02 [CI] drm/i915/execlists: Emit i915_trace_request_out for preemption Chris Wilson @ 2018-05-03 0:06 ` Patchwork 2018-05-03 8:38 ` ✓ Fi.CI.IGT: " Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-05-03 0:06 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/execlists: Emit i915_trace_request_out for preemption URL : https://patchwork.freedesktop.org/series/42600/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4126 -> Patchwork_8888 = == Summary - WARNING == Minor unknown changes coming with Patchwork_8888 need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_8888, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/42600/revisions/1/mbox/ == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_8888: === IGT changes === ==== Warnings ==== igt@gem_exec_gttfill@basic: fi-pnv-d510: PASS -> SKIP == Known issues == Here are the changes found in Patchwork_8888 that come from known issues: === IGT changes === ==== Issues hit ==== igt@gem_exec_suspend@basic-s4-devices: fi-skl-guc: PASS -> FAIL (fdo#104699) igt@kms_flip@basic-flip-vs-wf_vblank: fi-cfl-s3: PASS -> FAIL (fdo#100368) fi-cnl-psr: PASS -> FAIL (fdo#103928, fdo#100368) igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: fi-cfl-s3: PASS -> FAIL (fdo#103481) ==== Possible fixes ==== igt@debugfs_test@read_all_entries: fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS igt@kms_frontbuffer_tracking@basic: fi-hsw-peppy: DMESG-FAIL -> PASS igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: fi-ivb-3520m: DMESG-WARN (fdo#106084) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481 fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928 fdo#104699 https://bugs.freedesktop.org/show_bug.cgi?id=104699 fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084 == Participating hosts (40 -> 37) == Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq == Build changes == * Linux: CI_DRM_4126 -> Patchwork_8888 CI_DRM_4126: c49cbe0d1eb8d4c0ad477b8c7fdc5fbd82617674 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4457: 43761534c6482dc67b9c3d8eeecd425ef40b3c4c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_8888: 80aec69a77166aed97cea5f64640ce3f00bbf5d1 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4457: 69a0d9192f52570211df74a12265c5d2b0721542 @ git://anongit.freedesktop.org/piglit == Linux commits == 80aec69a7716 drm/i915/execlists: Emit i915_trace_request_out for preemption == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8888/issues.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/execlists: Emit i915_trace_request_out for preemption 2018-05-02 23:02 [CI] drm/i915/execlists: Emit i915_trace_request_out for preemption Chris Wilson 2018-05-03 0:06 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2018-05-03 8:38 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-05-03 8:38 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/execlists: Emit i915_trace_request_out for preemption URL : https://patchwork.freedesktop.org/series/42600/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4126_full -> Patchwork_8888_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_8888_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_8888_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/42600/revisions/1/mbox/ == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_8888_full: === IGT changes === ==== Warnings ==== igt@gem_mocs_settings@mocs-rc6-dirty-render: shard-kbl: PASS -> SKIP +1 == Known issues == Here are the changes found in Patchwork_8888_full that come from known issues: === IGT changes === ==== Issues hit ==== igt@gem_pwrite_pread@snooped-pwrite-blt-cpu_mmap-performance: shard-apl: PASS -> INCOMPLETE (fdo#103927) igt@kms_flip@2x-dpms-vs-vblank-race-interruptible: shard-hsw: PASS -> FAIL (fdo#103060) +1 igt@kms_flip@plain-flip-fb-recreate: shard-hsw: PASS -> FAIL (fdo#100368) +1 igt@kms_sysfs_edid_timing: shard-apl: PASS -> WARN (fdo#100047) igt@pm_rpm@fences-dpms: shard-kbl: PASS -> DMESG-WARN (fdo#103558, fdo#105602) +13 ==== Possible fixes ==== igt@kms_flip@modeset-vs-vblank-race: shard-hsw: FAIL (fdo#103060) -> PASS igt@kms_flip@wf_vblank-ts-check-interruptible: shard-glk: FAIL (fdo#100368) -> PASS +1 igt@kms_pipe_crc_basic@read-crc-pipe-c: shard-kbl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS +24 igt@kms_rotation_crc@sprite-rotation-270: shard-apl: FAIL (fdo#103925) -> PASS +1 igt@kms_setmode@basic: shard-kbl: FAIL (fdo#99912) -> PASS fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047 fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060 fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558 fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925 fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927 fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (8 -> 7) == Missing (1): pig-hsw-4770r == Build changes == * Linux: CI_DRM_4126 -> Patchwork_8888 CI_DRM_4126: c49cbe0d1eb8d4c0ad477b8c7fdc5fbd82617674 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4457: 43761534c6482dc67b9c3d8eeecd425ef40b3c4c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_8888: 80aec69a77166aed97cea5f64640ce3f00bbf5d1 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4457: 69a0d9192f52570211df74a12265c5d2b0721542 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8888/shards.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-03 8:38 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-05-02 23:02 [CI] drm/i915/execlists: Emit i915_trace_request_out for preemption Chris Wilson 2018-05-03 0:06 ` ✓ Fi.CI.BAT: success for " Patchwork 2018-05-03 8:38 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.