All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Kees Cook <keescook@chromium.org>,
	Cihangir Akturk <cakturk@gmail.com>
Subject: [PATCH 13/15] drm/vgem: Remove unecessary dma_fence_ops
Date: Thu,  3 May 2018 16:26:01 +0200	[thread overview]
Message-ID: <20180503142603.28513-14-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20180503142603.28513-1-daniel.vetter@ffwll.ch>

dma_fence_default_wait is the default now, same for the trivial
enable_signaling implementation.

Also remove the ->signaled callback, vgem can't peek ahead with a
fastpath, returning false is the default implementation.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Kees Cook <keescook@chromium.org>
Cc: Cihangir Akturk <cakturk@gmail.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/vgem/vgem_fence.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/gpu/drm/vgem/vgem_fence.c b/drivers/gpu/drm/vgem/vgem_fence.c
index b28876c222b4..75adedeaa384 100644
--- a/drivers/gpu/drm/vgem/vgem_fence.c
+++ b/drivers/gpu/drm/vgem/vgem_fence.c
@@ -43,16 +43,6 @@ static const char *vgem_fence_get_timeline_name(struct dma_fence *fence)
 	return "unbound";
 }
 
-static bool vgem_fence_signaled(struct dma_fence *fence)
-{
-	return false;
-}
-
-static bool vgem_fence_enable_signaling(struct dma_fence *fence)
-{
-	return true;
-}
-
 static void vgem_fence_release(struct dma_fence *base)
 {
 	struct vgem_fence *fence = container_of(base, typeof(*fence), base);
@@ -76,11 +66,7 @@ static void vgem_fence_timeline_value_str(struct dma_fence *fence, char *str,
 static const struct dma_fence_ops vgem_fence_ops = {
 	.get_driver_name = vgem_fence_get_driver_name,
 	.get_timeline_name = vgem_fence_get_timeline_name,
-	.enable_signaling = vgem_fence_enable_signaling,
-	.signaled = vgem_fence_signaled,
-	.wait = dma_fence_default_wait,
 	.release = vgem_fence_release,
-
 	.fence_value_str = vgem_fence_value_str,
 	.timeline_value_str = vgem_fence_timeline_value_str,
 };
-- 
2.17.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-05-03 14:26 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 14:25 [PATCH 00/15] dma-fence cleanup v2 Daniel Vetter
2018-05-03 14:25 ` [PATCH 01/15] dma-fence: remove fill_driver_data callback Daniel Vetter
2018-05-03 14:25 ` [PATCH 02/15] dma-fence: Make ->enable_signaling optional Daniel Vetter
2018-05-03 14:25   ` Daniel Vetter
2018-05-03 15:51   ` Chris Wilson
2018-05-03 15:51     ` Chris Wilson
2018-05-04 14:10   ` [PATCH] " Daniel Vetter
2018-05-04 14:10     ` Daniel Vetter
2018-05-07  9:35     ` Maarten Lankhorst
2018-05-07  9:35       ` Maarten Lankhorst
2018-05-03 14:25 ` [PATCH 03/15] dma-fence: Allow wait_any_timeout for all fences Daniel Vetter
2018-05-03 14:25   ` Daniel Vetter
2018-05-03 14:25 ` [PATCH 04/15] dma-fence: Make ->wait callback optional Daniel Vetter
2018-05-03 14:25   ` Daniel Vetter
2018-05-04  8:09   ` Chris Wilson
2018-05-04  8:09     ` Chris Wilson
2018-05-04  8:17     ` Daniel Vetter
2018-05-04  8:17       ` Daniel Vetter
2018-05-04  8:23       ` Daniel Vetter
2018-05-04  8:23         ` Daniel Vetter
2018-05-04  8:31         ` Chris Wilson
2018-05-04  8:57           ` Daniel Vetter
2018-05-04  8:57             ` Daniel Vetter
2018-05-04  9:16             ` Chris Wilson
2018-05-04  9:25               ` Daniel Vetter
2018-05-04  9:25                 ` Daniel Vetter
2018-05-04 13:17                 ` Christian König
2018-05-04 13:17                   ` Christian König
2018-05-04 13:47                   ` Daniel Vetter
2018-05-04 13:47                     ` Daniel Vetter
2018-07-02  8:23                     ` Daniel Vetter
2018-07-02  8:23                       ` Daniel Vetter
2018-07-02  8:49                       ` Christian König
2018-07-02  8:49                         ` Christian König
2018-05-03 14:25 ` [PATCH 05/15] drm/amdgpu: Remove unecessary dma_fence_ops Daniel Vetter
2018-05-03 14:25 ` [PATCH 06/15] drm: " Daniel Vetter
2018-05-03 14:25 ` [PATCH 07/15] drm/etnaviv: " Daniel Vetter
2018-05-04  6:59   ` Christian Gmeiner
2018-05-03 14:25 ` [PATCH 08/15] drm/i915: " Daniel Vetter
2018-05-04 14:09   ` [PATCH] " Daniel Vetter
     [not found] ` <20180503142603.28513-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-05-03 14:25   ` [PATCH 09/15] drm/msm: " Daniel Vetter
     [not found]     ` <20180503142603.28513-10-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-05-04 14:09       ` [PATCH] " Daniel Vetter
2018-05-03 14:25   ` [PATCH 10/15] drm/nouveau: " Daniel Vetter
2018-05-03 14:25 ` [PATCH 11/15] drm/qxl: " Daniel Vetter
2018-05-03 14:26 ` [PATCH 12/15] drm/vc4: " Daniel Vetter
2018-05-04 14:09   ` [PATCH] " Daniel Vetter
2018-05-03 14:26 ` Daniel Vetter [this message]
2018-05-03 14:26 ` [PATCH 14/15] drm/virtio: " Daniel Vetter
2018-07-03 11:14   ` Daniel Vetter
2018-07-03 11:14   ` Daniel Vetter
2018-05-03 14:26 ` [PATCH 15/15] dma-fence: Polish kernel-doc for dma-fence.c Daniel Vetter
2018-05-03 14:26   ` Daniel Vetter
2018-05-04 14:06   ` [PATCH] " Daniel Vetter
2018-05-04 14:06     ` Daniel Vetter
2018-05-03 15:47 ` ✗ Fi.CI.CHECKPATCH: warning for dma-fence cleanup v2 Patchwork
2018-05-03 16:02 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-03 21:12 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-04 14:09 ` ✗ Fi.CI.BAT: failure for dma-fence cleanup v2 (rev3) Patchwork
2018-05-04 14:14 ` ✗ Fi.CI.CHECKPATCH: warning for dma-fence cleanup v2 (rev6) Patchwork
2018-05-04 14:28 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-04 16:02 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503142603.28513-14-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=cakturk@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=keescook@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.