Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Gustavo Padovan <gustavo@padovan.org>,
	linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH 04/15] dma-fence: Make ->wait callback optional
Date: Fri, 4 May 2018 10:23:01 +0200	[thread overview]
Message-ID: <20180504082301.GR12521@phenom.ffwll.local> (raw)
In-Reply-To: <20180504081722.GQ12521@phenom.ffwll.local>

On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote:
> On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote:
> > Quoting Daniel Vetter (2018-05-03 15:25:52)
> > > Almost everyone uses dma_fence_default_wait.
> > > 
> > > v2: Also remove the BUG_ON(!ops->wait) (Chris).
> > 
> > I just don't get the rationale for implicit over explicit.
> 
> Closer approximation of dwim semantics. There's been tons of patch series
> all over drm and related places to get there, once we have a big pile of
> implementations and know what the dwim semantics should be. Individually
> they're all not much, in aggregate they substantially simplify simple
> drivers.

I also think clearer separation between optional optimization hooks and
mandatory core parts is useful in itself.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)

From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 04/15] dma-fence: Make ->wait callback optional
Date: Fri, 4 May 2018 10:23:01 +0200	[thread overview]
Message-ID: <20180504082301.GR12521@phenom.ffwll.local> (raw)
In-Reply-To: <20180504081722.GQ12521@phenom.ffwll.local>

On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote:
> On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote:
> > Quoting Daniel Vetter (2018-05-03 15:25:52)
> > > Almost everyone uses dma_fence_default_wait.
> > > 
> > > v2: Also remove the BUG_ON(!ops->wait) (Chris).
> > 
> > I just don't get the rationale for implicit over explicit.
> 
> Closer approximation of dwim semantics. There's been tons of patch series
> all over drm and related places to get there, once we have a big pile of
> implementations and know what the dwim semantics should be. Individually
> they're all not much, in aggregate they substantially simplify simple
> drivers.

I also think clearer separation between optional optimization hooks and
mandatory core parts is useful in itself.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

next prev parent reply	other threads:[~2018-05-04  8:23 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 14:25 [PATCH 00/15] dma-fence cleanup v2 Daniel Vetter
2018-05-03 14:25 ` [PATCH 01/15] dma-fence: remove fill_driver_data callback Daniel Vetter
2018-05-03 14:25 ` [PATCH 02/15] dma-fence: Make ->enable_signaling optional Daniel Vetter
2018-05-03 14:25   ` Daniel Vetter
2018-05-03 15:51   ` Chris Wilson
2018-05-03 15:51     ` Chris Wilson
2018-05-04 14:10   ` [PATCH] " Daniel Vetter
2018-05-04 14:10     ` Daniel Vetter
2018-05-07  9:35     ` Maarten Lankhorst
2018-05-07  9:35       ` Maarten Lankhorst
2018-05-03 14:25 ` [PATCH 03/15] dma-fence: Allow wait_any_timeout for all fences Daniel Vetter
2018-05-03 14:25   ` Daniel Vetter
2018-05-03 14:25 ` [PATCH 04/15] dma-fence: Make ->wait callback optional Daniel Vetter
2018-05-03 14:25   ` Daniel Vetter
2018-05-04  8:09   ` Chris Wilson
2018-05-04  8:09     ` Chris Wilson
2018-05-04  8:17     ` Daniel Vetter
2018-05-04  8:17       ` Daniel Vetter
2018-05-04  8:23       ` Daniel Vetter [this message]
2018-05-04  8:23         ` Daniel Vetter
2018-05-04  8:31         ` Chris Wilson
2018-05-04  8:57           ` Daniel Vetter
2018-05-04  8:57             ` Daniel Vetter
2018-05-04  9:16             ` Chris Wilson
2018-05-04  9:25               ` Daniel Vetter
2018-05-04  9:25                 ` Daniel Vetter
2018-05-04 13:17                 ` Christian König
2018-05-04 13:17                   ` Christian König
2018-05-04 13:47                   ` Daniel Vetter
2018-05-04 13:47                     ` Daniel Vetter
2018-07-02  8:23                     ` Daniel Vetter
2018-07-02  8:23                       ` Daniel Vetter
2018-07-02  8:49                       ` Christian König
2018-07-02  8:49                         ` Christian König
2018-05-03 14:25 ` [PATCH 05/15] drm/amdgpu: Remove unecessary dma_fence_ops Daniel Vetter
2018-05-03 14:25 ` [PATCH 06/15] drm: " Daniel Vetter
2018-05-03 14:25 ` [PATCH 07/15] drm/etnaviv: " Daniel Vetter
2018-05-04  6:59   ` Christian Gmeiner
2018-05-03 14:25 ` [PATCH 08/15] drm/i915: " Daniel Vetter
2018-05-04 14:09   ` [PATCH] " Daniel Vetter
     [not found] ` <20180503142603.28513-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-05-03 14:25   ` [PATCH 09/15] drm/msm: " Daniel Vetter
     [not found]     ` <20180503142603.28513-10-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-05-04 14:09       ` [PATCH] " Daniel Vetter
2018-05-03 14:25   ` [PATCH 10/15] drm/nouveau: " Daniel Vetter
2018-05-03 14:25 ` [PATCH 11/15] drm/qxl: " Daniel Vetter
2018-05-03 14:26 ` [PATCH 12/15] drm/vc4: " Daniel Vetter
2018-05-04 14:09   ` [PATCH] " Daniel Vetter
2018-05-03 14:26 ` [PATCH 13/15] drm/vgem: " Daniel Vetter
2018-05-03 14:26 ` [PATCH 14/15] drm/virtio: " Daniel Vetter
2018-07-03 11:14   ` Daniel Vetter
2018-07-03 11:14   ` Daniel Vetter
2018-05-03 14:26 ` [PATCH 15/15] dma-fence: Polish kernel-doc for dma-fence.c Daniel Vetter
2018-05-03 14:26   ` Daniel Vetter
2018-05-04 14:06   ` [PATCH] " Daniel Vetter
2018-05-04 14:06     ` Daniel Vetter
2018-05-03 15:47 ` ✗ Fi.CI.CHECKPATCH: warning for dma-fence cleanup v2 Patchwork
2018-05-03 16:02 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-03 21:12 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-04 14:09 ` ✗ Fi.CI.BAT: failure for dma-fence cleanup v2 (rev3) Patchwork
2018-05-04 14:14 ` ✗ Fi.CI.CHECKPATCH: warning for dma-fence cleanup v2 (rev6) Patchwork
2018-05-04 14:28 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-04 16:02 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180504082301.GR12521@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@padovan.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.