All of lore.kernel.org
 help / color / mirror / Atom feed
* Droid 4: very confusing config around OHCI_OMAP3_HCD
@ 2018-05-03 19:25 ` Pavel Machek
  0 siblings, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2018-05-03 19:25 UTC (permalink / raw)
  To: kernel list, linux-arm-kernel, linux-omap, tony, sre, nekit1000,
	mpartap, merlijn

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Hi!

For power management experiments, I tried

CONFIG_USB_OHCI_HCD=y
CONFIG_USB_OHCI_HCD_OMAP3=m
CONFIG_USB_OHCI_HCD_PLATFORM=y

and could not find resulting .ko.

Help text says:

CONFIG_USB_OHCI_HCD_OMAP3:

This option is deprecated now and the driver was removed, use
USB_OHCI_HCD_PLATFORM instead.

Enables support for the on-chip OHCI controller on
OMAP3 and later chips.

Which may partly explain it. But if the option no longer does
anything, why keep it? Certainly second part is confusing if option is
NOP...

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Droid 4: very confusing config around OHCI_OMAP3_HCD
@ 2018-05-03 19:25 ` Pavel Machek
  0 siblings, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2018-05-03 19:25 UTC (permalink / raw)
  To: linux-arm-kernel

Hi!

For power management experiments, I tried

CONFIG_USB_OHCI_HCD=y
CONFIG_USB_OHCI_HCD_OMAP3=m
CONFIG_USB_OHCI_HCD_PLATFORM=y

and could not find resulting .ko.

Help text says:

CONFIG_USB_OHCI_HCD_OMAP3:

This option is deprecated now and the driver was removed, use
USB_OHCI_HCD_PLATFORM instead.

Enables support for the on-chip OHCI controller on
OMAP3 and later chips.

Which may partly explain it. But if the option no longer does
anything, why keep it? Certainly second part is confusing if option is
NOP...

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180503/4585a41e/attachment.sig>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Droid 4: very confusing config around OHCI_OMAP3_HCD
  2018-05-03 19:25 ` Pavel Machek
@ 2018-05-03 19:28   ` Tony Lindgren
  -1 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2018-05-03 19:28 UTC (permalink / raw)
  To: Pavel Machek
  Cc: kernel list, linux-arm-kernel, linux-omap, sre, nekit1000,
	mpartap, merlijn

* Pavel Machek <pavel@ucw.cz> [180503 19:27]:
> Hi!
> 
> For power management experiments, I tried
> 
> CONFIG_USB_OHCI_HCD=y
> CONFIG_USB_OHCI_HCD_OMAP3=m
> CONFIG_USB_OHCI_HCD_PLATFORM=y
> 
> and could not find resulting .ko.
> 
> Help text says:
> 
> CONFIG_USB_OHCI_HCD_OMAP3:
> 
> This option is deprecated now and the driver was removed, use
> USB_OHCI_HCD_PLATFORM instead.
> 
> Enables support for the on-chip OHCI controller on
> OMAP3 and later chips.
> 
> Which may partly explain it. But if the option no longer does
> anything, why keep it? Certainly second part is confusing if option is
> NOP...

Yeah it's ohci-platform now, I think we decided to keep the old one
around to avoid breaking people's .config files for booting rather
than silently fail.

Regards,

Tony

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Droid 4: very confusing config around OHCI_OMAP3_HCD
@ 2018-05-03 19:28   ` Tony Lindgren
  0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2018-05-03 19:28 UTC (permalink / raw)
  To: linux-arm-kernel

* Pavel Machek <pavel@ucw.cz> [180503 19:27]:
> Hi!
> 
> For power management experiments, I tried
> 
> CONFIG_USB_OHCI_HCD=y
> CONFIG_USB_OHCI_HCD_OMAP3=m
> CONFIG_USB_OHCI_HCD_PLATFORM=y
> 
> and could not find resulting .ko.
> 
> Help text says:
> 
> CONFIG_USB_OHCI_HCD_OMAP3:
> 
> This option is deprecated now and the driver was removed, use
> USB_OHCI_HCD_PLATFORM instead.
> 
> Enables support for the on-chip OHCI controller on
> OMAP3 and later chips.
> 
> Which may partly explain it. But if the option no longer does
> anything, why keep it? Certainly second part is confusing if option is
> NOP...

Yeah it's ohci-platform now, I think we decided to keep the old one
around to avoid breaking people's .config files for booting rather
than silently fail.

Regards,

Tony

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Droid 4: very confusing config around OHCI_OMAP3_HCD
  2018-05-03 19:28   ` Tony Lindgren
@ 2018-05-03 19:38     ` Pavel Machek
  -1 siblings, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2018-05-03 19:38 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: kernel list, linux-arm-kernel, linux-omap, sre, nekit1000,
	mpartap, merlijn

[-- Attachment #1: Type: text/plain, Size: 2096 bytes --]

On Thu 2018-05-03 12:28:38, Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [180503 19:27]:
> > Hi!
> > 
> > For power management experiments, I tried
> > 
> > CONFIG_USB_OHCI_HCD=y
> > CONFIG_USB_OHCI_HCD_OMAP3=m
> > CONFIG_USB_OHCI_HCD_PLATFORM=y
> > 
> > and could not find resulting .ko.
> > 
> > Help text says:
> > 
> > CONFIG_USB_OHCI_HCD_OMAP3:
> > 
> > This option is deprecated now and the driver was removed, use
> > USB_OHCI_HCD_PLATFORM instead.
> > 
> > Enables support for the on-chip OHCI controller on
> > OMAP3 and later chips.
> > 
> > Which may partly explain it. But if the option no longer does
> > anything, why keep it? Certainly second part is confusing if option is
> > NOP...
> 
> Yeah it's ohci-platform now, I think we decided to keep the old one
> around to avoid breaking people's .config files for booting rather
> than silently fail.

Ok, what about this? (Should I do the same for the other drivers?)
Or at least put (DEPRECATED) as other drivers do?

Situation is quite confusing if you already have PLATFORM=y. OMAP=m
can be selected, but nothing happens.

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 5d958da..67c151a 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -455,7 +455,7 @@ config USB_OHCI_HCD_AT91
           Atmel chips.
 
 config USB_OHCI_HCD_OMAP3
-	tristate "OHCI support for OMAP3 and later chips"
+	tristate "dummy option for backwards compatibility"
 	depends on (ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5)
 	select USB_OHCI_HCD_PLATFORM
 	default y
@@ -463,9 +463,6 @@ config USB_OHCI_HCD_OMAP3
 	  This option is deprecated now and the driver was removed, use
 	  USB_OHCI_HCD_PLATFORM instead.
 
-	  Enables support for the on-chip OHCI controller on
-	  OMAP3 and later chips.
-
 config USB_OHCI_HCD_DAVINCI
 	tristate "OHCI support for TI DaVinci DA8xx"
 	depends on ARCH_DAVINCI_DA8XX

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Droid 4: very confusing config around OHCI_OMAP3_HCD
@ 2018-05-03 19:38     ` Pavel Machek
  0 siblings, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2018-05-03 19:38 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu 2018-05-03 12:28:38, Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [180503 19:27]:
> > Hi!
> > 
> > For power management experiments, I tried
> > 
> > CONFIG_USB_OHCI_HCD=y
> > CONFIG_USB_OHCI_HCD_OMAP3=m
> > CONFIG_USB_OHCI_HCD_PLATFORM=y
> > 
> > and could not find resulting .ko.
> > 
> > Help text says:
> > 
> > CONFIG_USB_OHCI_HCD_OMAP3:
> > 
> > This option is deprecated now and the driver was removed, use
> > USB_OHCI_HCD_PLATFORM instead.
> > 
> > Enables support for the on-chip OHCI controller on
> > OMAP3 and later chips.
> > 
> > Which may partly explain it. But if the option no longer does
> > anything, why keep it? Certainly second part is confusing if option is
> > NOP...
> 
> Yeah it's ohci-platform now, I think we decided to keep the old one
> around to avoid breaking people's .config files for booting rather
> than silently fail.

Ok, what about this? (Should I do the same for the other drivers?)
Or at least put (DEPRECATED) as other drivers do?

Situation is quite confusing if you already have PLATFORM=y. OMAP=m
can be selected, but nothing happens.

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 5d958da..67c151a 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -455,7 +455,7 @@ config USB_OHCI_HCD_AT91
           Atmel chips.
 
 config USB_OHCI_HCD_OMAP3
-	tristate "OHCI support for OMAP3 and later chips"
+	tristate "dummy option for backwards compatibility"
 	depends on (ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5)
 	select USB_OHCI_HCD_PLATFORM
 	default y
@@ -463,9 +463,6 @@ config USB_OHCI_HCD_OMAP3
 	  This option is deprecated now and the driver was removed, use
 	  USB_OHCI_HCD_PLATFORM instead.
 
-	  Enables support for the on-chip OHCI controller on
-	  OMAP3 and later chips.
-
 config USB_OHCI_HCD_DAVINCI
 	tristate "OHCI support for TI DaVinci DA8xx"
 	depends on ARCH_DAVINCI_DA8XX

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180503/9205ad12/attachment.sig>

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: Droid 4: very confusing config around OHCI_OMAP3_HCD
  2018-05-03 19:38     ` Pavel Machek
@ 2018-05-03 22:07       ` Tony Lindgren
  -1 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2018-05-03 22:07 UTC (permalink / raw)
  To: Pavel Machek
  Cc: kernel list, linux-arm-kernel, linux-omap, sre, nekit1000,
	mpartap, merlijn

* Pavel Machek <pavel@ucw.cz> [180503 19:40]:
> On Thu 2018-05-03 12:28:38, Tony Lindgren wrote:
> Ok, what about this? (Should I do the same for the other drivers?)
> Or at least put (DEPRECATED) as other drivers do?
> 
> Situation is quite confusing if you already have PLATFORM=y. OMAP=m
> can be selected, but nothing happens.

Sure works for me, let's see what linux-usb people think.

Regards,

Tony


> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 5d958da..67c151a 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -455,7 +455,7 @@ config USB_OHCI_HCD_AT91
>            Atmel chips.
>  
>  config USB_OHCI_HCD_OMAP3
> -	tristate "OHCI support for OMAP3 and later chips"
> +	tristate "dummy option for backwards compatibility"
>  	depends on (ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5)
>  	select USB_OHCI_HCD_PLATFORM
>  	default y
> @@ -463,9 +463,6 @@ config USB_OHCI_HCD_OMAP3
>  	  This option is deprecated now and the driver was removed, use
>  	  USB_OHCI_HCD_PLATFORM instead.
>  
> -	  Enables support for the on-chip OHCI controller on
> -	  OMAP3 and later chips.
> -
>  config USB_OHCI_HCD_DAVINCI
>  	tristate "OHCI support for TI DaVinci DA8xx"
>  	depends on ARCH_DAVINCI_DA8XX
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Droid 4: very confusing config around OHCI_OMAP3_HCD
@ 2018-05-03 22:07       ` Tony Lindgren
  0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2018-05-03 22:07 UTC (permalink / raw)
  To: linux-arm-kernel

* Pavel Machek <pavel@ucw.cz> [180503 19:40]:
> On Thu 2018-05-03 12:28:38, Tony Lindgren wrote:
> Ok, what about this? (Should I do the same for the other drivers?)
> Or at least put (DEPRECATED) as other drivers do?
> 
> Situation is quite confusing if you already have PLATFORM=y. OMAP=m
> can be selected, but nothing happens.

Sure works for me, let's see what linux-usb people think.

Regards,

Tony


> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 5d958da..67c151a 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -455,7 +455,7 @@ config USB_OHCI_HCD_AT91
>            Atmel chips.
>  
>  config USB_OHCI_HCD_OMAP3
> -	tristate "OHCI support for OMAP3 and later chips"
> +	tristate "dummy option for backwards compatibility"
>  	depends on (ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5)
>  	select USB_OHCI_HCD_PLATFORM
>  	default y
> @@ -463,9 +463,6 @@ config USB_OHCI_HCD_OMAP3
>  	  This option is deprecated now and the driver was removed, use
>  	  USB_OHCI_HCD_PLATFORM instead.
>  
> -	  Enables support for the on-chip OHCI controller on
> -	  OMAP3 and later chips.
> -
>  config USB_OHCI_HCD_DAVINCI
>  	tristate "OHCI support for TI DaVinci DA8xx"
>  	depends on ARCH_DAVINCI_DA8XX
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-05-03 22:07 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-03 19:25 Droid 4: very confusing config around OHCI_OMAP3_HCD Pavel Machek
2018-05-03 19:25 ` Pavel Machek
2018-05-03 19:28 ` Tony Lindgren
2018-05-03 19:28   ` Tony Lindgren
2018-05-03 19:38   ` Pavel Machek
2018-05-03 19:38     ` Pavel Machek
2018-05-03 22:07     ` Tony Lindgren
2018-05-03 22:07       ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.