All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Revert "Makefile: add target to print generated files"
@ 2018-05-04  5:42 Markus Armbruster
  2018-05-04 12:52 ` Eric Blake
  0 siblings, 1 reply; 2+ messages in thread
From: Markus Armbruster @ 2018-05-04  5:42 UTC (permalink / raw)
  To: qemu-devel; +Cc: Michael S . Tsirkin

This reverts commit 9578f8cc3e8bd71de8e3f543dc7b95644d64824e.

The patch snuck in by accident without having been posted to
qemu-devel.  It's entirely redundant: existing target print-% already
serves the purpose.

Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 Makefile | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Makefile b/Makefile
index d71dd5bea4..f36110d4aa 100644
--- a/Makefile
+++ b/Makefile
@@ -1047,9 +1047,6 @@ endif
 include $(SRC_PATH)/tests/docker/Makefile.include
 include $(SRC_PATH)/tests/vm/Makefile.include
 
-printgen:
-	@echo $(GENERATED_FILES)
-
 .PHONY: help
 help:
 	@echo  'Generic targets:'
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] Revert "Makefile: add target to print generated files"
  2018-05-04  5:42 [Qemu-devel] [PATCH] Revert "Makefile: add target to print generated files" Markus Armbruster
@ 2018-05-04 12:52 ` Eric Blake
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Blake @ 2018-05-04 12:52 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel; +Cc: Michael S . Tsirkin

On 05/04/2018 12:42 AM, Markus Armbruster wrote:
> This reverts commit 9578f8cc3e8bd71de8e3f543dc7b95644d64824e.
> 
> The patch snuck in by accident without having been posted to
> qemu-devel.  It's entirely redundant: existing target print-% already
> serves the purpose.
> 
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   Makefile | 3 ---
>   1 file changed, 3 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/Makefile b/Makefile
> index d71dd5bea4..f36110d4aa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1047,9 +1047,6 @@ endif
>   include $(SRC_PATH)/tests/docker/Makefile.include
>   include $(SRC_PATH)/tests/vm/Makefile.include
>   
> -printgen:
> -	@echo $(GENERATED_FILES)
> -
>   .PHONY: help
>   help:
>   	@echo  'Generic targets:'
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-04 12:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04  5:42 [Qemu-devel] [PATCH] Revert "Makefile: add target to print generated files" Markus Armbruster
2018-05-04 12:52 ` Eric Blake

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.