* [PATCH] ARM: dts: imx6sx-sabreauto: add debug LED support
@ 2018-04-27 6:58 ` Anson Huang
0 siblings, 0 replies; 4+ messages in thread
From: Anson Huang @ 2018-04-27 6:58 UTC (permalink / raw)
To: shawnguo, kernel, fabio.estevam, robh+dt, mark.rutland
Cc: Linux-imx, linux-arm-kernel, devicetree, linux-kernel
There is a debug LED(D11) connected to GPIO1_IO24, add
support for it.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
this patch is based on patch series (ARM: dts: imx6sx-sabreauto: add wdog external reset support).
arch/arm/boot/dts/imx6sx-sabreauto.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
index eb1452c..6b94f24 100644
--- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
+++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
@@ -18,6 +18,18 @@
reg = <0x80000000 0x80000000>;
};
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_led>;
+
+ user {
+ label = "debug";
+ gpios = <&gpio1 24 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+
regulators {
compatible = "simple-bus";
#address-cells = <1>;
@@ -119,6 +131,12 @@
&iomuxc {
imx6x-sabreauto {
+ pinctrl_led: ledgrp {
+ fsl,pins = <
+ MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
+ >;
+ };
+
pinctrl_enet1_1: enet1grp-1 {
fsl,pins = <
MX6SX_PAD_ENET1_MDIO__ENET1_MDIO 0xa0b1
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6sx-sabreauto: add debug LED support
@ 2018-04-27 6:58 ` Anson Huang
0 siblings, 0 replies; 4+ messages in thread
From: Anson Huang @ 2018-04-27 6:58 UTC (permalink / raw)
To: linux-arm-kernel
There is a debug LED(D11) connected to GPIO1_IO24, add
support for it.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
this patch is based on patch series (ARM: dts: imx6sx-sabreauto: add wdog external reset support).
arch/arm/boot/dts/imx6sx-sabreauto.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
index eb1452c..6b94f24 100644
--- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
+++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
@@ -18,6 +18,18 @@
reg = <0x80000000 0x80000000>;
};
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_led>;
+
+ user {
+ label = "debug";
+ gpios = <&gpio1 24 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+
regulators {
compatible = "simple-bus";
#address-cells = <1>;
@@ -119,6 +131,12 @@
&iomuxc {
imx6x-sabreauto {
+ pinctrl_led: ledgrp {
+ fsl,pins = <
+ MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
+ >;
+ };
+
pinctrl_enet1_1: enet1grp-1 {
fsl,pins = <
MX6SX_PAD_ENET1_MDIO__ENET1_MDIO 0xa0b1
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6sx-sabreauto: add debug LED support
2018-04-27 6:58 ` Anson Huang
@ 2018-05-04 8:23 ` Shawn Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-05-04 8:23 UTC (permalink / raw)
To: Anson Huang
Cc: kernel, fabio.estevam, robh+dt, mark.rutland, Linux-imx,
linux-arm-kernel, devicetree, linux-kernel
On Fri, Apr 27, 2018 at 02:58:08PM +0800, Anson Huang wrote:
> There is a debug LED(D11) connected to GPIO1_IO24, add
> support for it.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> this patch is based on patch series (ARM: dts: imx6sx-sabreauto: add wdog external reset support).
In this case, you can include these two patches into the series, if you
need to resend the series.
Shawn
> arch/arm/boot/dts/imx6sx-sabreauto.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index eb1452c..6b94f24 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -18,6 +18,18 @@
> reg = <0x80000000 0x80000000>;
> };
>
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_led>;
> +
> + user {
> + label = "debug";
> + gpios = <&gpio1 24 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +
> regulators {
> compatible = "simple-bus";
> #address-cells = <1>;
> @@ -119,6 +131,12 @@
> &iomuxc {
> imx6x-sabreauto {
>
> + pinctrl_led: ledgrp {
> + fsl,pins = <
> + MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
> + >;
> + };
> +
Try to sort the pinctrl node alphabetically.
Shawn
> pinctrl_enet1_1: enet1grp-1 {
> fsl,pins = <
> MX6SX_PAD_ENET1_MDIO__ENET1_MDIO 0xa0b1
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6sx-sabreauto: add debug LED support
@ 2018-05-04 8:23 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-05-04 8:23 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 27, 2018 at 02:58:08PM +0800, Anson Huang wrote:
> There is a debug LED(D11) connected to GPIO1_IO24, add
> support for it.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> this patch is based on patch series (ARM: dts: imx6sx-sabreauto: add wdog external reset support).
In this case, you can include these two patches into the series, if you
need to resend the series.
Shawn
> arch/arm/boot/dts/imx6sx-sabreauto.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index eb1452c..6b94f24 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -18,6 +18,18 @@
> reg = <0x80000000 0x80000000>;
> };
>
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_led>;
> +
> + user {
> + label = "debug";
> + gpios = <&gpio1 24 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +
> regulators {
> compatible = "simple-bus";
> #address-cells = <1>;
> @@ -119,6 +131,12 @@
> &iomuxc {
> imx6x-sabreauto {
>
> + pinctrl_led: ledgrp {
> + fsl,pins = <
> + MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
> + >;
> + };
> +
Try to sort the pinctrl node alphabetically.
Shawn
> pinctrl_enet1_1: enet1grp-1 {
> fsl,pins = <
> MX6SX_PAD_ENET1_MDIO__ENET1_MDIO 0xa0b1
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-04 8:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27 6:58 [PATCH] ARM: dts: imx6sx-sabreauto: add debug LED support Anson Huang
2018-04-27 6:58 ` Anson Huang
2018-05-04 8:23 ` Shawn Guo
2018-05-04 8:23 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.