All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@cavium.com>
To: Matt Redfearn <matt.redfearn@mips.com>
Cc: James Hogan <jhogan@kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org, Huacai Chen <chenhc@lemote.com>,
	linux-kernel@vger.kernel.org,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Robert Richter <rric@kernel.org>,
	oprofile-list@lists.sf.net
Subject: Re: [RFC PATCH] MIPS: Oprofile: Drop support
Date: Fri, 4 May 2018 11:30:02 +0200	[thread overview]
Message-ID: <20180504093002.GC4493@rric.localdomain> (raw)
In-Reply-To: <5e464a40-4e4d-dde4-b5b5-ceb637dc5f38@mips.com>

On 24.04.18 14:15:58, Matt Redfearn wrote:
> On 24/04/18 14:05, James Hogan wrote:
> >On Tue, Apr 24, 2018 at 01:55:54PM +0100, Matt Redfearn wrote:
> >>Since it appears that MIPS oprofile support is currently broken, core
> >>oprofile is not getting many updates and not as many architectures
> >>implement support for it compared to perf, remove the MIPS support.
> >
> >That sounds reasonable to me. Any idea how long its been broken?
> 
> Sorry, not yet. I haven't yet looked into where/how it's broken that would
> narrow that down...

oprofile moved to perf syscall as kernel i/f with version 1.0.0. The
opcontrol script that was using the oprofile kernel i/f was removed:

 https://sourceforge.net/p/oprofile/oprofile/ci/0c142c3a096d3e9ec42cc9b0ddad994fea60d135/

Thus, cpus that do not support the perf syscall are no longer
supported by 1.x releases.

 https://sourceforge.net/p/oprofile/oprofile/ci/797d01dea0b82dbbdb0c21112a3de75990e011d2/

For those remainings there is still version 0.9.x available (tagged
PRE_RELEASE_1_0).

I am undecided whether removing oprofile kernel i/f falls under the
rule of "never break user space" here. Strictly seen, yes it breaks
those remainings. So if the perf syscall is not available as an
alternative, the oprofile kernel support shouldn't be removed.

-Robert

  reply	other threads:[~2018-05-04  9:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 12:55 [RFC PATCH] MIPS: Oprofile: Drop support Matt Redfearn
2018-04-24 12:55 ` Matt Redfearn
2018-04-24 13:05 ` James Hogan
2018-04-24 13:15   ` Matt Redfearn
2018-04-24 13:15     ` Matt Redfearn
2018-05-04  9:30     ` Robert Richter [this message]
2018-05-04  9:54       ` Matt Redfearn
2018-05-04  9:54         ` Matt Redfearn
2018-05-04 10:26         ` Robert Richter
2018-05-04 11:03           ` Matt Redfearn
2018-05-04 11:03             ` Matt Redfearn
2018-05-04 12:27             ` Robert Richter
2018-05-04 12:56               ` Ralf Baechle
2018-05-04 12:59               ` Matt Redfearn
2018-05-04 12:59                 ` Matt Redfearn
2018-04-24 13:59 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180504093002.GC4493@rric.localdomain \
    --to=robert.richter@cavium.com \
    --cc=chenhc@lemote.com \
    --cc=jhogan@kernel.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=matt.redfearn@mips.com \
    --cc=oprofile-list@lists.sf.net \
    --cc=ralf@linux-mips.org \
    --cc=rric@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.