All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Richter <rric@kernel.org>
To: Matt Redfearn <matt.redfearn@mips.com>
Cc: James Hogan <jhogan@kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org, Huacai Chen <chenhc@lemote.com>,
	linux-kernel@vger.kernel.org,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	oprofile-list@lists.sf.net
Subject: Re: [RFC PATCH] MIPS: Oprofile: Drop support
Date: Fri, 4 May 2018 14:27:51 +0200	[thread overview]
Message-ID: <20180504122750.GE4493@rric.localdomain> (raw)
In-Reply-To: <294858af-9164-f0c3-62d3-d6b643e89e09@mips.com>

On 04.05.18 12:03:12, Matt Redfearn wrote:
> >As said, oprofile version 0.9.x is still available for cpus that do
> >not support perf. What is the breakage?
> 
> The breakage I originally set out to fix was the MT support in perf.
> https://www.linux-mips.org/archives/linux-mips/2018-04/msg00259.html
> 
> Since the perf code shares so much copied code from oprofile, those same
> issues exist in oprofile and ought to be addressed. But as newer oprofile
> userspace does not use the (MIPS) kernel oprofile code, then we could,
> perhaps, just remove it (as per the RFC). That would break legacy tools
> (0.9.x) though...

Those support perf:

 (CPU_MIPS32 || CPU_MIPS64 || CPU_R10000 || CPU_SB1 || CPU_CAVIUM_OCTEON || CPU_XLP || CPU_LOONGSON3)

Here is the total list of CPU_*:

 $ git grep -h config.CPU_ arch/mips/ | sort -u | wc -l
 79

The comparisation might not be accurate, but at least gives a hint
that there are many cpus not supporting perf. You would drop profiling
support at al to them.

If it is too hard to also fix the oprofile code (code duplication
seems the main issue here), then it would be also ok to blacklist
newer cpus to enable oprofile kernel code (where it is broken).

-Robert

  reply	other threads:[~2018-05-04 12:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 12:55 [RFC PATCH] MIPS: Oprofile: Drop support Matt Redfearn
2018-04-24 12:55 ` Matt Redfearn
2018-04-24 13:05 ` James Hogan
2018-04-24 13:15   ` Matt Redfearn
2018-04-24 13:15     ` Matt Redfearn
2018-05-04  9:30     ` Robert Richter
2018-05-04  9:54       ` Matt Redfearn
2018-05-04  9:54         ` Matt Redfearn
2018-05-04 10:26         ` Robert Richter
2018-05-04 11:03           ` Matt Redfearn
2018-05-04 11:03             ` Matt Redfearn
2018-05-04 12:27             ` Robert Richter [this message]
2018-05-04 12:56               ` Ralf Baechle
2018-05-04 12:59               ` Matt Redfearn
2018-05-04 12:59                 ` Matt Redfearn
2018-04-24 13:59 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180504122750.GE4493@rric.localdomain \
    --to=rric@kernel.org \
    --cc=chenhc@lemote.com \
    --cc=jhogan@kernel.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=matt.redfearn@mips.com \
    --cc=oprofile-list@lists.sf.net \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.