[Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

[Valentin Vidic <Valentin.Vidic@CARNet.hr>]

Hello,

We are starting to see mkfs segfaults after updating
linux-libc-dev from 4.15.17-1 to 4.16.5-1 due to a
change in gfs2_ondisk.h.  Hope there is enough info
below for a fix? :)


Reading symbols from ./gfs2-utils-3.1.10/gfs2/mkfs/mkfs.gfs2...done.
(gdb) run -p lock_nolock test
Starting program: /build/gfs2-utils-7xEZHP/gfs2-utils-3.1.10/gfs2/mkfs/mkfs.gfs2 -p lock_nolock test
This will destroy any data on test
Are you sure you want to proceed? [y/n] y
Adding journals: Done 
Building resource groups: Done 

Program received signal SIGSEGV, Segmentation fault.
0x00005555555628eb in gfs2_bit_search (state=<optimized out>, mask=<optimized out>, ptr=<optimized out>)
    at fs_bits.c:52
52      fs_bits.c: No such file or directory.
(gdb) bt
#0  0x00005555555628eb in gfs2_bit_search (state=<optimized out>, mask=<optimized out>, ptr=<optimized out>)
    at fs_bits.c:52
#1  gfs2_bitfit (buf=0x80 <error: Cannot access memory@address 0x80>, len=3968, goal=goal at entry=0, 
    state=state at entry=0 '\000') at fs_bits.c:83
#2  0x000055555555d8ad in find_free_block (rgd=0x555555771140) at fs_ops.c:130
#3  block_alloc (sdp=sdp at entry=0x7fffffffe5c0, blksreq=blksreq at entry=1, state=state at entry=3, 
    blkno=blkno at entry=0x7fffffffe1c0, dinode=dinode at entry=1) at fs_ops.c:194
#4  0x000055555555df77 in lgfs2_dinode_alloc (sdp=sdp at entry=0x7fffffffe5c0, blksreq=blksreq at entry=1, 
    blkno=blkno at entry=0x7fffffffe1c0) at fs_ops.c:204
#5  0x000055555556128f in build_master (sdp=0x7fffffffe5c0) at structures.c:28
#6  0x00005555555574fc in main (argc=<optimized out>, argv=<optimized out>) at main_mkfs.c:996


[1299334.480182] mkfs.gfs2[8647]: segfault at 80 ip 000055b2d13ce8eb sp 00007ffdfee7d610 error 4 in mkfs.gfs2[55b2d13c0000+14000]
[1299334.825045] mkfs.gfs2[8664]: segfault at 5618126ef030 ip 000056184cdf78a4 sp 00007ffe0c276710 error 4 in mkfs.gfs2[56184cdee000+14000]
[1299335.171449] mkfs.gfs2[8682]: segfault at 5596866d1030 ip 000055960db568a4 sp 00007ffc4072dd00 error 4 in mkfs.gfs2[55960db4d000+14000]
[1299335.262298] mkfs.gfs2[8701]: segfault at 80 ip 00005615eb5dd8eb sp 00007ffed55fdb10 error 4 in mkfs.gfs2[5615eb5cf000+14000]
[1299335.351462] mkfs.gfs2[8718]: segfault at 80 ip 000055e2d9a508eb sp 00007ffccda01720 error 4 in mkfs.gfs2[55e2d9a42000+14000]
[1299335.441570] mkfs.gfs2[8735]: segfault at 80 ip 000055fa8db3c8eb sp 00007ffca73ea830 error 4 in mkfs.gfs2[55fa8db2e000+14000]
[1299335.784656] mkfs.gfs2[8752]: segfault at 55c7ff95e030 ip 000055c7622bf8a4 sp 00007ffd80ef8660 error 4 in mkfs.gfs2[55c7622b6000+14000]
[1299336.302229] mkfs.gfs2[8769]: segfault at 80 ip 000055798a41a8eb sp 00007ffdfc3de780 error 4 in mkfs.gfs2[55798a40c000+14000]
[1299336.436435] mkfs.gfs2[8786]: segfault at 80 ip 000055744bd948eb sp 00007ffd9215ff80 error 4 in mkfs.gfs2[55744bd86000+14000]
[1299336.510427] mkfs.gfs2[8803]: segfault at 80 ip 00005598402c88eb sp 00007ffd824ab990 error 4 in mkfs.gfs2[5598402ba000+14000]


## ----------------------------- ##
## gfs2-utils master test suite. ##
## ----------------------------- ##

mkfs.gfs2 tests

  1: Locking protocol validation                     ok
  2: Resource group size validation                  ok
  3: Journal size validation                         ok
  4: Block count validation                          ok
  5: Quota change file size validation               ok
  6: Locking protocols                               FAILED (mkfs.at:36)
  7: Valid block sizes 512-4096                      FAILED (mkfs.at:42)
  8: Max. blocks, min. block size                    FAILED (mkfs.at:50)
  9: Max. blocks, max. block size                    FAILED (mkfs.at:55)
 10: Max. resource group size                        FAILED (mkfs.at:60)
 11: Min. resource group size                        FAILED (mkfs.at:65)
 12: Max. resource group size, min. block size       FAILED (mkfs.at:70)
 13: Max. journal size                               FAILED (mkfs.at:75)
 14: Min. journal size                               FAILED (mkfs.at:80)
 15: Max. quota change file size                     FAILED (mkfs.at:85)
 16: Min. quota change file size                     FAILED (mkfs.at:90)
 17: Lock table validation                           FAILED (mkfs.at:98)
 18: Device i/o limits handling                      FAILED
(mkfs.at:107)

fsck.gfs2 tests

 19: Fix invalid block sizes                         FAILED (fsck.at:6)
 20: Fix invalid goal blocks                         FAILED (fsck.at:15)
 21: Fix bad resource group #0                       FAILED (fsck.at:20)
 22: Fix bad resource group #1                       FAILED (fsck.at:25)
 23: Fix bad rindex entry #1                         FAILED (fsck.at:35)

gfs2_edit tests

 24: Save/restoremeta, defaults                      FAILED (edit.at:7)
 25: Save/restoremeta, no compression                FAILED (edit.at:20)
 26: Save/restoremeta, min. block size               FAILED (edit.at:30)
 27: Save/restoremeta, 4 journals                    FAILED (edit.at:40)
 28: Save/restoremeta, min. block size, 4 journals   FAILED (edit.at:50)

libgfs2 unit tests

 29: meta.c                                          FAILED (libgfs2.at:4)
 30: rgrp.c                                          ok

## ------------- ##
## Test results. ##
## ------------- ##

ERROR: All 30 tests were run,
24 failed unexpectedly.

-- 
Valentin