All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel
Date: Fri, 4 May 2018 14:01:31 +0100	[thread overview]
Message-ID: <f0acfbed-3adb-cd3a-fa77-b88c76d310bd@redhat.com> (raw)
In-Reply-To: <20180504120105.GT4608@gavran.carpriv.carnet.hr>

On 04/05/18 13:01, Valentin Vidic wrote:
> On Fri, May 04, 2018 at 12:07:01PM +0100, Andrew Price wrote:
>> Hm curious. I *can* reproduce the same segfaults but only if I build with
>> the 4.15 header and then rebuild with the 4.16 header *without* first
>> running ./configure. If I run ./configure the problem resolves itself.
> 
> Thanks, I removed all traces of 4.15 from the system, did a clean
> checkout of the repo and master does not segfault anymore :)

Ok good, we're on the same page :)

> I will try to fix 3.1.10 now...

I suspect you'll find the problem in gfs2/libgfs2/ondisk.h where 
gfs2_rgrp_{in,out} copies the reserved data fields. As the field is 
smaller in the new gfs2_ondisk.h, the copies could write past the end of 
the struct into subsequent fields of the containing structure (the 
rgrp_tree). We should probably use sizeof() there. Same with 
gfs2_rindex_{in,out}.

Andy



  reply	other threads:[~2018-05-04 13:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04  9:42 [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel Valentin Vidic
2018-05-04  9:50 ` Valentin Vidic
2018-05-04 10:06   ` Andrew Price
2018-05-04 10:21     ` Valentin Vidic
2018-05-04 10:27       ` Andrew Price
2018-05-04 10:42         ` Valentin Vidic
2018-05-04 10:46           ` Andrew Price
2018-05-04 10:54             ` Valentin Vidic
2018-05-04 11:07               ` Andrew Price
2018-05-04 12:01                 ` Valentin Vidic
2018-05-04 13:01                   ` Andrew Price [this message]
2018-05-04 13:16                     ` Andrew Price
2018-05-04 14:00                       ` Valentin Vidic
2018-05-09 16:53                         ` Andrew Price
2018-05-10 19:47                           ` Valentin Vidic
2018-05-13  9:13                           ` Valentin Vidic
2018-05-14 13:24                             ` Andrew Price
2018-05-14 13:48                               ` Valentin Vidic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0acfbed-3adb-cd3a-fa77-b88c76d310bd@redhat.com \
    --to=anprice@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.