All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: "Martyn Welch"
	<martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
	"David Airlie" <airlied-cv59FeDIM0c@public.gmane.org>,
	"Gustavo Padovan"
	<gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	"Andrzej Hajda" <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"Laurent Pinchart"
	<Laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	"Benjamin Gaignard"
	<benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	"Archit Taneja" <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Joonyoung Shim"
	<jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"Kyungmin Park"
	<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"Krzysztof Kozlowski"
	<krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"Kukjin Kim" <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Peter Senna Tschudin"
	<peter.senna-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
	"CK Hu" <ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
	"Martin Donnelly" <martin.donnelly-JJi787mZWgc@public.gmane.org>,
	"Daniel Vetter" <daniel-/w4YWyX8dFk@public.gmane.org>,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Maarten Lankhorst"
	<maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"Jyri Sarha" <jsarha-l0cyMroinI0@public.gmane.org>
Subject: [PATCH v2 25/26] drm/bridge: require the owner .odev to be filled in on drm_bridge_add/attach
Date: Fri,  4 May 2018 15:52:11 +0200	[thread overview]
Message-ID: <20180504135212.26977-26-peda@axentia.se> (raw)
In-Reply-To: <20180504135212.26977-1-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>

The .odev owner device will be handy to have around.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/gpu/drm/drm_bridge.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index df084db33494..78d186b6831b 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -70,6 +70,9 @@ static LIST_HEAD(bridge_list);
  */
 void drm_bridge_add(struct drm_bridge *bridge)
 {
+	if (WARN_ON(!bridge->odev))
+		return;
+
 	mutex_lock(&bridge_lock);
 	list_add_tail(&bridge->list, &bridge_list);
 	mutex_unlock(&bridge_lock);
@@ -115,6 +118,9 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
 	if (!encoder || !bridge)
 		return -EINVAL;
 
+	if (WARN_ON(!bridge->odev))
+		return -EINVAL;
+
 	if (previous && (!previous->dev || previous->encoder != encoder))
 		return -EINVAL;
 
-- 
2.11.0

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

WARNING: multiple messages have this Message-ID (diff)
From: Peter Rosin <peda@axentia.se>
To: linux-kernel@vger.kernel.org
Cc: "Peter Rosin" <peda@axentia.se>,
	"Archit Taneja" <architt@codeaurora.org>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"David Airlie" <airlied@linux.ie>,
	"Peter Senna Tschudin" <peter.senna@collabora.com>,
	"Martin Donnelly" <martin.donnelly@ge.com>,
	"Martyn Welch" <martyn.welch@collabora.co.uk>,
	"Gustavo Padovan" <gustavo@padovan.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Sean Paul" <seanpaul@chromium.org>,
	"Inki Dae" <inki.dae@samsung.com>,
	"Joonyoung Shim" <jy0922.shim@samsung.com>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"CK Hu" <ck.hu@mediatek.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
	"Vincent Abriou" <vincent.abriou@st.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org, "Jyri Sarha" <jsarha@ti.com>,
	"Daniel Vetter" <daniel@ffwll.ch>
Subject: [PATCH v2 25/26] drm/bridge: require the owner .odev to be filled in on drm_bridge_add/attach
Date: Fri,  4 May 2018 15:52:11 +0200	[thread overview]
Message-ID: <20180504135212.26977-26-peda@axentia.se> (raw)
In-Reply-To: <20180504135212.26977-1-peda@axentia.se>

The .odev owner device will be handy to have around.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/gpu/drm/drm_bridge.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index df084db33494..78d186b6831b 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -70,6 +70,9 @@ static LIST_HEAD(bridge_list);
  */
 void drm_bridge_add(struct drm_bridge *bridge)
 {
+	if (WARN_ON(!bridge->odev))
+		return;
+
 	mutex_lock(&bridge_lock);
 	list_add_tail(&bridge->list, &bridge_list);
 	mutex_unlock(&bridge_lock);
@@ -115,6 +118,9 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
 	if (!encoder || !bridge)
 		return -EINVAL;
 
+	if (WARN_ON(!bridge->odev))
+		return -EINVAL;
+
 	if (previous && (!previous->dev || previous->encoder != encoder))
 		return -EINVAL;
 
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: peda@axentia.se (Peter Rosin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 25/26] drm/bridge: require the owner .odev to be filled in on drm_bridge_add/attach
Date: Fri,  4 May 2018 15:52:11 +0200	[thread overview]
Message-ID: <20180504135212.26977-26-peda@axentia.se> (raw)
In-Reply-To: <20180504135212.26977-1-peda@axentia.se>

The .odev owner device will be handy to have around.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/gpu/drm/drm_bridge.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index df084db33494..78d186b6831b 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -70,6 +70,9 @@ static LIST_HEAD(bridge_list);
  */
 void drm_bridge_add(struct drm_bridge *bridge)
 {
+	if (WARN_ON(!bridge->odev))
+		return;
+
 	mutex_lock(&bridge_lock);
 	list_add_tail(&bridge->list, &bridge_list);
 	mutex_unlock(&bridge_lock);
@@ -115,6 +118,9 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
 	if (!encoder || !bridge)
 		return -EINVAL;
 
+	if (WARN_ON(!bridge->odev))
+		return -EINVAL;
+
 	if (previous && (!previous->dev || previous->encoder != encoder))
 		return -EINVAL;
 
-- 
2.11.0

  parent reply	other threads:[~2018-05-04 13:52 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 13:51 [PATCH v2 00/26] device link, bridge supplier <-> drm device Peter Rosin
2018-05-04 13:51 ` Peter Rosin
2018-05-04 13:51 ` Peter Rosin
2018-05-04 13:51 ` [PATCH v2 02/26] drm/bridge: adv7511: provide an owner .odev device Peter Rosin
2018-05-04 13:51 ` [PATCH v2 03/26] drm/bridge/analogix: core: specify the owner .odev of the bridge Peter Rosin
2018-05-04 13:51 ` [PATCH v2 04/26] drm/bridge: analogix-anx78xx: provide an owner .odev device Peter Rosin
2018-05-04 13:51 ` [PATCH v2 05/26] drm/bridge: cdns-dsi: " Peter Rosin
2018-05-04 13:51 ` [PATCH v2 06/26] drm/bridge: vga-dac: " Peter Rosin
2018-05-04 13:51 ` [PATCH v2 07/26] drm/bridge: lvds-encoder: " Peter Rosin
2018-05-04 13:51 ` [PATCH v2 08/26] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: " Peter Rosin
2018-05-04 13:51 ` [PATCH v2 09/26] drm/bridge: nxp-ptn3460: " Peter Rosin
2018-05-04 13:51 ` [PATCH v2 10/26] drm/bridge: panel: " Peter Rosin
2018-05-08  6:51   ` Jyri Sarha
2018-05-08  6:51     ` Jyri Sarha
2018-05-08  7:58     ` Peter Rosin
2018-05-08 10:30       ` Daniel Vetter
2018-05-08 10:30         ` Daniel Vetter
2018-05-08 12:25       ` Jyri Sarha
2018-05-08 12:25         ` Jyri Sarha
2018-05-04 13:51 ` [PATCH v2 11/26] drm/bridge: ps8622: " Peter Rosin
2018-05-04 13:51 ` [PATCH v2 12/26] drm/bridge: sii902x: " Peter Rosin
2018-05-04 13:51 ` [PATCH v2 13/26] drm/bridge: sii9234: " Peter Rosin
2018-05-04 13:52 ` [PATCH v2 14/26] drm/bridge: sii8620: " Peter Rosin
2018-05-04 13:52 ` [PATCH v2 15/26] drm/bridge: synopsys: provide an owner .odev device for the bridges Peter Rosin
2018-05-04 13:52 ` [PATCH v2 16/26] drm/bridge: tc358767: provide an owner .odev device Peter Rosin
2018-05-04 13:52 ` [PATCH v2 17/26] drm/bridge: thc63lvd1024: " Peter Rosin
2018-05-04 13:52 ` [PATCH v2 18/26] drm/bridge: ti-tfp410: " Peter Rosin
2018-05-04 13:52 ` [PATCH v2 19/26] drm/exynos: mic: provide an owner .odev device for the bridge Peter Rosin
2018-05-04 13:52   ` Peter Rosin
2018-05-04 13:52   ` Peter Rosin
2018-05-04 13:52 ` [PATCH v2 20/26] drm/mediatek: hdmi: " Peter Rosin
2018-05-04 13:52   ` Peter Rosin
2018-05-04 13:52 ` [PATCH v2 22/26] drm/rcar-du: lvds: " Peter Rosin
2018-05-04 13:52 ` [PATCH v2 23/26] drm/sti: provide an owner .odev device for the bridges Peter Rosin
     [not found] ` <20180504135212.26977-1-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2018-05-04 13:51   ` [PATCH v2 01/26] drm/bridge: allow optionally specifying an owner .odev device Peter Rosin
2018-05-04 13:51     ` Peter Rosin
2018-05-04 13:51     ` Peter Rosin
2018-05-09 15:08     ` Andrzej Hajda
2018-05-09 15:08       ` Andrzej Hajda
2018-05-09 15:08       ` Andrzej Hajda
     [not found]       ` <4e92fdea-0609-0fff-0e3f-d9f78f596eb7-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-05-09 15:53         ` Peter Rosin
2018-05-09 15:53           ` Peter Rosin
2018-05-09 15:53           ` Peter Rosin
     [not found]           ` <4be4448e-763c-4832-f194-6b79afe87d08-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2018-05-09 22:21             ` Peter Rosin
2018-05-09 22:21               ` Peter Rosin
2018-05-09 22:21               ` Peter Rosin
2018-05-10  7:00               ` Andrzej Hajda
2018-05-10  7:00                 ` Andrzej Hajda
2018-05-10  7:00                 ` Andrzej Hajda
2018-05-04 13:52   ` [PATCH v2 21/26] drm/msm: specify the owner .odev of the bridges Peter Rosin
2018-05-04 13:52     ` Peter Rosin
2018-05-04 13:52   ` [PATCH v2 24/26] drm/bridge: remove the .of_node member Peter Rosin
2018-05-04 13:52     ` Peter Rosin
2018-05-04 13:52     ` Peter Rosin
2018-05-04 13:52   ` Peter Rosin [this message]
2018-05-04 13:52     ` [PATCH v2 25/26] drm/bridge: require the owner .odev to be filled in on drm_bridge_add/attach Peter Rosin
2018-05-04 13:52     ` Peter Rosin
2018-05-10  7:13     ` Andrzej Hajda
2018-05-10  7:13       ` Andrzej Hajda
2018-05-10  7:13       ` Andrzej Hajda
2018-05-04 13:52   ` [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer Peter Rosin
2018-05-04 13:52     ` Peter Rosin
2018-05-04 13:52     ` Peter Rosin
2018-05-07 12:59     ` Andrzej Hajda
2018-05-07 12:59       ` Andrzej Hajda
2018-05-07 12:59       ` Andrzej Hajda
     [not found]       ` <4cdcd215-8caf-e045-a478-f438f128c9f2-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-05-07 13:43         ` Peter Rosin
2018-05-07 13:43           ` Peter Rosin
2018-05-07 13:43           ` Peter Rosin
2018-05-08  9:03           ` Andrzej Hajda
2018-05-08  9:03             ` Andrzej Hajda
2018-05-08  9:03             ` Andrzej Hajda
2018-05-07 13:53         ` Daniel Vetter
2018-05-07 13:53           ` Daniel Vetter
2018-05-07 13:53           ` Daniel Vetter
     [not found]           ` <20180507135341.GI12521-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-05-08  6:36             ` Andrzej Hajda
2018-05-08  6:36             ` Andrzej Hajda
2018-05-08  6:36           ` Andrzej Hajda
2018-05-08  6:36             ` Andrzej Hajda
2018-05-08  6:36             ` Andrzej Hajda
2018-05-10  8:10     ` Andrzej Hajda
2018-05-10  8:10       ` Andrzej Hajda
2018-05-10  8:10       ` Andrzej Hajda
     [not found]       ` <a723ad4a-8caa-4ff5-d39d-52db98a56d7b-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-05-11  7:37         ` Peter Rosin
2018-05-11  7:37           ` Peter Rosin
2018-05-11  7:37           ` Peter Rosin
2018-05-14 16:28           ` Daniel Vetter
2018-05-14 16:28             ` Daniel Vetter
2018-05-14 16:28             ` Daniel Vetter
2018-05-14 16:28             ` Daniel Vetter
2018-05-14 20:40             ` Peter Rosin
2018-05-14 20:40             ` Peter Rosin
2018-05-14 20:40               ` Peter Rosin
2018-05-15 10:22               ` Daniel Vetter
2018-05-15 10:22                 ` Daniel Vetter
2018-05-15 10:22                 ` Daniel Vetter
     [not found]                 ` <CAKMK7uECSUo5k6uG3-y+yKQTGxB3FfGcwzMT+ZP5uux2SbpfUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-05-15 11:09                   ` Peter Rosin
2018-05-15 11:09                     ` Peter Rosin
2018-05-15 11:09                     ` Peter Rosin
2018-05-16  9:31                     ` Daniel Vetter
2018-05-16  9:31                       ` Daniel Vetter
2018-05-16  9:31                       ` Daniel Vetter
     [not found]             ` <20180514162828.GE28661-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-05-14 20:40               ` Peter Rosin
2018-05-14 20:40               ` Peter Rosin
2018-05-07 13:56 ` [PATCH v2 00/26] device link, bridge supplier <-> drm device Daniel Vetter
2018-05-07 13:56   ` Daniel Vetter
2018-05-07 13:56   ` Daniel Vetter
2018-05-07 14:09   ` Peter Rosin
     [not found]   ` <20180507135601.GJ12521-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-05-07 14:09     ` Peter Rosin
2018-05-07 14:09     ` Peter Rosin
2018-05-07 14:09   ` Peter Rosin
2018-05-07 14:09     ` Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180504135212.26977-26-peda@axentia.se \
    --to=peda-koto5c5qi+tlodktgw+v6w@public.gmane.org \
    --cc=Laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=daniel-/w4YWyX8dFk@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=jsarha-l0cyMroinI0@public.gmane.org \
    --cc=jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=martin.donnelly-JJi787mZWgc@public.gmane.org \
    --cc=martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
    --cc=peter.senna-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.