From: Antoine Tenart <antoine.tenart@bootlin.com> To: davem@davemloft.net, kishon@ti.com, linux@armlinux.org.uk, gregory.clement@bootlin.com, andrew@lunn.ch, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com Cc: Antoine Tenart <antoine.tenart@bootlin.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH net-next v2 03/13] net: phy: sfp: warn the user when no tx_disable pin is available Date: Fri, 4 May 2018 15:56:33 +0200 [thread overview] Message-ID: <20180504135643.23466-4-antoine.tenart@bootlin.com> (raw) In-Reply-To: <20180504135643.23466-1-antoine.tenart@bootlin.com> In case no Tx disable pin is available the SFP modules will always be emitting. This could be an issue when using modules using laser as their light source as we would have no way to disable it when the fiber is removed. This patch adds a warning when registering an SFP cage which do not have its tx_disable pin wired or available. Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> --- drivers/net/phy/sfp.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 8e323a4b70da..d4f503b2e3e2 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -1093,6 +1093,15 @@ static int sfp_probe(struct platform_device *pdev) if (!sfp->gpio[GPIO_MODDEF0] && !sfp->gpio[GPIO_LOS]) sfp->sm_dev_state = SFP_DEV_UNKNOWN; + /* We could have an issue in cases no Tx disable pin is available or + * wired as modules using a laser as their light source will continue to + * be active when the fiber is removed. This could be a safety issue and + * we should at least warn the user about that. + */ + if (!sfp->gpio[GPIO_TX_DISABLE]) + dev_warn(sfp->dev, + "No tx_disable pin: SFP modules will always be emitting.\n"); + return 0; } -- 2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: antoine.tenart@bootlin.com (Antoine Tenart) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH net-next v2 03/13] net: phy: sfp: warn the user when no tx_disable pin is available Date: Fri, 4 May 2018 15:56:33 +0200 [thread overview] Message-ID: <20180504135643.23466-4-antoine.tenart@bootlin.com> (raw) In-Reply-To: <20180504135643.23466-1-antoine.tenart@bootlin.com> In case no Tx disable pin is available the SFP modules will always be emitting. This could be an issue when using modules using laser as their light source as we would have no way to disable it when the fiber is removed. This patch adds a warning when registering an SFP cage which do not have its tx_disable pin wired or available. Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> --- drivers/net/phy/sfp.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 8e323a4b70da..d4f503b2e3e2 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -1093,6 +1093,15 @@ static int sfp_probe(struct platform_device *pdev) if (!sfp->gpio[GPIO_MODDEF0] && !sfp->gpio[GPIO_LOS]) sfp->sm_dev_state = SFP_DEV_UNKNOWN; + /* We could have an issue in cases no Tx disable pin is available or + * wired as modules using a laser as their light source will continue to + * be active when the fiber is removed. This could be a safety issue and + * we should at least warn the user about that. + */ + if (!sfp->gpio[GPIO_TX_DISABLE]) + dev_warn(sfp->dev, + "No tx_disable pin: SFP modules will always be emitting.\n"); + return 0; } -- 2.17.0
next prev parent reply other threads:[~2018-05-04 14:00 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-04 13:56 [PATCH net-next v2 00/13] net: mvpp2: phylink conversion Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 01/13] net: phy: sfp: make the i2c-bus property really optional Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 17:03 ` Florian Fainelli 2018-05-04 17:03 ` Florian Fainelli 2018-05-04 17:19 ` Antoine Tenart 2018-05-04 17:19 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 02/13] net: phy: sfp: handle non-wired SFP connectors Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 17:04 ` Florian Fainelli 2018-05-04 17:04 ` Florian Fainelli 2018-05-04 17:17 ` Andrew Lunn 2018-05-04 17:17 ` Andrew Lunn 2018-05-04 17:23 ` Antoine Tenart 2018-05-04 17:23 ` Antoine Tenart 2018-05-05 15:39 ` Thomas Petazzoni 2018-05-05 15:39 ` Thomas Petazzoni 2018-05-05 17:48 ` Andrew Lunn 2018-05-05 17:48 ` Andrew Lunn 2018-05-08 11:52 ` Russell King - ARM Linux 2018-05-08 11:52 ` Russell King - ARM Linux 2018-05-14 9:26 ` Antoine Tenart 2018-05-14 9:26 ` Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart [this message] 2018-05-04 13:56 ` [PATCH net-next v2 03/13] net: phy: sfp: warn the user when no tx_disable pin is available Antoine Tenart 2018-05-04 17:07 ` Florian Fainelli 2018-05-04 17:07 ` Florian Fainelli 2018-05-04 17:14 ` Andrew Lunn 2018-05-04 17:14 ` Andrew Lunn 2018-05-05 20:38 ` Florian Fainelli 2018-05-05 20:38 ` Florian Fainelli 2018-05-05 20:52 ` Andrew Lunn 2018-05-05 20:52 ` Andrew Lunn 2018-05-05 20:52 ` Andrew Lunn 2018-05-08 12:45 ` Russell King - ARM Linux 2018-05-08 12:45 ` Russell King - ARM Linux 2018-05-08 11:53 ` Russell King - ARM Linux 2018-05-08 11:53 ` Russell King - ARM Linux 2018-05-04 13:56 ` [PATCH net-next v2 04/13] net: mvpp2: align the ethtool ops definition Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 05/13] net: mvpp2: phylink support Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 06/13] phy: add 2.5G SGMII mode to the phy_mode enum Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-08 12:34 ` Russell King - ARM Linux 2018-05-08 12:34 ` Russell King - ARM Linux 2018-05-14 8:37 ` Antoine Tenart 2018-05-14 8:37 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 07/13] phy: cp110-comphy: 2.5G SGMII mode Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 08/13] net: mvpp2: 1000baseX support Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 09/13] net: mvpp2: 2500baseX support Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 10/13] arm64: dts: marvell: mcbin: add 10G SFP support Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 11/13] arm64: dts: marvell: mcbin: enable the fourth network interface Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 12/13] arm64: dts: marvell: 7040-db: describe the 10G SFP cage Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-04 13:56 ` [PATCH net-next v2 13/13] arm64: dts: marvell: 8040-db: describe the 10G SFP cages Antoine Tenart 2018-05-04 13:56 ` Antoine Tenart 2018-05-08 3:18 ` [PATCH net-next v2 00/13] net: mvpp2: phylink conversion David Miller 2018-05-08 3:18 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180504135643.23466-4-antoine.tenart@bootlin.com \ --to=antoine.tenart@bootlin.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=gregory.clement@bootlin.com \ --cc=jason@lakedaemon.net \ --cc=kishon@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=maxime.chevallier@bootlin.com \ --cc=miquel.raynal@bootlin.com \ --cc=mw@semihalf.com \ --cc=nadavh@marvell.com \ --cc=netdev@vger.kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=stefanc@marvell.com \ --cc=thomas.petazzoni@bootlin.com \ --cc=ymarkman@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.