All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v1 1/1] test: fix build with GCC 4.8.5
Date: Sat, 5 May 2018 08:47:31 +0530	[thread overview]
Message-ID: <20180505031729.GA32315@jerin> (raw)
In-Reply-To: <1525469883-8342-1-git-send-email-erik.g.carrillo@intel.com>

-----Original Message-----
> Date: Fri, 4 May 2018 16:38:03 -0500
> From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org
> Subject: [PATCH v1 1/1] test: fix build with GCC 4.8.5
> X-Mailer: git-send-email 1.7.10
> 
> Build errors occur on CentOS 7 with GCC 4.8.5 20150623 in the
> event_timer_adapter_test autotest; the
> -Werror=missing-field-initializers option causes the compiler to emit
> messages like "error: missing initializer for field ‘priority’ of
> ‘struct <anonymous>’" in several places.
> 
> Add -Wno-missing-field-initializers to the test's CFLAGS to allow the
> current syntax if we are using GCC 5.0 or lower.
> 

Missing the 'Fixes' tag:

With above change:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
>  test/test/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/test/Makefile b/test/test/Makefile
> index 2630ab4..2011857 100644
> --- a/test/test/Makefile
> +++ b/test/test/Makefile
> @@ -211,6 +211,7 @@ CFLAGS_test_memcpy_perf.o += -fno-var-tracking-assignments
>  # designated initializers.
>  ifeq ($(shell test $(GCC_VERSION) -le 50 && echo 1), 1)
>  CFLAGS_test_eventdev_sw.o += -Wno-missing-field-initializers
> +CFLAGS_test_event_timer_adapter.o += -Wno-missing-field-initializers
>  endif
>  endif
>  endif
> -- 
> 2.6.4
> 

  reply	other threads:[~2018-05-05  3:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 21:38 [PATCH v1 1/1] test: fix build with GCC 4.8.5 Erik Gabriel Carrillo
2018-05-05  3:17 ` Jerin Jacob [this message]
2018-05-05  4:55 ` Stephen Hemminger
2018-05-07 18:15   ` Carrillo, Erik G
2018-05-07 19:12 ` [PATCH v2 " Erik Gabriel Carrillo
2018-05-09  9:07   ` Jerin Jacob
2018-12-03 16:21 ` [PATCH v2] app/eventdev: detect deadlock for timer event producer Erik Gabriel Carrillo
2018-12-03 17:48 ` [PATCH v3] " Erik Gabriel Carrillo
2018-12-16 16:59   ` Jerin Jacob Kollanukkaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180505031729.GA32315@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.