* [PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static
@ 2018-05-05 20:04 Mathieu Malaterre
2018-05-10 15:50 ` Theodore Y. Ts'o
2018-05-10 16:09 ` Darrick J. Wong
0 siblings, 2 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2018-05-05 20:04 UTC (permalink / raw)
To: tytso; +Cc: Mathieu Malaterre, Andreas Dilger, linux-ext4, linux-kernel
Since function ‘ext4_getfsmap_find_fixed_metadata’ can be made static,
make it so. Remove the following gcc warning (W=1):
fs/ext4/fsmap.c:405:5: warning: no previous prototype for ‘ext4_getfsmap_find_fixed_metadata’ [-Wmissing-prototypes]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
fs/ext4/fsmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/fsmap.c b/fs/ext4/fsmap.c
index e871c4bf18e9..4b99e2db95b8 100644
--- a/fs/ext4/fsmap.c
+++ b/fs/ext4/fsmap.c
@@ -402,8 +402,8 @@ static void ext4_getfsmap_free_fixed_metadata(struct list_head *meta_list)
}
/* Find all the fixed metadata in the filesystem. */
-int ext4_getfsmap_find_fixed_metadata(struct super_block *sb,
- struct list_head *meta_list)
+static int ext4_getfsmap_find_fixed_metadata(struct super_block *sb,
+ struct list_head *meta_list)
{
struct ext4_group_desc *gdp;
ext4_group_t agno;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static
2018-05-05 20:04 [PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static Mathieu Malaterre
@ 2018-05-10 15:50 ` Theodore Y. Ts'o
2018-05-10 16:09 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2018-05-10 15:50 UTC (permalink / raw)
To: Mathieu Malaterre; +Cc: Andreas Dilger, linux-ext4, linux-kernel
On Sat, May 05, 2018 at 10:04:52PM +0200, Mathieu Malaterre wrote:
> Since function ‘ext4_getfsmap_find_fixed_metadata’ can be made static,
> make it so. Remove the following gcc warning (W=1):
>
> fs/ext4/fsmap.c:405:5: warning: no previous prototype for ‘ext4_getfsmap_find_fixed_metadata’ [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static
2018-05-05 20:04 [PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static Mathieu Malaterre
2018-05-10 15:50 ` Theodore Y. Ts'o
@ 2018-05-10 16:09 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2018-05-10 16:09 UTC (permalink / raw)
To: Mathieu Malaterre; +Cc: tytso, Andreas Dilger, linux-ext4, linux-kernel
On Sat, May 05, 2018 at 10:04:52PM +0200, Mathieu Malaterre wrote:
> Since function ‘ext4_getfsmap_find_fixed_metadata’ can be made static,
> make it so. Remove the following gcc warning (W=1):
>
> fs/ext4/fsmap.c:405:5: warning: no previous prototype for ‘ext4_getfsmap_find_fixed_metadata’ [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Sorry about being late to the party,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/ext4/fsmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/fsmap.c b/fs/ext4/fsmap.c
> index e871c4bf18e9..4b99e2db95b8 100644
> --- a/fs/ext4/fsmap.c
> +++ b/fs/ext4/fsmap.c
> @@ -402,8 +402,8 @@ static void ext4_getfsmap_free_fixed_metadata(struct list_head *meta_list)
> }
>
> /* Find all the fixed metadata in the filesystem. */
> -int ext4_getfsmap_find_fixed_metadata(struct super_block *sb,
> - struct list_head *meta_list)
> +static int ext4_getfsmap_find_fixed_metadata(struct super_block *sb,
> + struct list_head *meta_list)
> {
> struct ext4_group_desc *gdp;
> ext4_group_t agno;
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-10 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-05 20:04 [PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static Mathieu Malaterre
2018-05-10 15:50 ` Theodore Y. Ts'o
2018-05-10 16:09 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.