* [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer
@ 2018-05-06 22:17 Lionel Landwerlin
2018-05-06 22:17 ` [igt-dev] [PATCH i-g-t 2/2] lib: create new dependency for aubdump Lionel Landwerlin
` (6 more replies)
0 siblings, 7 replies; 15+ messages in thread
From: Lionel Landwerlin @ 2018-05-06 22:17 UTC (permalink / raw)
To: igt-dev
It doesn't look like there should be a dependency there.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
benchmarks/gem_busy.c | 1 +
benchmarks/gem_create.c | 1 +
benchmarks/gem_exec_ctx.c | 1 +
benchmarks/gem_exec_fault.c | 1 +
benchmarks/gem_exec_nop.c | 1 +
benchmarks/gem_exec_reloc.c | 1 +
benchmarks/gem_wsim.c | 1 +
lib/drmtest.h | 2 +-
lib/gpgpu_fill.h | 2 ++
lib/igt_draw.c | 1 +
lib/igt_dummyload.h | 1 +
lib/igt_fb.c | 1 +
lib/ioctl_wrappers.c | 1 +
tools/intel_display_poller.c | 1 +
14 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/benchmarks/gem_busy.c b/benchmarks/gem_busy.c
index 247e8934..4b8d4f81 100644
--- a/benchmarks/gem_busy.c
+++ b/benchmarks/gem_busy.c
@@ -42,6 +42,7 @@
#include "drm.h"
#include "ioctl_wrappers.h"
#include "drmtest.h"
+#include "intel_batchbuffer.h"
#include "intel_chipset.h"
#include "igt_stats.h"
diff --git a/benchmarks/gem_create.c b/benchmarks/gem_create.c
index 1e7efacf..f7c3db35 100644
--- a/benchmarks/gem_create.c
+++ b/benchmarks/gem_create.c
@@ -43,6 +43,7 @@
#include "drmtest.h"
#include "igt_aux.h"
#include "igt_stats.h"
+#include "intel_batchbuffer.h"
#define OBJECT_SIZE (1<<23)
diff --git a/benchmarks/gem_exec_ctx.c b/benchmarks/gem_exec_ctx.c
index a1c6e5d7..ad63330c 100644
--- a/benchmarks/gem_exec_ctx.c
+++ b/benchmarks/gem_exec_ctx.c
@@ -41,6 +41,7 @@
#include "drm.h"
#include "ioctl_wrappers.h"
#include "drmtest.h"
+#include "intel_batchbuffer.h"
#include "intel_io.h"
#include "igt_stats.h"
diff --git a/benchmarks/gem_exec_fault.c b/benchmarks/gem_exec_fault.c
index 21bdbc9b..4cdd24c5 100644
--- a/benchmarks/gem_exec_fault.c
+++ b/benchmarks/gem_exec_fault.c
@@ -43,6 +43,7 @@
#include "drm.h"
#include "ioctl_wrappers.h"
#include "drmtest.h"
+#include "intel_batchbuffer.h"
#include "intel_io.h"
#include "igt_stats.h"
diff --git a/benchmarks/gem_exec_nop.c b/benchmarks/gem_exec_nop.c
index 8eb88c1f..ce20d0a1 100644
--- a/benchmarks/gem_exec_nop.c
+++ b/benchmarks/gem_exec_nop.c
@@ -41,6 +41,7 @@
#include "drm.h"
#include "ioctl_wrappers.h"
#include "drmtest.h"
+#include "intel_batchbuffer.h"
#include "intel_io.h"
#include "igt_stats.h"
diff --git a/benchmarks/gem_exec_reloc.c b/benchmarks/gem_exec_reloc.c
index 40e2e478..c8ac6d21 100644
--- a/benchmarks/gem_exec_reloc.c
+++ b/benchmarks/gem_exec_reloc.c
@@ -36,6 +36,7 @@
#include <sys/stat.h>
#include <sys/time.h>
#include "drm.h"
+#include "intel_batchbuffer.h"
#include "ioctl_wrappers.h"
#include "igt_debugfs.h"
#include "drmtest.h"
diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
index 57dec7b5..69b1d843 100644
--- a/benchmarks/gem_wsim.c
+++ b/benchmarks/gem_wsim.c
@@ -42,6 +42,7 @@
#include <pthread.h>
+#include "intel_batchbuffer.h"
#include "intel_chipset.h"
#include "drm.h"
#include "ioctl_wrappers.h"
diff --git a/lib/drmtest.h b/lib/drmtest.h
index fdd34ec6..949865ee 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -36,7 +36,7 @@
#include <xf86drm.h>
-#include "intel_batchbuffer.h"
+#include "igt_core.h"
#define DRIVER_INTEL (1 << 0)
#define DRIVER_VC4 (1 << 1)
diff --git a/lib/gpgpu_fill.h b/lib/gpgpu_fill.h
index f0d188ae..0190bfc1 100644
--- a/lib/gpgpu_fill.h
+++ b/lib/gpgpu_fill.h
@@ -27,6 +27,8 @@
#ifndef GPGPU_FILL_H
#define GPGPU_FILL_H
+#include "intel_batchbuffer.h"
+
void
gen7_gpgpu_fillfunc(struct intel_batchbuffer *batch,
struct igt_buf *dst,
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 4c2b0fd9..ebae9151 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -27,6 +27,7 @@
#include "igt_draw.h"
#include "drmtest.h"
+#include "intel_batchbuffer.h"
#include "intel_chipset.h"
#include "igt_core.h"
#include "igt_fb.h"
diff --git a/lib/igt_dummyload.h b/lib/igt_dummyload.h
index a8ec213f..c6ccc293 100644
--- a/lib/igt_dummyload.h
+++ b/lib/igt_dummyload.h
@@ -29,6 +29,7 @@
#include <time.h>
#include "igt_aux.h"
+#include "i915_drm.h"
typedef struct igt_spin {
unsigned int handle;
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 7404ba7c..34b1a261 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -34,6 +34,7 @@
#include "igt_kms.h"
#include "igt_x86.h"
#include "ioctl_wrappers.h"
+#include "intel_batchbuffer.h"
#include "intel_chipset.h"
/**
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 4e1a08bf..79db44a8 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -49,6 +49,7 @@
#include "drmtest.h"
#include "i915_drm.h"
+#include "intel_batchbuffer.h"
#include "intel_chipset.h"
#include "intel_io.h"
#include "igt_debugfs.h"
diff --git a/tools/intel_display_poller.c b/tools/intel_display_poller.c
index a26e2ecf..51f5b9a5 100644
--- a/tools/intel_display_poller.c
+++ b/tools/intel_display_poller.c
@@ -34,6 +34,7 @@
#include <string.h>
#include "intel_chipset.h"
#include "intel_io.h"
+#include "intel_reg.h"
#include "igt_debugfs.h"
#include "drmtest.h"
#include "igt_aux.h"
--
2.17.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] lib: create new dependency for aubdump
2018-05-06 22:17 [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
@ 2018-05-06 22:17 ` Lionel Landwerlin
2018-05-07 9:14 ` Katarzyna Dec
2018-05-06 22:21 ` [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Chris Wilson
` (5 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Lionel Landwerlin @ 2018-05-06 22:17 UTC (permalink / raw)
To: igt-dev
While trying to capture an aubdump on a libva demo, I run into a crash
in intel_batchbuffer.c. Turn out every driver has it's own
intel_batchbuffer.c with similar symbols and because aubdump pulls in
libigt, things go wrong.
One could argue that there is something wrong with
intel-vaapi-driver's build but I also think aubdump should embed as
little as possible.
This change creates a very small library that embeds just the needed
bits of igt for aubdump.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
lib/meson.build | 11 +++++++++--
tools/meson.build | 2 +-
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/lib/meson.build b/lib/meson.build
index 5f2567fb..04d550fa 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -124,10 +124,17 @@ lib_igt = declare_dependency(link_with : lib_igt_build,
igt_deps = [ lib_igt ] + lib_deps
+lin_igt_chipset_build = static_library('igt_chipset',
+ ['intel_chipset.c',
+ 'intel_device_info.c'],
+ include_directories : inc)
+
+lib_igt_chipset = declare_dependency(link_with : lin_igt_chipset_build,
+ include_directories : inc)
+
lib_igt_perf_build = static_library('igt_perf',
['igt_perf.c'],
- include_directories : inc
-)
+ include_directories : inc)
lib_igt_perf = declare_dependency(link_with : lib_igt_perf_build,
include_directories : inc)
diff --git a/tools/meson.build b/tools/meson.build
index bd2d313d..789219d0 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -113,7 +113,7 @@ install_subdir('registers', install_dir : datadir,
])
shared_library('intel_aubdump', 'aubdump.c',
- dependencies : [ igt_deps, dlsym ],
+ dependencies : [ lib_igt_chipset, dlsym ],
name_prefix : '',
install : true)
--
2.17.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer
2018-05-06 22:17 [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
2018-05-06 22:17 ` [igt-dev] [PATCH i-g-t 2/2] lib: create new dependency for aubdump Lionel Landwerlin
@ 2018-05-06 22:21 ` Chris Wilson
2018-05-06 23:18 ` Lionel Landwerlin
2018-05-06 22:47 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
` (4 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Chris Wilson @ 2018-05-06 22:21 UTC (permalink / raw)
To: Lionel Landwerlin, igt-dev
Quoting Lionel Landwerlin (2018-05-06 23:17:11)
> It doesn't look like there should be a dependency there.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
> benchmarks/gem_busy.c | 1 +
> benchmarks/gem_create.c | 1 +
> benchmarks/gem_exec_ctx.c | 1 +
> benchmarks/gem_exec_fault.c | 1 +
> benchmarks/gem_exec_nop.c | 1 +
> benchmarks/gem_exec_reloc.c | 1 +
> benchmarks/gem_wsim.c | 1 +
> lib/drmtest.h | 2 +-
> lib/gpgpu_fill.h | 2 ++
> lib/igt_draw.c | 1 +
> lib/igt_dummyload.h | 1 +
> lib/igt_fb.c | 1 +
> lib/ioctl_wrappers.c | 1 +
> tools/intel_display_poller.c | 1 +
> 14 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/benchmarks/gem_busy.c b/benchmarks/gem_busy.c
> index 247e8934..4b8d4f81 100644
> --- a/benchmarks/gem_busy.c
> +++ b/benchmarks/gem_busy.c
> @@ -42,6 +42,7 @@
> #include "drm.h"
> #include "ioctl_wrappers.h"
> #include "drmtest.h"
> +#include "intel_batchbuffer.h"
> #include "intel_chipset.h"
> #include "igt_stats.h"
>
> diff --git a/benchmarks/gem_create.c b/benchmarks/gem_create.c
> index 1e7efacf..f7c3db35 100644
> --- a/benchmarks/gem_create.c
> +++ b/benchmarks/gem_create.c
> @@ -43,6 +43,7 @@
> #include "drmtest.h"
> #include "igt_aux.h"
> #include "igt_stats.h"
> +#include "intel_batchbuffer.h"
>
> #define OBJECT_SIZE (1<<23)
>
> diff --git a/benchmarks/gem_exec_ctx.c b/benchmarks/gem_exec_ctx.c
> index a1c6e5d7..ad63330c 100644
> --- a/benchmarks/gem_exec_ctx.c
> +++ b/benchmarks/gem_exec_ctx.c
> @@ -41,6 +41,7 @@
> #include "drm.h"
> #include "ioctl_wrappers.h"
> #include "drmtest.h"
> +#include "intel_batchbuffer.h"
> #include "intel_io.h"
> #include "igt_stats.h"
>
> diff --git a/benchmarks/gem_exec_fault.c b/benchmarks/gem_exec_fault.c
> index 21bdbc9b..4cdd24c5 100644
> --- a/benchmarks/gem_exec_fault.c
> +++ b/benchmarks/gem_exec_fault.c
> @@ -43,6 +43,7 @@
> #include "drm.h"
> #include "ioctl_wrappers.h"
> #include "drmtest.h"
> +#include "intel_batchbuffer.h"
> #include "intel_io.h"
> #include "igt_stats.h"
>
> diff --git a/benchmarks/gem_exec_nop.c b/benchmarks/gem_exec_nop.c
> index 8eb88c1f..ce20d0a1 100644
> --- a/benchmarks/gem_exec_nop.c
> +++ b/benchmarks/gem_exec_nop.c
> @@ -41,6 +41,7 @@
> #include "drm.h"
> #include "ioctl_wrappers.h"
> #include "drmtest.h"
> +#include "intel_batchbuffer.h"
> #include "intel_io.h"
> #include "igt_stats.h"
>
> diff --git a/benchmarks/gem_exec_reloc.c b/benchmarks/gem_exec_reloc.c
> index 40e2e478..c8ac6d21 100644
> --- a/benchmarks/gem_exec_reloc.c
> +++ b/benchmarks/gem_exec_reloc.c
> @@ -36,6 +36,7 @@
> #include <sys/stat.h>
> #include <sys/time.h>
> #include "drm.h"
> +#include "intel_batchbuffer.h"
> #include "ioctl_wrappers.h"
> #include "igt_debugfs.h"
> #include "drmtest.h"
> diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
> index 57dec7b5..69b1d843 100644
> --- a/benchmarks/gem_wsim.c
> +++ b/benchmarks/gem_wsim.c
> @@ -42,6 +42,7 @@
> #include <pthread.h>
>
>
> +#include "intel_batchbuffer.h"
> #include "intel_chipset.h"
> #include "drm.h"
> #include "ioctl_wrappers.h"
None of these use the intel_batchbuffer interface, and have no desire to
begin doing so.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib: drop drmtest dependency on intel_batchbuffer
2018-05-06 22:17 [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
2018-05-06 22:17 ` [igt-dev] [PATCH i-g-t 2/2] lib: create new dependency for aubdump Lionel Landwerlin
2018-05-06 22:21 ` [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Chris Wilson
@ 2018-05-06 22:47 ` Patchwork
2018-05-06 23:19 ` [igt-dev] [PATCH v2 1/2 v2] lib: create new dependency for aubdump Lionel Landwerlin
` (3 subsequent siblings)
6 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2018-05-06 22:47 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] lib: drop drmtest dependency on intel_batchbuffer
URL : https://patchwork.freedesktop.org/series/42782/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4149 -> IGTPW_1321 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42782/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1321 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-cfl-s3: PASS -> FAIL (fdo#100368, fdo#103928)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-ivb-3520m: PASS -> DMESG-WARN (fdo#106084)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@debugfs_test@read_all_entries:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-skl-guc: FAIL (fdo#104699, fdo#105900) -> PASS +1
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-cnl-psr: FAIL (fdo#100368) -> PASS
igt@kms_frontbuffer_tracking@basic:
{fi-hsw-peppy}: DMESG-FAIL (fdo#106103, fdo#102614) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-ivb-3520m: DMESG-WARN (fdo#106084) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#104699 https://bugs.freedesktop.org/show_bug.cgi?id=104699
fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
== Participating hosts (40 -> 34) ==
Missing (6): fi-ilk-m540 fi-byt-j1900 fi-ctg-p8600 fi-glk-j4005 fi-pnv-d510 fi-skl-6700hq
== Build changes ==
* IGT: IGT_4461 -> IGTPW_1321
* Piglit: piglit_4461 -> piglit_4462
CI_DRM_4149: 6c2ec0dee7d19b798a1de1101175f5a076549cd9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1321: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1321/
IGT_4461: f772d9a910130b3aec8efa4f09ed723618fae656 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4461: 55207ea5154dfaa6d2c128124c50e3be4f9b6440 @ git://anongit.freedesktop.org/piglit
piglit_4462: 55207ea5154dfaa6d2c128124c50e3be4f9b6440 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1321/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer
2018-05-06 22:21 ` [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Chris Wilson
@ 2018-05-06 23:18 ` Lionel Landwerlin
0 siblings, 0 replies; 15+ messages in thread
From: Lionel Landwerlin @ 2018-05-06 23:18 UTC (permalink / raw)
To: Chris Wilson, igt-dev
On 06/05/18 23:21, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2018-05-06 23:17:11)
>> It doesn't look like there should be a dependency there.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> ---
>> benchmarks/gem_busy.c | 1 +
>> benchmarks/gem_create.c | 1 +
>> benchmarks/gem_exec_ctx.c | 1 +
>> benchmarks/gem_exec_fault.c | 1 +
>> benchmarks/gem_exec_nop.c | 1 +
>> benchmarks/gem_exec_reloc.c | 1 +
>> benchmarks/gem_wsim.c | 1 +
>> lib/drmtest.h | 2 +-
>> lib/gpgpu_fill.h | 2 ++
>> lib/igt_draw.c | 1 +
>> lib/igt_dummyload.h | 1 +
>> lib/igt_fb.c | 1 +
>> lib/ioctl_wrappers.c | 1 +
>> tools/intel_display_poller.c | 1 +
>> 14 files changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/benchmarks/gem_busy.c b/benchmarks/gem_busy.c
>> index 247e8934..4b8d4f81 100644
>> --- a/benchmarks/gem_busy.c
>> +++ b/benchmarks/gem_busy.c
>> @@ -42,6 +42,7 @@
>> #include "drm.h"
>> #include "ioctl_wrappers.h"
>> #include "drmtest.h"
>> +#include "intel_batchbuffer.h"
>> #include "intel_chipset.h"
>> #include "igt_stats.h"
>>
>> diff --git a/benchmarks/gem_create.c b/benchmarks/gem_create.c
>> index 1e7efacf..f7c3db35 100644
>> --- a/benchmarks/gem_create.c
>> +++ b/benchmarks/gem_create.c
>> @@ -43,6 +43,7 @@
>> #include "drmtest.h"
>> #include "igt_aux.h"
>> #include "igt_stats.h"
>> +#include "intel_batchbuffer.h"
>>
>> #define OBJECT_SIZE (1<<23)
>>
>> diff --git a/benchmarks/gem_exec_ctx.c b/benchmarks/gem_exec_ctx.c
>> index a1c6e5d7..ad63330c 100644
>> --- a/benchmarks/gem_exec_ctx.c
>> +++ b/benchmarks/gem_exec_ctx.c
>> @@ -41,6 +41,7 @@
>> #include "drm.h"
>> #include "ioctl_wrappers.h"
>> #include "drmtest.h"
>> +#include "intel_batchbuffer.h"
>> #include "intel_io.h"
>> #include "igt_stats.h"
>>
>> diff --git a/benchmarks/gem_exec_fault.c b/benchmarks/gem_exec_fault.c
>> index 21bdbc9b..4cdd24c5 100644
>> --- a/benchmarks/gem_exec_fault.c
>> +++ b/benchmarks/gem_exec_fault.c
>> @@ -43,6 +43,7 @@
>> #include "drm.h"
>> #include "ioctl_wrappers.h"
>> #include "drmtest.h"
>> +#include "intel_batchbuffer.h"
>> #include "intel_io.h"
>> #include "igt_stats.h"
>>
>> diff --git a/benchmarks/gem_exec_nop.c b/benchmarks/gem_exec_nop.c
>> index 8eb88c1f..ce20d0a1 100644
>> --- a/benchmarks/gem_exec_nop.c
>> +++ b/benchmarks/gem_exec_nop.c
>> @@ -41,6 +41,7 @@
>> #include "drm.h"
>> #include "ioctl_wrappers.h"
>> #include "drmtest.h"
>> +#include "intel_batchbuffer.h"
>> #include "intel_io.h"
>> #include "igt_stats.h"
>>
>> diff --git a/benchmarks/gem_exec_reloc.c b/benchmarks/gem_exec_reloc.c
>> index 40e2e478..c8ac6d21 100644
>> --- a/benchmarks/gem_exec_reloc.c
>> +++ b/benchmarks/gem_exec_reloc.c
>> @@ -36,6 +36,7 @@
>> #include <sys/stat.h>
>> #include <sys/time.h>
>> #include "drm.h"
>> +#include "intel_batchbuffer.h"
>> #include "ioctl_wrappers.h"
>> #include "igt_debugfs.h"
>> #include "drmtest.h"
>> diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
>> index 57dec7b5..69b1d843 100644
>> --- a/benchmarks/gem_wsim.c
>> +++ b/benchmarks/gem_wsim.c
>> @@ -42,6 +42,7 @@
>> #include <pthread.h>
>>
>>
>> +#include "intel_batchbuffer.h"
>> #include "intel_chipset.h"
>> #include "drm.h"
>> #include "ioctl_wrappers.h"
> None of these use the intel_batchbuffer interface, and have no desire to
> begin doing so.
> -Chris
>
Indeed s/intel_batchbuffer/intel_reg/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* [igt-dev] [PATCH v2 1/2 v2] lib: create new dependency for aubdump
2018-05-06 22:17 [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
` (2 preceding siblings ...)
2018-05-06 22:47 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
@ 2018-05-06 23:19 ` Lionel Landwerlin
2018-05-06 23:20 ` Lionel Landwerlin
2018-05-06 23:20 ` [igt-dev] [PATCH v2 1/2 v2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
` (2 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Lionel Landwerlin @ 2018-05-06 23:19 UTC (permalink / raw)
To: igt-dev
While trying to capture an aubdump on a libva demo, I run into a crash
in intel_batchbuffer.c. Turn out every driver has it's own
intel_batchbuffer.c with similar symbols and because aubdump pulls in
libigt, things go wrong.
One could argue that there is something wrong with
intel-vaapi-driver's build but I also think aubdump should embed as
little as possible.
This change creates a very small library that embeds just the needed
bits of igt for aubdump.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
lib/meson.build | 11 +++++++++--
tools/meson.build | 2 +-
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/lib/meson.build b/lib/meson.build
index 5f2567fb..04d550fa 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -124,10 +124,17 @@ lib_igt = declare_dependency(link_with : lib_igt_build,
igt_deps = [ lib_igt ] + lib_deps
+lin_igt_chipset_build = static_library('igt_chipset',
+ ['intel_chipset.c',
+ 'intel_device_info.c'],
+ include_directories : inc)
+
+lib_igt_chipset = declare_dependency(link_with : lin_igt_chipset_build,
+ include_directories : inc)
+
lib_igt_perf_build = static_library('igt_perf',
['igt_perf.c'],
- include_directories : inc
-)
+ include_directories : inc)
lib_igt_perf = declare_dependency(link_with : lib_igt_perf_build,
include_directories : inc)
diff --git a/tools/meson.build b/tools/meson.build
index bd2d313d..789219d0 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -113,7 +113,7 @@ install_subdir('registers', install_dir : datadir,
])
shared_library('intel_aubdump', 'aubdump.c',
- dependencies : [ igt_deps, dlsym ],
+ dependencies : [ lib_igt_chipset, dlsym ],
name_prefix : '',
install : true)
--
2.17.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [igt-dev] [PATCH v2 1/2 v2] lib: drop drmtest dependency on intel_batchbuffer
2018-05-06 22:17 [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
` (3 preceding siblings ...)
2018-05-06 23:19 ` [igt-dev] [PATCH v2 1/2 v2] lib: create new dependency for aubdump Lionel Landwerlin
@ 2018-05-06 23:20 ` Lionel Landwerlin
2018-05-06 23:22 ` Lionel Landwerlin
` (2 more replies)
2018-05-06 23:48 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2,v2] lib: drop drmtest dependency on intel_batchbuffer (rev3) Patchwork
2018-05-06 23:53 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib: drop drmtest dependency on intel_batchbuffer Patchwork
6 siblings, 3 replies; 15+ messages in thread
From: Lionel Landwerlin @ 2018-05-06 23:20 UTC (permalink / raw)
To: igt-dev
It doesn't look like there should be a dependency there.
v2: s/intel_batchbuffer/intel_reg/
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
benchmarks/gem_busy.c | 1 +
benchmarks/gem_create.c | 1 +
benchmarks/gem_exec_ctx.c | 1 +
benchmarks/gem_exec_fault.c | 1 +
benchmarks/gem_exec_nop.c | 1 +
benchmarks/gem_exec_reloc.c | 1 +
benchmarks/gem_wsim.c | 1 +
lib/drmtest.h | 2 +-
lib/gpgpu_fill.h | 2 ++
lib/igt_draw.c | 1 +
lib/igt_dummyload.h | 1 +
lib/igt_fb.c | 1 +
lib/ioctl_wrappers.c | 1 +
tools/intel_display_poller.c | 1 +
14 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/benchmarks/gem_busy.c b/benchmarks/gem_busy.c
index 247e8934..4b8d4f81 100644
--- a/benchmarks/gem_busy.c
+++ b/benchmarks/gem_busy.c
@@ -42,6 +42,7 @@
#include "drm.h"
#include "ioctl_wrappers.h"
#include "drmtest.h"
+#include "intel_batchbuffer.h"
#include "intel_chipset.h"
#include "igt_stats.h"
diff --git a/benchmarks/gem_create.c b/benchmarks/gem_create.c
index 1e7efacf..bb3e7b64 100644
--- a/benchmarks/gem_create.c
+++ b/benchmarks/gem_create.c
@@ -43,6 +43,7 @@
#include "drmtest.h"
#include "igt_aux.h"
#include "igt_stats.h"
+#include "intel_reg.h"
#define OBJECT_SIZE (1<<23)
diff --git a/benchmarks/gem_exec_ctx.c b/benchmarks/gem_exec_ctx.c
index a1c6e5d7..e55275f3 100644
--- a/benchmarks/gem_exec_ctx.c
+++ b/benchmarks/gem_exec_ctx.c
@@ -42,6 +42,7 @@
#include "ioctl_wrappers.h"
#include "drmtest.h"
#include "intel_io.h"
+#include "intel_reg.h"
#include "igt_stats.h"
enum mode { NOP, CREATE, SWITCH, DEFAULT };
diff --git a/benchmarks/gem_exec_fault.c b/benchmarks/gem_exec_fault.c
index 21bdbc9b..3f58c77d 100644
--- a/benchmarks/gem_exec_fault.c
+++ b/benchmarks/gem_exec_fault.c
@@ -44,6 +44,7 @@
#include "ioctl_wrappers.h"
#include "drmtest.h"
#include "intel_io.h"
+#include "intel_reg.h"
#include "igt_stats.h"
#define LOCAL_I915_EXEC_NO_RELOC (1<<11)
diff --git a/benchmarks/gem_exec_nop.c b/benchmarks/gem_exec_nop.c
index 8eb88c1f..b327e2e8 100644
--- a/benchmarks/gem_exec_nop.c
+++ b/benchmarks/gem_exec_nop.c
@@ -42,6 +42,7 @@
#include "ioctl_wrappers.h"
#include "drmtest.h"
#include "intel_io.h"
+#include "intel_reg.h"
#include "igt_stats.h"
#define LOCAL_I915_EXEC_NO_RELOC (1<<11)
diff --git a/benchmarks/gem_exec_reloc.c b/benchmarks/gem_exec_reloc.c
index 40e2e478..f9487d95 100644
--- a/benchmarks/gem_exec_reloc.c
+++ b/benchmarks/gem_exec_reloc.c
@@ -36,6 +36,7 @@
#include <sys/stat.h>
#include <sys/time.h>
#include "drm.h"
+#include "intel_reg.h"
#include "ioctl_wrappers.h"
#include "igt_debugfs.h"
#include "drmtest.h"
diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
index 57dec7b5..80f18082 100644
--- a/benchmarks/gem_wsim.c
+++ b/benchmarks/gem_wsim.c
@@ -43,6 +43,7 @@
#include "intel_chipset.h"
+#include "intel_reg.h"
#include "drm.h"
#include "ioctl_wrappers.h"
#include "drmtest.h"
diff --git a/lib/drmtest.h b/lib/drmtest.h
index fdd34ec6..949865ee 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -36,7 +36,7 @@
#include <xf86drm.h>
-#include "intel_batchbuffer.h"
+#include "igt_core.h"
#define DRIVER_INTEL (1 << 0)
#define DRIVER_VC4 (1 << 1)
diff --git a/lib/gpgpu_fill.h b/lib/gpgpu_fill.h
index f0d188ae..0190bfc1 100644
--- a/lib/gpgpu_fill.h
+++ b/lib/gpgpu_fill.h
@@ -27,6 +27,8 @@
#ifndef GPGPU_FILL_H
#define GPGPU_FILL_H
+#include "intel_batchbuffer.h"
+
void
gen7_gpgpu_fillfunc(struct intel_batchbuffer *batch,
struct igt_buf *dst,
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 4c2b0fd9..ebae9151 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -27,6 +27,7 @@
#include "igt_draw.h"
#include "drmtest.h"
+#include "intel_batchbuffer.h"
#include "intel_chipset.h"
#include "igt_core.h"
#include "igt_fb.h"
diff --git a/lib/igt_dummyload.h b/lib/igt_dummyload.h
index a8ec213f..c6ccc293 100644
--- a/lib/igt_dummyload.h
+++ b/lib/igt_dummyload.h
@@ -29,6 +29,7 @@
#include <time.h>
#include "igt_aux.h"
+#include "i915_drm.h"
typedef struct igt_spin {
unsigned int handle;
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 7404ba7c..34b1a261 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -34,6 +34,7 @@
#include "igt_kms.h"
#include "igt_x86.h"
#include "ioctl_wrappers.h"
+#include "intel_batchbuffer.h"
#include "intel_chipset.h"
/**
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 4e1a08bf..79db44a8 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -49,6 +49,7 @@
#include "drmtest.h"
#include "i915_drm.h"
+#include "intel_batchbuffer.h"
#include "intel_chipset.h"
#include "intel_io.h"
#include "igt_debugfs.h"
diff --git a/tools/intel_display_poller.c b/tools/intel_display_poller.c
index a26e2ecf..51f5b9a5 100644
--- a/tools/intel_display_poller.c
+++ b/tools/intel_display_poller.c
@@ -34,6 +34,7 @@
#include <string.h>
#include "intel_chipset.h"
#include "intel_io.h"
+#include "intel_reg.h"
#include "igt_debugfs.h"
#include "drmtest.h"
#include "igt_aux.h"
--
2.17.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH v2 1/2 v2] lib: create new dependency for aubdump
2018-05-06 23:19 ` [igt-dev] [PATCH v2 1/2 v2] lib: create new dependency for aubdump Lionel Landwerlin
@ 2018-05-06 23:20 ` Lionel Landwerlin
0 siblings, 0 replies; 15+ messages in thread
From: Lionel Landwerlin @ 2018-05-06 23:20 UTC (permalink / raw)
To: igt-dev
Oops, wrong send-email... Ignore this patch.
On 07/05/18 00:19, Lionel Landwerlin wrote:
> While trying to capture an aubdump on a libva demo, I run into a crash
> in intel_batchbuffer.c. Turn out every driver has it's own
> intel_batchbuffer.c with similar symbols and because aubdump pulls in
> libigt, things go wrong.
>
> One could argue that there is something wrong with
> intel-vaapi-driver's build but I also think aubdump should embed as
> little as possible.
>
> This change creates a very small library that embeds just the needed
> bits of igt for aubdump.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
> lib/meson.build | 11 +++++++++--
> tools/meson.build | 2 +-
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/lib/meson.build b/lib/meson.build
> index 5f2567fb..04d550fa 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -124,10 +124,17 @@ lib_igt = declare_dependency(link_with : lib_igt_build,
>
> igt_deps = [ lib_igt ] + lib_deps
>
> +lin_igt_chipset_build = static_library('igt_chipset',
> + ['intel_chipset.c',
> + 'intel_device_info.c'],
> + include_directories : inc)
> +
> +lib_igt_chipset = declare_dependency(link_with : lin_igt_chipset_build,
> + include_directories : inc)
> +
> lib_igt_perf_build = static_library('igt_perf',
> ['igt_perf.c'],
> - include_directories : inc
> -)
> + include_directories : inc)
>
> lib_igt_perf = declare_dependency(link_with : lib_igt_perf_build,
> include_directories : inc)
> diff --git a/tools/meson.build b/tools/meson.build
> index bd2d313d..789219d0 100644
> --- a/tools/meson.build
> +++ b/tools/meson.build
> @@ -113,7 +113,7 @@ install_subdir('registers', install_dir : datadir,
> ])
>
> shared_library('intel_aubdump', 'aubdump.c',
> - dependencies : [ igt_deps, dlsym ],
> + dependencies : [ lib_igt_chipset, dlsym ],
> name_prefix : '',
> install : true)
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH v2 1/2 v2] lib: drop drmtest dependency on intel_batchbuffer
2018-05-06 23:20 ` [igt-dev] [PATCH v2 1/2 v2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
@ 2018-05-06 23:22 ` Lionel Landwerlin
2018-05-07 9:13 ` Katarzyna Dec
2018-05-07 9:17 ` Chris Wilson
2 siblings, 0 replies; 15+ messages in thread
From: Lionel Landwerlin @ 2018-05-06 23:22 UTC (permalink / raw)
To: igt-dev
On 07/05/18 00:20, Lionel Landwerlin wrote:
> index 247e8934..4b8d4f81 100644
> --- a/benchmarks/gem_busy.c
> +++ b/benchmarks/gem_busy.c
> @@ -42,6 +42,7 @@
> #include "drm.h"
> #include "ioctl_wrappers.h"
> #include "drmtest.h"
> +#include "intel_batchbuffer.h"
> #include "intel_chipset.h"
> #include "igt_stats.h"
>
And I forgot that one :(
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2,v2] lib: drop drmtest dependency on intel_batchbuffer (rev3)
2018-05-06 22:17 [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
` (4 preceding siblings ...)
2018-05-06 23:20 ` [igt-dev] [PATCH v2 1/2 v2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
@ 2018-05-06 23:48 ` Patchwork
2018-05-06 23:53 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib: drop drmtest dependency on intel_batchbuffer Patchwork
6 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2018-05-06 23:48 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: igt-dev
== Series Details ==
Series: series starting with [v2,1/2,v2] lib: drop drmtest dependency on intel_batchbuffer (rev3)
URL : https://patchwork.freedesktop.org/series/42782/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4149 -> IGTPW_1322 =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_1322 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1322, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42782/revisions/3/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1322:
=== IGT changes ===
==== Possible regressions ====
igt@drv_module_reload@basic-reload-inject:
fi-ilk-650: PASS -> DMESG-WARN
== Known issues ==
Here are the changes found in IGTPW_1322 that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@debugfs_test@read_all_entries:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-skl-guc: FAIL (fdo#104699, fdo#105900) -> PASS +1
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-cnl-psr: FAIL (fdo#100368) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-ivb-3520m: DMESG-WARN (fdo#106084) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104699 https://bugs.freedesktop.org/show_bug.cgi?id=104699
fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
== Participating hosts (40 -> 33) ==
Missing (7): fi-ilk-m540 fi-bxt-dsi fi-byt-j1900 fi-hsw-peppy fi-ctg-p8600 fi-pnv-d510 fi-skl-6700hq
== Build changes ==
* IGT: IGT_4461 -> IGTPW_1322
* Piglit: piglit_4461 -> piglit_4462
CI_DRM_4149: 6c2ec0dee7d19b798a1de1101175f5a076549cd9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1322: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1322/
IGT_4461: f772d9a910130b3aec8efa4f09ed723618fae656 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4461: 55207ea5154dfaa6d2c128124c50e3be4f9b6440 @ git://anongit.freedesktop.org/piglit
piglit_4462: 55207ea5154dfaa6d2c128124c50e3be4f9b6440 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1322/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib: drop drmtest dependency on intel_batchbuffer
2018-05-06 22:17 [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
` (5 preceding siblings ...)
2018-05-06 23:48 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2,v2] lib: drop drmtest dependency on intel_batchbuffer (rev3) Patchwork
@ 2018-05-06 23:53 ` Patchwork
6 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2018-05-06 23:53 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] lib: drop drmtest dependency on intel_batchbuffer
URL : https://patchwork.freedesktop.org/series/42782/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4461_full -> IGTPW_1321_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1321_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1321_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42782/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1321_full:
=== IGT changes ===
==== Warnings ====
igt@kms_flip@flip-vs-fences:
shard-kbl: SKIP -> PASS +14
igt@pm_rc6_residency@rc6-accuracy:
shard-kbl: PASS -> SKIP +2
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_1321_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_contexts:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@gem_workarounds@suspend-resume-fd:
shard-kbl: NOTRUN -> INCOMPLETE (fdo#103665)
igt@kms_color@pipe-b-ctm-green-to-red:
shard-kbl: PASS -> DMESG-WARN (fdo#106247)
igt@kms_flip@flip-vs-wf_vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#100368)
igt@kms_flip@modeset-vs-vblank-race-interruptible:
shard-hsw: PASS -> FAIL (fdo#103060)
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-hsw: PASS -> FAIL (fdo#100368)
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: PASS -> FAIL (fdo#103925)
igt@kms_rotation_crc@primary-rotation-270:
shard-apl: PASS -> FAIL (fdo#103925)
==== Possible fixes ====
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#103665, fdo#106023) -> PASS
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-kbl: DMESG-WARN (fdo#103558, fdo#103313, fdo#105602) -> PASS +1
igt@kms_flip@dpms-vs-vblank-race:
shard-glk: FAIL (fdo#103060) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-hsw: FAIL (fdo#105707) -> PASS
igt@kms_flip@wf_vblank-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-cpu:
shard-kbl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS +5
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
shard-apl: FAIL (fdo#103925) -> PASS
igt@kms_vblank@pipe-c-ts-continuation-suspend:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS +1
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105707 https://bugs.freedesktop.org/show_bug.cgi?id=105707
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106247 https://bugs.freedesktop.org/show_bug.cgi?id=106247
== Participating hosts (6 -> 5) ==
Missing (1): pig-glk-j4005
== Build changes ==
* IGT: IGT_4461 -> IGTPW_1321
* Linux: CI_DRM_4135 -> CI_DRM_4149
* Piglit: piglit_4461 -> piglit_4462
CI_DRM_4135: 266fa55ff4e1d3b7ab86deccf5709ee79c79f5dc @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4149: 6c2ec0dee7d19b798a1de1101175f5a076549cd9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1321: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1321/
IGT_4461: f772d9a910130b3aec8efa4f09ed723618fae656 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4461: 55207ea5154dfaa6d2c128124c50e3be4f9b6440 @ git://anongit.freedesktop.org/piglit
piglit_4462: 55207ea5154dfaa6d2c128124c50e3be4f9b6440 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1321/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH v2 1/2 v2] lib: drop drmtest dependency on intel_batchbuffer
2018-05-06 23:20 ` [igt-dev] [PATCH v2 1/2 v2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
2018-05-06 23:22 ` Lionel Landwerlin
@ 2018-05-07 9:13 ` Katarzyna Dec
2018-05-07 9:17 ` Chris Wilson
2 siblings, 0 replies; 15+ messages in thread
From: Katarzyna Dec @ 2018-05-07 9:13 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: igt-dev
On Mon, May 07, 2018 at 12:20:28AM +0100, Lionel Landwerlin wrote:
> It doesn't look like there should be a dependency there.
>
> v2: s/intel_batchbuffer/intel_reg/
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
LGTM.
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
Kasia :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] lib: create new dependency for aubdump
2018-05-06 22:17 ` [igt-dev] [PATCH i-g-t 2/2] lib: create new dependency for aubdump Lionel Landwerlin
@ 2018-05-07 9:14 ` Katarzyna Dec
2018-05-07 21:20 ` Lionel Landwerlin
0 siblings, 1 reply; 15+ messages in thread
From: Katarzyna Dec @ 2018-05-07 9:14 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: igt-dev
On Sun, May 06, 2018 at 11:17:12PM +0100, Lionel Landwerlin wrote:
> While trying to capture an aubdump on a libva demo, I run into a crash
> in intel_batchbuffer.c. Turn out every driver has it's own
> intel_batchbuffer.c with similar symbols and because aubdump pulls in
> libigt, things go wrong.
>
> One could argue that there is something wrong with
> intel-vaapi-driver's build but I also think aubdump should embed as
> little as possible.
>
> This change creates a very small library that embeds just the needed
> bits of igt for aubdump.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
LGTM
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
Kasia :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH v2 1/2 v2] lib: drop drmtest dependency on intel_batchbuffer
2018-05-06 23:20 ` [igt-dev] [PATCH v2 1/2 v2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
2018-05-06 23:22 ` Lionel Landwerlin
2018-05-07 9:13 ` Katarzyna Dec
@ 2018-05-07 9:17 ` Chris Wilson
2 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2018-05-07 9:17 UTC (permalink / raw)
To: Lionel Landwerlin, igt-dev
Quoting Lionel Landwerlin (2018-05-07 00:20:28)
> diff --git a/benchmarks/gem_busy.c b/benchmarks/gem_busy.c
> index 247e8934..4b8d4f81 100644
> --- a/benchmarks/gem_busy.c
> +++ b/benchmarks/gem_busy.c
> @@ -42,6 +42,7 @@
> #include "drm.h"
> #include "ioctl_wrappers.h"
> #include "drmtest.h"
> +#include "intel_batchbuffer.h"
One more s/batchbuffer/reg/ for good measure :)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] lib: create new dependency for aubdump
2018-05-07 9:14 ` Katarzyna Dec
@ 2018-05-07 21:20 ` Lionel Landwerlin
0 siblings, 0 replies; 15+ messages in thread
From: Lionel Landwerlin @ 2018-05-07 21:20 UTC (permalink / raw)
To: Katarzyna Dec; +Cc: igt-dev
On 07/05/18 10:14, Katarzyna Dec wrote:
> On Sun, May 06, 2018 at 11:17:12PM +0100, Lionel Landwerlin wrote:
>> While trying to capture an aubdump on a libva demo, I run into a crash
>> in intel_batchbuffer.c. Turn out every driver has it's own
>> intel_batchbuffer.c with similar symbols and because aubdump pulls in
>> libigt, things go wrong.
>>
>> One could argue that there is something wrong with
>> intel-vaapi-driver's build but I also think aubdump should embed as
>> little as possible.
>>
>> This change creates a very small library that embeds just the needed
>> bits of igt for aubdump.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> LGTM
> Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
> Kasia :)
>
Thanks a lot, pushed.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2018-05-07 21:20 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-06 22:17 [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
2018-05-06 22:17 ` [igt-dev] [PATCH i-g-t 2/2] lib: create new dependency for aubdump Lionel Landwerlin
2018-05-07 9:14 ` Katarzyna Dec
2018-05-07 21:20 ` Lionel Landwerlin
2018-05-06 22:21 ` [igt-dev] [PATCH i-g-t 1/2] lib: drop drmtest dependency on intel_batchbuffer Chris Wilson
2018-05-06 23:18 ` Lionel Landwerlin
2018-05-06 22:47 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2018-05-06 23:19 ` [igt-dev] [PATCH v2 1/2 v2] lib: create new dependency for aubdump Lionel Landwerlin
2018-05-06 23:20 ` Lionel Landwerlin
2018-05-06 23:20 ` [igt-dev] [PATCH v2 1/2 v2] lib: drop drmtest dependency on intel_batchbuffer Lionel Landwerlin
2018-05-06 23:22 ` Lionel Landwerlin
2018-05-07 9:13 ` Katarzyna Dec
2018-05-07 9:17 ` Chris Wilson
2018-05-06 23:48 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2,v2] lib: drop drmtest dependency on intel_batchbuffer (rev3) Patchwork
2018-05-06 23:53 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib: drop drmtest dependency on intel_batchbuffer Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.