All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] net/dpaa: fix max push mode queue
@ 2018-05-09  9:29 Shreyansh Jain
  2018-05-09  9:29 ` [PATCH 2/2] net/dpaa: update optimal burst size in device info Shreyansh Jain
  2018-05-09  9:49 ` [PATCH v2 1/2] net/dpaa: fix max push mode queue Shreyansh Jain
  0 siblings, 2 replies; 6+ messages in thread
From: Shreyansh Jain @ 2018-05-09  9:29 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, Shreyansh Jain, hemant.agrawal

Split default and max push mode queues to 4 and 8, respectively.

Fixes: e6573771cdfb ("net/dpaa: integrate the support of push mode in PMD")
Cc: hemant.agrawal@nxp.com

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
DPDK-1304
---
 drivers/net/dpaa/dpaa_ethdev.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 6bf8c1590..88febe4d9 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -74,12 +74,13 @@ static uint64_t dev_tx_offloads_nodis =
 
 /* Keep track of whether QMAN and BMAN have been globally initialized */
 static int is_global_init;
-/* At present we only allow up to 4 push mode queues - as each of this queue
- * need dedicated portal and we are short of portals.
+/* At present we only allow up to 4 push mode queues as default - as each of
+ * this queue need dedicated portal and we are short of portals.
  */
-#define DPAA_MAX_PUSH_MODE_QUEUE       4
+#define DPAA_MAX_PUSH_MODE_QUEUE       8
+#define DPAA_DEFAULT_PUSH_MODE_QUEUE   4
 
-static int dpaa_push_mode_max_queue = DPAA_MAX_PUSH_MODE_QUEUE;
+static int dpaa_push_mode_max_queue = DPAA_DEFAULT_PUSH_MODE_QUEUE;
 static int dpaa_push_queue_idx; /* Queue index which are in push mode*/
 
 
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] net/dpaa: update optimal burst size in device info
  2018-05-09  9:29 [PATCH 1/2] net/dpaa: fix max push mode queue Shreyansh Jain
@ 2018-05-09  9:29 ` Shreyansh Jain
  2018-05-09  9:49 ` [PATCH v2 1/2] net/dpaa: fix max push mode queue Shreyansh Jain
  1 sibling, 0 replies; 6+ messages in thread
From: Shreyansh Jain @ 2018-05-09  9:29 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, Shreyansh Jain

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 drivers/net/dpaa/dpaa_ethdev.c | 2 ++
 drivers/net/dpaa/dpaa_ethdev.h | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 88febe4d9..c0a56a9fe 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -328,6 +328,8 @@ static void dpaa_eth_dev_info(struct rte_eth_dev *dev,
 					dev_rx_offloads_nodis;
 	dev_info->tx_offload_capa = dev_tx_offloads_sup |
 					dev_tx_offloads_nodis;
+	dev_info->default_rxportconf.burst_size = DPAA_DEF_RX_BURST_SIZE;
+	dev_info->default_txportconf.burst_size = DPAA_DEF_TX_BURST_SIZE;
 }
 
 static int dpaa_eth_link_update(struct rte_eth_dev *dev,
diff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h
index df2b38444..1897b9e40 100644
--- a/drivers/net/dpaa/dpaa_ethdev.h
+++ b/drivers/net/dpaa/dpaa_ethdev.h
@@ -51,6 +51,10 @@
 /*Maximum number of slots available in TX ring*/
 #define DPAA_TX_BURST_SIZE	7
 
+/* Optimal burst size for RX and TX as default */
+#define DPAA_DEF_RX_BURST_SIZE 7
+#define DPAA_DEF_TX_BURST_SIZE DPAA_TX_BURST_SIZE
+
 #ifndef VLAN_TAG_SIZE
 #define VLAN_TAG_SIZE   4 /** < Vlan Header Length */
 #endif
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2 1/2] net/dpaa: fix max push mode queue
  2018-05-09  9:29 [PATCH 1/2] net/dpaa: fix max push mode queue Shreyansh Jain
  2018-05-09  9:29 ` [PATCH 2/2] net/dpaa: update optimal burst size in device info Shreyansh Jain
@ 2018-05-09  9:49 ` Shreyansh Jain
  2018-05-09  9:49   ` [PATCH v2 2/2] net/dpaa: update optimal burst size in device info Shreyansh Jain
                     ` (2 more replies)
  1 sibling, 3 replies; 6+ messages in thread
From: Shreyansh Jain @ 2018-05-09  9:49 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, Shreyansh Jain, hemant.agrawal

Split default and max push mode queues to 4 and 8, respectively.

Fixes: e6573771cdfb ("net/dpaa: integrate the support of push mode in PMD")
Cc: hemant.agrawal@nxp.com

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

---
 v2:
  - Removed stray internal tracking number from commit message

 drivers/net/dpaa/dpaa_ethdev.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 6bf8c1590..88febe4d9 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -74,12 +74,13 @@ static uint64_t dev_tx_offloads_nodis =
 
 /* Keep track of whether QMAN and BMAN have been globally initialized */
 static int is_global_init;
-/* At present we only allow up to 4 push mode queues - as each of this queue
- * need dedicated portal and we are short of portals.
+/* At present we only allow up to 4 push mode queues as default - as each of
+ * this queue need dedicated portal and we are short of portals.
  */
-#define DPAA_MAX_PUSH_MODE_QUEUE       4
+#define DPAA_MAX_PUSH_MODE_QUEUE       8
+#define DPAA_DEFAULT_PUSH_MODE_QUEUE   4
 
-static int dpaa_push_mode_max_queue = DPAA_MAX_PUSH_MODE_QUEUE;
+static int dpaa_push_mode_max_queue = DPAA_DEFAULT_PUSH_MODE_QUEUE;
 static int dpaa_push_queue_idx; /* Queue index which are in push mode*/
 
 
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2 2/2] net/dpaa: update optimal burst size in device info
  2018-05-09  9:49 ` [PATCH v2 1/2] net/dpaa: fix max push mode queue Shreyansh Jain
@ 2018-05-09  9:49   ` Shreyansh Jain
  2018-05-09 22:28   ` [PATCH v2 1/2] net/dpaa: fix max push mode queue Ferruh Yigit
  2018-05-09 22:42   ` Ferruh Yigit
  2 siblings, 0 replies; 6+ messages in thread
From: Shreyansh Jain @ 2018-05-09  9:49 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, Shreyansh Jain

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 drivers/net/dpaa/dpaa_ethdev.c | 2 ++
 drivers/net/dpaa/dpaa_ethdev.h | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 88febe4d9..c0a56a9fe 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -328,6 +328,8 @@ static void dpaa_eth_dev_info(struct rte_eth_dev *dev,
 					dev_rx_offloads_nodis;
 	dev_info->tx_offload_capa = dev_tx_offloads_sup |
 					dev_tx_offloads_nodis;
+	dev_info->default_rxportconf.burst_size = DPAA_DEF_RX_BURST_SIZE;
+	dev_info->default_txportconf.burst_size = DPAA_DEF_TX_BURST_SIZE;
 }
 
 static int dpaa_eth_link_update(struct rte_eth_dev *dev,
diff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h
index df2b38444..1897b9e40 100644
--- a/drivers/net/dpaa/dpaa_ethdev.h
+++ b/drivers/net/dpaa/dpaa_ethdev.h
@@ -51,6 +51,10 @@
 /*Maximum number of slots available in TX ring*/
 #define DPAA_TX_BURST_SIZE	7
 
+/* Optimal burst size for RX and TX as default */
+#define DPAA_DEF_RX_BURST_SIZE 7
+#define DPAA_DEF_TX_BURST_SIZE DPAA_TX_BURST_SIZE
+
 #ifndef VLAN_TAG_SIZE
 #define VLAN_TAG_SIZE   4 /** < Vlan Header Length */
 #endif
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] net/dpaa: fix max push mode queue
  2018-05-09  9:49 ` [PATCH v2 1/2] net/dpaa: fix max push mode queue Shreyansh Jain
  2018-05-09  9:49   ` [PATCH v2 2/2] net/dpaa: update optimal burst size in device info Shreyansh Jain
@ 2018-05-09 22:28   ` Ferruh Yigit
  2018-05-09 22:42   ` Ferruh Yigit
  2 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2018-05-09 22:28 UTC (permalink / raw)
  To: Shreyansh Jain; +Cc: dev, hemant.agrawal

On 5/9/2018 10:49 AM, Shreyansh Jain wrote:
> Split default and max push mode queues to 4 and 8, respectively.
> 
> Fixes: e6573771cdfb ("net/dpaa: integrate the support of push mode in PMD")
> Cc: hemant.agrawal@nxp.com

    Fixes: 0c504f6950b6 ("net/dpaa: support push mode")
    Cc: stable@dpdk.org

> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> ---
>  v2:
>   - Removed stray internal tracking number from commit message
> 
>  drivers/net/dpaa/dpaa_ethdev.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
> index 6bf8c1590..88febe4d9 100644
> --- a/drivers/net/dpaa/dpaa_ethdev.c
> +++ b/drivers/net/dpaa/dpaa_ethdev.c
> @@ -74,12 +74,13 @@ static uint64_t dev_tx_offloads_nodis =
>  
>  /* Keep track of whether QMAN and BMAN have been globally initialized */
>  static int is_global_init;
> -/* At present we only allow up to 4 push mode queues - as each of this queue
> - * need dedicated portal and we are short of portals.
> +/* At present we only allow up to 4 push mode queues as default - as each of
> + * this queue need dedicated portal and we are short of portals.
>   */
> -#define DPAA_MAX_PUSH_MODE_QUEUE       4
> +#define DPAA_MAX_PUSH_MODE_QUEUE       8
> +#define DPAA_DEFAULT_PUSH_MODE_QUEUE   4
>  
> -static int dpaa_push_mode_max_queue = DPAA_MAX_PUSH_MODE_QUEUE;
> +static int dpaa_push_mode_max_queue = DPAA_DEFAULT_PUSH_MODE_QUEUE;
>  static int dpaa_push_queue_idx; /* Queue index which are in push mode*/
>  
>  
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] net/dpaa: fix max push mode queue
  2018-05-09  9:49 ` [PATCH v2 1/2] net/dpaa: fix max push mode queue Shreyansh Jain
  2018-05-09  9:49   ` [PATCH v2 2/2] net/dpaa: update optimal burst size in device info Shreyansh Jain
  2018-05-09 22:28   ` [PATCH v2 1/2] net/dpaa: fix max push mode queue Ferruh Yigit
@ 2018-05-09 22:42   ` Ferruh Yigit
  2 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2018-05-09 22:42 UTC (permalink / raw)
  To: Shreyansh Jain; +Cc: dev, hemant.agrawal

On 5/9/2018 10:49 AM, Shreyansh Jain wrote:
> Split default and max push mode queues to 4 and 8, respectively.
> 
> Fixes: e6573771cdfb ("net/dpaa: integrate the support of push mode in PMD")
> Cc: hemant.agrawal@nxp.com
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Series applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-09 22:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09  9:29 [PATCH 1/2] net/dpaa: fix max push mode queue Shreyansh Jain
2018-05-09  9:29 ` [PATCH 2/2] net/dpaa: update optimal burst size in device info Shreyansh Jain
2018-05-09  9:49 ` [PATCH v2 1/2] net/dpaa: fix max push mode queue Shreyansh Jain
2018-05-09  9:49   ` [PATCH v2 2/2] net/dpaa: update optimal burst size in device info Shreyansh Jain
2018-05-09 22:28   ` [PATCH v2 1/2] net/dpaa: fix max push mode queue Ferruh Yigit
2018-05-09 22:42   ` Ferruh Yigit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.