All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Chen, JasonX Z" <jasonx.z.chen@intel.com>
Cc: Tomasz Figa <tfiga@chromium.org>,
	"Yeh, Andy" <andy.yeh@intel.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	"Chiang, AlanX" <alanx.chiang@intel.com>
Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver
Date: Wed, 9 May 2018 12:42:59 +0300	[thread overview]
Message-ID: <20180509094259.w7woldhmhbm55vho@paasikivi.fi.intel.com> (raw)
In-Reply-To: <5881B549BE56034BB7E7D11D6EDEA2020678E62E@PGSMSX106.gar.corp.intel.com>

Hi Jason,

On Wed, May 09, 2018 at 09:28:30AM +0000, Chen, JasonX Z wrote:
> Hello Tomasz
> 
> >> +/* Test Pattern Control */
> >> +#define IMX258_REG_TEST_PATTERN                0x0600
> >> +#define IMX258_TEST_PATTERN_DISABLE    0
> >> +#define IMX258_TEST_PATTERN_SOLID_COLOR        1
> >> +#define IMX258_TEST_PATTERN_COLOR_BARS 2 #define 
> >> +IMX258_TEST_PATTERN_GREY_COLOR 3
> >> +#define IMX258_TEST_PATTERN_PN9                4
> >> +
> >> +/* Orientation */
> >> +#define REG_MIRROR_FLIP_CONTROL                0x0101
> >> +#define REG_CONFIG_MIRROR_FLIP         0x03
> >> +#define REG_CONFIG_FLIP_TEST_PATTERN   0x02
> >
> >The names are inconsistent here. All other register addresses start with IMX258_REG and values with IMX258_<field name> (no REG).
> >
> >[snip]
> 
> We will update at next patch.

Just to clarify: please send a patch on top of the earlier revision to
address the comments. A pull request containing it has already been sent:

<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=for-4.18-3>

Thanks.

-- 
Kind regards,

Sakari Ailus
sakari.ailus@linux.intel.com

  reply	other threads:[~2018-05-09  9:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 15:46 [PATCH v11] media: imx258: Add imx258 camera sensor driver Andy Yeh
2018-05-03 11:23 ` Sakari Ailus
2018-05-08  8:34 ` Tomasz Figa
2018-05-09  9:28   ` Chen, JasonX Z
2018-05-09  9:42     ` Sakari Ailus [this message]
2018-05-10 11:08       ` Zheng, Jian Xu
2018-05-12 12:47         ` Sakari Ailus
2018-05-15  3:46           ` Zheng, Jian Xu
2018-05-15  7:59             ` Sakari Ailus
2018-05-09 10:05     ` Tomasz Figa
2018-05-10  6:56       ` Zheng, Jian Xu
2018-05-10  7:04         ` Tomasz Figa
2018-05-10  8:33           ` Yeh, Andy
2018-05-10  8:39             ` Tomasz Figa
2018-05-10  9:11           ` Zheng, Jian Xu
2018-05-10  9:15             ` Tomasz Figa
2018-05-12 12:52               ` Sakari Ailus
2018-05-12 13:49                 ` Tomasz Figa
2018-05-09 19:02 ` Mauro Carvalho Chehab
2018-05-10  2:05 ` Yunliang Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180509094259.w7woldhmhbm55vho@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=alanx.chiang@intel.com \
    --cc=andy.yeh@intel.com \
    --cc=jasonx.z.chen@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.