All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Zheng, Jian Xu" <jian.xu.zheng@intel.com>
Cc: "Chen, JasonX Z" <jasonx.z.chen@intel.com>,
	Tomasz Figa <tfiga@chromium.org>,
	"Yeh, Andy" <andy.yeh@intel.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	"Chiang, AlanX" <alanx.chiang@intel.com>,
	"Qiu, Tian Shu" <tian.shu.qiu@intel.com>
Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver
Date: Tue, 15 May 2018 10:59:45 +0300	[thread overview]
Message-ID: <20180515075945.xe56ax6quqw6rndt@paasikivi.fi.intel.com> (raw)
In-Reply-To: <FA6CF6692DF0B343ABE491A46A2CD0E76C6640FE@SHSMSX101.ccr.corp.intel.com>

On Tue, May 15, 2018 at 03:46:37AM +0000, Zheng, Jian Xu wrote:
> Hi Sakari,
> 
> > -----Original Message-----
> > From: linux-media-owner@vger.kernel.org [mailto:linux-media-
> > owner@vger.kernel.org] On Behalf Of Sakari Ailus
> > Sent: Saturday, May 12, 2018 8:48 PM
> > To: Zheng, Jian Xu <jian.xu.zheng@intel.com>
> > Cc: Chen, JasonX Z <jasonx.z.chen@intel.com>; Tomasz Figa
> > <tfiga@chromium.org>; Yeh, Andy <andy.yeh@intel.com>; Linux Media
> > Mailing List <linux-media@vger.kernel.org>; Chiang, AlanX
> > <alanx.chiang@intel.com>; Qiu, Tian Shu <tian.shu.qiu@intel.com>
> > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver
> > 
> > On Thu, May 10, 2018 at 11:08:43AM +0000, Zheng, Jian Xu wrote:
> > > Hi Sakari & Jason,
> > >
> > > > -----Original Message-----
> > > > From: linux-media-owner@vger.kernel.org [mailto:linux-media-
> > > > owner@vger.kernel.org] On Behalf Of Sakari Ailus
> > > > Sent: Wednesday, May 9, 2018 5:43 PM
> > > > To: Chen, JasonX Z <jasonx.z.chen@intel.com>
> > > > Cc: Tomasz Figa <tfiga@chromium.org>; Yeh, Andy
> > > > <andy.yeh@intel.com>; Linux Media Mailing List
> > > > <linux-media@vger.kernel.org>; Chiang, AlanX
> > > > <alanx.chiang@intel.com>
> > > > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor
> > > > driver
> > > >
> > > > Hi Jason,
> > > >
> > > > On Wed, May 09, 2018 at 09:28:30AM +0000, Chen, JasonX Z wrote:
> > > > > Hello Tomasz
> > > > >
> > > > > >> +/* Test Pattern Control */
> > > > > >> +#define IMX258_REG_TEST_PATTERN                0x0600
> > > > > >> +#define IMX258_TEST_PATTERN_DISABLE    0
> > > > > >> +#define IMX258_TEST_PATTERN_SOLID_COLOR        1
> > > > > >> +#define IMX258_TEST_PATTERN_COLOR_BARS 2 #define
> > > > > >> +IMX258_TEST_PATTERN_GREY_COLOR 3
> > > > > >> +#define IMX258_TEST_PATTERN_PN9                4
> > >
> > > I suppose we only use IMX258_TEST_PATTERN_COLOR_BARS. I heard that
> > > we'd better remove the functions/code no one would use. Is that true? e.g.
> > > remove all h_flip and v_flip ioctls because it's not used by anyone.
> > 
> > HFLIP and VFLIP support were AFAIR removed as they were not supported
> > correctly by the driver --- they do affect the pixel order, i.e. the format.

> So you mean that if the sensor is RAW format, we should not implement
> HFLIP/VFLIP. Because it changes the pixel order? I don't quite follow the
> logic here. In the meantime, if the logic works here, we need some other
> kind of HFLIP/VFLIP ioctl because it's supported by HW.

You can implement it but the implementation needs to be correctly reflect
the flipping in the pixel order reported by the driver.

-- 
Sakari Ailus
sakari.ailus@linux.intel.com

  reply	other threads:[~2018-05-15  7:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 15:46 [PATCH v11] media: imx258: Add imx258 camera sensor driver Andy Yeh
2018-05-03 11:23 ` Sakari Ailus
2018-05-08  8:34 ` Tomasz Figa
2018-05-09  9:28   ` Chen, JasonX Z
2018-05-09  9:42     ` Sakari Ailus
2018-05-10 11:08       ` Zheng, Jian Xu
2018-05-12 12:47         ` Sakari Ailus
2018-05-15  3:46           ` Zheng, Jian Xu
2018-05-15  7:59             ` Sakari Ailus [this message]
2018-05-09 10:05     ` Tomasz Figa
2018-05-10  6:56       ` Zheng, Jian Xu
2018-05-10  7:04         ` Tomasz Figa
2018-05-10  8:33           ` Yeh, Andy
2018-05-10  8:39             ` Tomasz Figa
2018-05-10  9:11           ` Zheng, Jian Xu
2018-05-10  9:15             ` Tomasz Figa
2018-05-12 12:52               ` Sakari Ailus
2018-05-12 13:49                 ` Tomasz Figa
2018-05-09 19:02 ` Mauro Carvalho Chehab
2018-05-10  2:05 ` Yunliang Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180515075945.xe56ax6quqw6rndt@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=alanx.chiang@intel.com \
    --cc=andy.yeh@intel.com \
    --cc=jasonx.z.chen@intel.com \
    --cc=jian.xu.zheng@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=tfiga@chromium.org \
    --cc=tian.shu.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.