* [PATCH] drm/i915/selftests: Only switch to kernel context when locked
@ 2018-05-09 6:59 Chris Wilson
2018-05-09 8:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2018-05-09 6:59 UTC (permalink / raw)
To: intel-gfx
In igt_flush_test() we try to switch back to the kernel context, but we
are only able to do so when we care called with struct_mutex held.
More CI fallout from lockdep being temporarily suppressed :(
Fixes: 4cdf65ce8cc2 ("drm/i915/selftests: Return to kernel context after each test")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/selftests/igt_flush_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/igt_flush_test.c b/drivers/gpu/drm/i915/selftests/igt_flush_test.c
index 7f35bddc2e95..0d06f559243f 100644
--- a/drivers/gpu/drm/i915/selftests/igt_flush_test.c
+++ b/drivers/gpu/drm/i915/selftests/igt_flush_test.c
@@ -57,7 +57,8 @@ int igt_flush_test(struct drm_i915_private *i915, unsigned int flags)
cond_resched();
- if (i915_gem_switch_to_kernel_context(i915)) {
+ if (flags & I915_WAIT_LOCKED &&
+ i915_gem_switch_to_kernel_context(i915)) {
pr_err("Failed to switch back to kernel context; declaring wedged\n");
i915_gem_set_wedged(i915);
}
--
2.17.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✗ Fi.CI.BAT: failure for drm/i915/selftests: Only switch to kernel context when locked
2018-05-09 6:59 [PATCH] drm/i915/selftests: Only switch to kernel context when locked Chris Wilson
@ 2018-05-09 8:15 ` Patchwork
2018-05-09 8:19 ` [PATCH] " Mika Kuoppala
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-05-09 8:15 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Only switch to kernel context when locked
URL : https://patchwork.freedesktop.org/series/42922/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4161 -> Patchwork_8956 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_8956 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_8956, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42922/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8956:
=== IGT changes ===
==== Possible regressions ====
igt@gvt_basic@invalid-placeholder-test:
fi-bwr-2160: SKIP -> INCOMPLETE
==== Warnings ====
igt@gem_exec_gttfill@basic:
fi-pnv-d510: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_8956 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@basic:
fi-hsw-4200u: PASS -> DMESG-FAIL (fdo#106103, fdo#102614)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
== Participating hosts (40 -> 37) ==
Additional (1): fi-glk-j4005
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4161 -> Patchwork_8956
CI_DRM_4161: f20dbaa0dfba8b33c677c084d39fc730309c5af2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4468: 548a894dc904c4628522dbbc77cb179a4c965ebc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8956: 4a647a80781ebba5387f68d93c22120c05aa776b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4468: 1e60f1499e5b71b6d5a747189d7c28f57359a87f @ git://anongit.freedesktop.org/piglit
== Linux commits ==
4a647a80781e drm/i915/selftests: Only switch to kernel context when locked
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8956/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/selftests: Only switch to kernel context when locked
2018-05-09 6:59 [PATCH] drm/i915/selftests: Only switch to kernel context when locked Chris Wilson
2018-05-09 8:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-05-09 8:19 ` Mika Kuoppala
2018-05-09 8:57 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-05-09 10:18 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2018-05-09 8:19 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> In igt_flush_test() we try to switch back to the kernel context, but we
> are only able to do so when we care called with struct_mutex held.
s/care/are
>
> More CI fallout from lockdep being temporarily suppressed :(
Kind words.../o\
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
> Fixes: 4cdf65ce8cc2 ("drm/i915/selftests: Return to kernel context after each test")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/selftests/igt_flush_test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/igt_flush_test.c b/drivers/gpu/drm/i915/selftests/igt_flush_test.c
> index 7f35bddc2e95..0d06f559243f 100644
> --- a/drivers/gpu/drm/i915/selftests/igt_flush_test.c
> +++ b/drivers/gpu/drm/i915/selftests/igt_flush_test.c
> @@ -57,7 +57,8 @@ int igt_flush_test(struct drm_i915_private *i915, unsigned int flags)
>
> cond_resched();
>
> - if (i915_gem_switch_to_kernel_context(i915)) {
> + if (flags & I915_WAIT_LOCKED &&
> + i915_gem_switch_to_kernel_context(i915)) {
> pr_err("Failed to switch back to kernel context; declaring wedged\n");
> i915_gem_set_wedged(i915);
> }
> --
> 2.17.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/selftests: Only switch to kernel context when locked
2018-05-09 6:59 [PATCH] drm/i915/selftests: Only switch to kernel context when locked Chris Wilson
2018-05-09 8:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-05-09 8:19 ` [PATCH] " Mika Kuoppala
@ 2018-05-09 8:57 ` Patchwork
2018-05-09 9:21 ` Chris Wilson
2018-05-09 10:18 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2018-05-09 8:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Only switch to kernel context when locked
URL : https://patchwork.freedesktop.org/series/42922/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4161 -> Patchwork_8958 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_8958 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_8958, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42922/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8958:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_gttfill@basic:
fi-pnv-d510: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_8958 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: PASS -> FAIL (fdo#102575)
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
== Participating hosts (40 -> 37) ==
Additional (1): fi-glk-j4005
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4161 -> Patchwork_8958
CI_DRM_4161: f20dbaa0dfba8b33c677c084d39fc730309c5af2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4468: 548a894dc904c4628522dbbc77cb179a4c965ebc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8958: 19d6def0ed772cfbbfe18c9acf717b08eae827ac @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4468: 1e60f1499e5b71b6d5a747189d7c28f57359a87f @ git://anongit.freedesktop.org/piglit
== Linux commits ==
19d6def0ed77 drm/i915/selftests: Only switch to kernel context when locked
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8958/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/selftests: Only switch to kernel context when locked
2018-05-09 6:59 [PATCH] drm/i915/selftests: Only switch to kernel context when locked Chris Wilson
` (2 preceding siblings ...)
2018-05-09 8:57 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-05-09 10:18 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-05-09 10:18 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Only switch to kernel context when locked
URL : https://patchwork.freedesktop.org/series/42922/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4161_full -> Patchwork_8958_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_8958_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_8958_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42922/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8958_full:
=== IGT changes ===
==== Warnings ====
igt@drv_selftest@live_execlists:
shard-glk: SKIP -> PASS +1
shard-apl: SKIP -> PASS +1
igt@gem_exec_schedule@deep-blt:
shard-kbl: SKIP -> PASS +4
igt@gem_exec_schedule@deep-bsd2:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_8958_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible:
shard-apl: PASS -> FAIL (fdo#100368)
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-glk: PASS -> FAIL (fdo#100368) +1
igt@kms_sysfs_edid_timing:
shard-apl: PASS -> WARN (fdo#100047)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
shard-kbl: DMESG-FAIL (fdo#106453) -> PASS
shard-apl: DMESG-FAIL (fdo#106453) -> PASS
shard-glk: DMESG-FAIL (fdo#106453) -> PASS
igt@kms_flip@dpms-vs-vblank-race-interruptible:
shard-glk: FAIL (fdo#103060) -> PASS
igt@kms_flip@flip-vs-wf_vblank-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_flip@modeset-vs-vblank-race:
shard-hsw: FAIL (fdo#103060) -> PASS
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
igt@kms_vblank@pipe-b-accuracy-idle:
shard-hsw: FAIL (fdo#102583) -> PASS
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102583 https://bugs.freedesktop.org/show_bug.cgi?id=102583
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106453 https://bugs.freedesktop.org/show_bug.cgi?id=106453
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (9 -> 9) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4161 -> Patchwork_8958
CI_DRM_4161: f20dbaa0dfba8b33c677c084d39fc730309c5af2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4468: 548a894dc904c4628522dbbc77cb179a4c965ebc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8958: 19d6def0ed772cfbbfe18c9acf717b08eae827ac @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4468: 1e60f1499e5b71b6d5a747189d7c28f57359a87f @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8958/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-09 10:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 6:59 [PATCH] drm/i915/selftests: Only switch to kernel context when locked Chris Wilson
2018-05-09 8:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-05-09 8:19 ` [PATCH] " Mika Kuoppala
2018-05-09 8:57 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-05-09 9:21 ` Chris Wilson
2018-05-09 10:18 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.