From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] GCC 7.x vs. C++ comments
Date: Wed, 9 May 2018 07:48:28 -0400 [thread overview]
Message-ID: <20180509114828.GG12235@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <20180509113837.59F33240036@gemini.denx.de>
On Wed, May 09, 2018 at 01:38:37PM +0200, Wolfgang Denk wrote:
> Dear Tom,
>
> In message <20180509111627.GD12235@bill-the-cat.ec.rr.com> you wrote:
> >
> > > What’s your preferred solution:
> > > (a) change these comments
> > > (b) change our Makefiles to let GCC know that we are compiling gnu99/C99?
> > >
> > > Neither solution is too appealing to me, so I am asking...
> >
> > Lets go with (b) which I guess what a more modern toolchain defaults to
> > anyhow. Thanks!
>
> I disagree. UI-Boot always discouraged the use of C++ comments, see
> for example bullet # 5 at [1]. We should clearly fix the comments,
> please.
>
> [1] http://www.denx.de/wiki/U-Boot/Coding
We should go and update [1] to note some special exemptions to the rule.
I see you missed out on the SPDX thread over here:
https://lists.denx.de/pipermail/u-boot/2018-May/327544.html and repeat
myself, I see it as more worthwhile to (a) follow the kernel in this
area (for both tooling and consistency and ease of development for our
overlapping community) (b) save space (in just about every conversion we
went from 2 lines to 1 line). Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180509/9ff5f0cf/attachment.sig>
next prev parent reply other threads:[~2018-05-09 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 8:46 [U-Boot] GCC 7.x vs. C++ comments Dr. Philipp Tomsich
2018-05-09 11:16 ` Tom Rini
2018-05-09 11:38 ` Wolfgang Denk
2018-05-09 11:48 ` Tom Rini [this message]
2018-05-09 12:46 ` Wolfgang Denk
2018-05-09 13:49 ` Tom Rini
2018-05-09 14:11 ` Dr. Philipp Tomsich
2018-05-09 15:40 ` Wolfgang Denk
2018-05-09 16:07 ` Wolfgang Denk
2018-05-09 16:22 ` Tom Rini
2018-05-09 16:14 ` Tom Rini
2018-05-09 20:44 ` Wolfgang Denk
2018-05-10 12:07 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509114828.GG12235@bill-the-cat.ec.rr.com \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.