From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] GCC 7.x vs. C++ comments
Date: Wed, 09 May 2018 18:07:50 +0200 [thread overview]
Message-ID: <20180509160750.4A0B624000A@gemini.denx.de> (raw)
In-Reply-To: <20180509154052.5E0B424000A@gemini.denx.de>
Dear Tom,
In message <20180509154052.5E0B424000A@gemini.denx.de> I wrote:
>
> > - Don't like // style comments
> > - Visually inconsistent / jarring
>
> - Against existing coding style.
Also, the SPDX tag is rarely a separate comment line. In most
cases, it is part of a larger file header, say for example:
common/main.c:
/*
* (C) Copyright 2000
* Wolfgang Denk, DENX Software Engineering, wd at denx.de.
*
* SPDX-License-Identifier: GPL-2.0+
*/
Do you suggest to reformat this into something like:
/*
* (C) Copyright 2000
* Wolfgang Denk, DENX Software Engineering, wd at denx.de.
*/
// SPDX-License-Identifier: GPL-2.0+
?
If yes, then please explain which sense this would make? It is just
unnecessay work, and the result is inconsistent and ugly.
> > - Has tooling to enforce correctly formatted tags.
I forgot to ask which "tooling" you have in mind here? I did not
see anything like that in the kernel source tree. What am I
missing?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
This restaurant was advertising breakfast any time. So I ordered
french toast in the renaissance. - Steven Wright, comedian
next prev parent reply other threads:[~2018-05-09 16:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 8:46 [U-Boot] GCC 7.x vs. C++ comments Dr. Philipp Tomsich
2018-05-09 11:16 ` Tom Rini
2018-05-09 11:38 ` Wolfgang Denk
2018-05-09 11:48 ` Tom Rini
2018-05-09 12:46 ` Wolfgang Denk
2018-05-09 13:49 ` Tom Rini
2018-05-09 14:11 ` Dr. Philipp Tomsich
2018-05-09 15:40 ` Wolfgang Denk
2018-05-09 16:07 ` Wolfgang Denk [this message]
2018-05-09 16:22 ` Tom Rini
2018-05-09 16:14 ` Tom Rini
2018-05-09 20:44 ` Wolfgang Denk
2018-05-10 12:07 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509160750.4A0B624000A@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.