* [PATCH 1/2] go-native: use nonarch_libdir @ 2018-05-09 15:49 Dan McGregor 2018-05-09 15:49 ` [PATCH 2/2] systemd: backport fix for newer gpg-error Dan McGregor ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Dan McGregor @ 2018-05-09 15:49 UTC (permalink / raw) To: openembedded-core From: Dan McGregor <dan.mcgregor@usask.ca> Setting staging_libdir to libdir caused unnecessary rebuilds of go-native when switching from a multilib build to a non-multilib build. Switch to nonarch_libdir because that's the same on both multilib and regular builds. Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca> --- meta/recipes-devtools/go/go-native.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-devtools/go/go-native.inc b/meta/recipes-devtools/go/go-native.inc index b76fb0825e4..76c83848cd3 100644 --- a/meta/recipes-devtools/go/go-native.inc +++ b/meta/recipes-devtools/go/go-native.inc @@ -1,6 +1,6 @@ # Use immediate assingment here to get the original (/usr/lib) # instead of the one rewritten by native.bbclass. -nonstaging_libdir := "${libdir}" +nonstaging_libdir := "${nonarch_libdir}" inherit native -- 2.18.0-dev ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] systemd: backport fix for newer gpg-error. 2018-05-09 15:49 [PATCH 1/2] go-native: use nonarch_libdir Dan McGregor @ 2018-05-09 15:49 ` Dan McGregor 2018-05-09 15:59 ` Dan McGregor 2018-05-09 15:58 ` [PATCH 1/2] go-native: use nonarch_libdir Burton, Ross 2018-05-09 16:31 ` [PATCH v2] go-native: use libdir_native Dan McGregor 2 siblings, 1 reply; 6+ messages in thread From: Dan McGregor @ 2018-05-09 15:49 UTC (permalink / raw) To: openembedded-core From: Dan McGregor <dan.mcgregor@usask.ca> Fix a #define conflict with new libgpg-error when gcrypt PACKAGECONFIG option is enabled. Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca> --- ...rename-noreturn-into-_noreturn_-8456.patch | 200 ++++++++++++++++++ meta/recipes-core/systemd/systemd_237.bb | 1 + 2 files changed, 201 insertions(+) create mode 100644 meta/recipes-core/systemd/systemd/0001-basic-macros-rename-noreturn-into-_noreturn_-8456.patch diff --git a/meta/recipes-core/systemd/systemd/0001-basic-macros-rename-noreturn-into-_noreturn_-8456.patch b/meta/recipes-core/systemd/systemd/0001-basic-macros-rename-noreturn-into-_noreturn_-8456.patch new file mode 100644 index 00000000000..5e1d6383fc5 --- /dev/null +++ b/meta/recipes-core/systemd/systemd/0001-basic-macros-rename-noreturn-into-_noreturn_-8456.patch @@ -0,0 +1,200 @@ +Upstream-Status: Backport + +From da2c92fd08f6ffb432de16128ff5670c91005e8f Mon Sep 17 00:00:00 2001 +From: Franck Bui <fbui@suse.com> +Date: Thu, 15 Mar 2018 06:23:46 +0100 +Subject: [PATCH] basic/macros: rename noreturn into _noreturn_ (#8456) + +"noreturn" is reserved and can be used in other header files we include: + + [ 16s] In file included from /usr/include/gcrypt.h:30:0, + [ 16s] from ../src/journal/journal-file.h:26, + [ 16s] from ../src/journal/journal-vacuum.c:31: + [ 16s] /usr/include/gpg-error.h:1544:46: error: expected ‘,’ or ‘;’ before ‘)’ token + [ 16s] void gpgrt_log_bug (const char *fmt, ...) GPGRT_ATTR_NR_PRINTF(1,2); + +Here we include grcrypt.h (which in turns include gpg-error.h) *after* we +"noreturn" was defined in macro.h. +--- + src/basic/log.c | 4 ++-- + src/basic/log.h | 4 ++-- + src/basic/macro.h | 19 +++++++++---------- + src/basic/process-util.c | 2 +- + src/basic/process-util.h | 2 +- + src/core/main.c | 4 ++-- + src/journal/test-journal-interleaving.c | 2 +- + src/shared/pager.c | 2 +- + src/udev/collect/collect.c | 2 +- + 9 files changed, 20 insertions(+), 21 deletions(-) + +diff --git a/src/basic/log.c b/src/basic/log.c +index 12ee65a5c..837c7631d 100644 +--- a/src/basic/log.c ++++ b/src/basic/log.c +@@ -808,7 +808,7 @@ static void log_assert( + log_dispatch_internal(level, 0, file, line, func, NULL, NULL, NULL, NULL, buffer); + } + +-noreturn void log_assert_failed_realm( ++_noreturn_ void log_assert_failed_realm( + LogRealm realm, + const char *text, + const char *file, +@@ -820,7 +820,7 @@ noreturn void log_assert_failed_realm( + abort(); + } + +-noreturn void log_assert_failed_unreachable_realm( ++_noreturn_ void log_assert_failed_unreachable_realm( + LogRealm realm, + const char *text, + const char *file, +diff --git a/src/basic/log.h b/src/basic/log.h +index 5b5a25bd6..c057794c1 100644 +--- a/src/basic/log.h ++++ b/src/basic/log.h +@@ -199,7 +199,7 @@ int log_dump_internal( + char *buffer); + + /* Logging for various assertions */ +-noreturn void log_assert_failed_realm( ++_noreturn_ void log_assert_failed_realm( + LogRealm realm, + const char *text, + const char *file, +@@ -208,7 +208,7 @@ noreturn void log_assert_failed_realm( + #define log_assert_failed(text, ...) \ + log_assert_failed_realm(LOG_REALM, (text), __VA_ARGS__) + +-noreturn void log_assert_failed_unreachable_realm( ++_noreturn_ void log_assert_failed_unreachable_realm( + LogRealm realm, + const char *text, + const char *file, +diff --git a/src/basic/macro.h b/src/basic/macro.h +index 89bdd852a..3a6fc6f58 100644 +--- a/src/basic/macro.h ++++ b/src/basic/macro.h +@@ -53,6 +53,15 @@ + #else + #define _fallthrough_ + #endif ++/* Define C11 noreturn without <stdnoreturn.h> and even on older gcc ++ * compiler versions */ ++#ifndef _noreturn_ ++#if __STDC_VERSION__ >= 201112L ++#define _noreturn_ _Noreturn ++#else ++#define _noreturn_ __attribute__((noreturn)) ++#endif ++#endif + + /* Temporarily disable some warnings */ + #define DISABLE_WARNING_DECLARATION_AFTER_STATEMENT \ +@@ -414,16 +423,6 @@ static inline unsigned long ALIGN_POWER2(unsigned long u) { + #endif + #endif + +-/* Define C11 noreturn without <stdnoreturn.h> and even on older gcc +- * compiler versions */ +-#ifndef noreturn +-#if __STDC_VERSION__ >= 201112L +-#define noreturn _Noreturn +-#else +-#define noreturn __attribute__((noreturn)) +-#endif +-#endif +- + #define DEFINE_TRIVIAL_CLEANUP_FUNC(type, func) \ + static inline void func##p(type *p) { \ + if (*p) \ +diff --git a/src/basic/process-util.c b/src/basic/process-util.c +index dc7c9ef9e..f84debdd5 100644 +--- a/src/basic/process-util.c ++++ b/src/basic/process-util.c +@@ -940,7 +940,7 @@ bool is_main_thread(void) { + return cached > 0; + } + +-noreturn void freeze(void) { ++_noreturn_ void freeze(void) { + + log_close(); + +diff --git a/src/basic/process-util.h b/src/basic/process-util.h +index 9fabe4a5b..1a3f3ca11 100644 +--- a/src/basic/process-util.h ++++ b/src/basic/process-util.h +@@ -90,7 +90,7 @@ int pid_from_same_root_fs(pid_t pid); + + bool is_main_thread(void); + +-noreturn void freeze(void); ++_noreturn_ void freeze(void); + + bool oom_score_adjust_is_valid(int oa); + +diff --git a/src/core/main.c b/src/core/main.c +index 56200a8fa..484b53d5f 100644 +--- a/src/core/main.c ++++ b/src/core/main.c +@@ -141,7 +141,7 @@ static uint64_t arg_default_tasks_max = UINT64_MAX; + static sd_id128_t arg_machine_id = {}; + static EmergencyAction arg_cad_burst_action = EMERGENCY_ACTION_REBOOT_FORCE; + +-noreturn static void freeze_or_reboot(void) { ++_noreturn_ static void freeze_or_reboot(void) { + + if (arg_crash_reboot) { + log_notice("Rebooting in 10s..."); +@@ -156,7 +156,7 @@ noreturn static void freeze_or_reboot(void) { + freeze(); + } + +-noreturn static void crash(int sig) { ++_noreturn_ static void crash(int sig) { + struct sigaction sa; + pid_t pid; + +diff --git a/src/journal/test-journal-interleaving.c b/src/journal/test-journal-interleaving.c +index 5a88b2774..d87bdbdd3 100644 +--- a/src/journal/test-journal-interleaving.c ++++ b/src/journal/test-journal-interleaving.c +@@ -37,7 +37,7 @@ + + static bool arg_keep = false; + +-noreturn static void log_assert_errno(const char *text, int error, const char *file, int line, const char *func) { ++_noreturn_ static void log_assert_errno(const char *text, int error, const char *file, int line, const char *func) { + log_internal(LOG_CRIT, error, file, line, func, + "'%s' failed at %s:%u (%s): %m", text, file, line, func); + abort(); +diff --git a/src/shared/pager.c b/src/shared/pager.c +index 75db3c985..681af9c40 100644 +--- a/src/shared/pager.c ++++ b/src/shared/pager.c +@@ -47,7 +47,7 @@ static int stored_stderr = -1; + static bool stdout_redirected = false; + static bool stderr_redirected = false; + +-noreturn static void pager_fallback(void) { ++_noreturn_ static void pager_fallback(void) { + int r; + + r = copy_bytes(STDIN_FILENO, STDOUT_FILENO, (uint64_t) -1, 0); +diff --git a/src/udev/collect/collect.c b/src/udev/collect/collect.c +index 3e278bd63..c0761a374 100644 +--- a/src/udev/collect/collect.c ++++ b/src/udev/collect/collect.c +@@ -58,7 +58,7 @@ static inline struct _mate *node_to_mate(struct udev_list_node *node) + return container_of(node, struct _mate, node); + } + +-noreturn static void sig_alrm(int signo) ++_noreturn_ static void sig_alrm(int signo) + { + exit(4); + } +-- +2.18.0-dev + diff --git a/meta/recipes-core/systemd/systemd_237.bb b/meta/recipes-core/systemd/systemd_237.bb index 150f5b2e180..744d622ab86 100644 --- a/meta/recipes-core/systemd/systemd_237.bb +++ b/meta/recipes-core/systemd/systemd_237.bb @@ -50,6 +50,7 @@ SRC_URI += "file://touchscreen.rules \ file://0030-fix-missing-of-__register_atfork-for-non-glibc-build.patch \ file://0031-fix-missing-ULONG_LONG_MAX-definition-in-case-of-mus.patch \ file://0032-memfd.patch \ + file://0001-basic-macros-rename-noreturn-into-_noreturn_-8456.patch \ " SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch" -- 2.18.0-dev ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] systemd: backport fix for newer gpg-error. 2018-05-09 15:49 ` [PATCH 2/2] systemd: backport fix for newer gpg-error Dan McGregor @ 2018-05-09 15:59 ` Dan McGregor 0 siblings, 0 replies; 6+ messages in thread From: Dan McGregor @ 2018-05-09 15:59 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On 9 May 2018 at 09:49, Dan McGregor <danismostlikely@gmail.com> wrote: > From: Dan McGregor <dan.mcgregor@usask.ca> > > Fix a #define conflict with new libgpg-error when gcrypt PACKAGECONFIG > option is enabled. Looks like this is a duplicate. > > Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca> > --- > ...rename-noreturn-into-_noreturn_-8456.patch | 200 ++++++++++++++++++ > meta/recipes-core/systemd/systemd_237.bb | 1 + > 2 files changed, 201 insertions(+) > create mode 100644 meta/recipes-core/systemd/systemd/0001-basic-macros-rename-noreturn-into-_noreturn_-8456.patch > > diff --git a/meta/recipes-core/systemd/systemd/0001-basic-macros-rename-noreturn-into-_noreturn_-8456.patch b/meta/recipes-core/systemd/systemd/0001-basic-macros-rename-noreturn-into-_noreturn_-8456.patch > new file mode 100644 > index 00000000000..5e1d6383fc5 > --- /dev/null > +++ b/meta/recipes-core/systemd/systemd/0001-basic-macros-rename-noreturn-into-_noreturn_-8456.patch > @@ -0,0 +1,200 @@ > +Upstream-Status: Backport > + > +From da2c92fd08f6ffb432de16128ff5670c91005e8f Mon Sep 17 00:00:00 2001 > +From: Franck Bui <fbui@suse.com> > +Date: Thu, 15 Mar 2018 06:23:46 +0100 > +Subject: [PATCH] basic/macros: rename noreturn into _noreturn_ (#8456) > + > +"noreturn" is reserved and can be used in other header files we include: > + > + [ 16s] In file included from /usr/include/gcrypt.h:30:0, > + [ 16s] from ../src/journal/journal-file.h:26, > + [ 16s] from ../src/journal/journal-vacuum.c:31: > + [ 16s] /usr/include/gpg-error.h:1544:46: error: expected ‘,’ or ‘;’ before ‘)’ token > + [ 16s] void gpgrt_log_bug (const char *fmt, ...) GPGRT_ATTR_NR_PRINTF(1,2); > + > +Here we include grcrypt.h (which in turns include gpg-error.h) *after* we > +"noreturn" was defined in macro.h. > +--- > + src/basic/log.c | 4 ++-- > + src/basic/log.h | 4 ++-- > + src/basic/macro.h | 19 +++++++++---------- > + src/basic/process-util.c | 2 +- > + src/basic/process-util.h | 2 +- > + src/core/main.c | 4 ++-- > + src/journal/test-journal-interleaving.c | 2 +- > + src/shared/pager.c | 2 +- > + src/udev/collect/collect.c | 2 +- > + 9 files changed, 20 insertions(+), 21 deletions(-) > + > +diff --git a/src/basic/log.c b/src/basic/log.c > +index 12ee65a5c..837c7631d 100644 > +--- a/src/basic/log.c > ++++ b/src/basic/log.c > +@@ -808,7 +808,7 @@ static void log_assert( > + log_dispatch_internal(level, 0, file, line, func, NULL, NULL, NULL, NULL, buffer); > + } > + > +-noreturn void log_assert_failed_realm( > ++_noreturn_ void log_assert_failed_realm( > + LogRealm realm, > + const char *text, > + const char *file, > +@@ -820,7 +820,7 @@ noreturn void log_assert_failed_realm( > + abort(); > + } > + > +-noreturn void log_assert_failed_unreachable_realm( > ++_noreturn_ void log_assert_failed_unreachable_realm( > + LogRealm realm, > + const char *text, > + const char *file, > +diff --git a/src/basic/log.h b/src/basic/log.h > +index 5b5a25bd6..c057794c1 100644 > +--- a/src/basic/log.h > ++++ b/src/basic/log.h > +@@ -199,7 +199,7 @@ int log_dump_internal( > + char *buffer); > + > + /* Logging for various assertions */ > +-noreturn void log_assert_failed_realm( > ++_noreturn_ void log_assert_failed_realm( > + LogRealm realm, > + const char *text, > + const char *file, > +@@ -208,7 +208,7 @@ noreturn void log_assert_failed_realm( > + #define log_assert_failed(text, ...) \ > + log_assert_failed_realm(LOG_REALM, (text), __VA_ARGS__) > + > +-noreturn void log_assert_failed_unreachable_realm( > ++_noreturn_ void log_assert_failed_unreachable_realm( > + LogRealm realm, > + const char *text, > + const char *file, > +diff --git a/src/basic/macro.h b/src/basic/macro.h > +index 89bdd852a..3a6fc6f58 100644 > +--- a/src/basic/macro.h > ++++ b/src/basic/macro.h > +@@ -53,6 +53,15 @@ > + #else > + #define _fallthrough_ > + #endif > ++/* Define C11 noreturn without <stdnoreturn.h> and even on older gcc > ++ * compiler versions */ > ++#ifndef _noreturn_ > ++#if __STDC_VERSION__ >= 201112L > ++#define _noreturn_ _Noreturn > ++#else > ++#define _noreturn_ __attribute__((noreturn)) > ++#endif > ++#endif > + > + /* Temporarily disable some warnings */ > + #define DISABLE_WARNING_DECLARATION_AFTER_STATEMENT \ > +@@ -414,16 +423,6 @@ static inline unsigned long ALIGN_POWER2(unsigned long u) { > + #endif > + #endif > + > +-/* Define C11 noreturn without <stdnoreturn.h> and even on older gcc > +- * compiler versions */ > +-#ifndef noreturn > +-#if __STDC_VERSION__ >= 201112L > +-#define noreturn _Noreturn > +-#else > +-#define noreturn __attribute__((noreturn)) > +-#endif > +-#endif > +- > + #define DEFINE_TRIVIAL_CLEANUP_FUNC(type, func) \ > + static inline void func##p(type *p) { \ > + if (*p) \ > +diff --git a/src/basic/process-util.c b/src/basic/process-util.c > +index dc7c9ef9e..f84debdd5 100644 > +--- a/src/basic/process-util.c > ++++ b/src/basic/process-util.c > +@@ -940,7 +940,7 @@ bool is_main_thread(void) { > + return cached > 0; > + } > + > +-noreturn void freeze(void) { > ++_noreturn_ void freeze(void) { > + > + log_close(); > + > +diff --git a/src/basic/process-util.h b/src/basic/process-util.h > +index 9fabe4a5b..1a3f3ca11 100644 > +--- a/src/basic/process-util.h > ++++ b/src/basic/process-util.h > +@@ -90,7 +90,7 @@ int pid_from_same_root_fs(pid_t pid); > + > + bool is_main_thread(void); > + > +-noreturn void freeze(void); > ++_noreturn_ void freeze(void); > + > + bool oom_score_adjust_is_valid(int oa); > + > +diff --git a/src/core/main.c b/src/core/main.c > +index 56200a8fa..484b53d5f 100644 > +--- a/src/core/main.c > ++++ b/src/core/main.c > +@@ -141,7 +141,7 @@ static uint64_t arg_default_tasks_max = UINT64_MAX; > + static sd_id128_t arg_machine_id = {}; > + static EmergencyAction arg_cad_burst_action = EMERGENCY_ACTION_REBOOT_FORCE; > + > +-noreturn static void freeze_or_reboot(void) { > ++_noreturn_ static void freeze_or_reboot(void) { > + > + if (arg_crash_reboot) { > + log_notice("Rebooting in 10s..."); > +@@ -156,7 +156,7 @@ noreturn static void freeze_or_reboot(void) { > + freeze(); > + } > + > +-noreturn static void crash(int sig) { > ++_noreturn_ static void crash(int sig) { > + struct sigaction sa; > + pid_t pid; > + > +diff --git a/src/journal/test-journal-interleaving.c b/src/journal/test-journal-interleaving.c > +index 5a88b2774..d87bdbdd3 100644 > +--- a/src/journal/test-journal-interleaving.c > ++++ b/src/journal/test-journal-interleaving.c > +@@ -37,7 +37,7 @@ > + > + static bool arg_keep = false; > + > +-noreturn static void log_assert_errno(const char *text, int error, const char *file, int line, const char *func) { > ++_noreturn_ static void log_assert_errno(const char *text, int error, const char *file, int line, const char *func) { > + log_internal(LOG_CRIT, error, file, line, func, > + "'%s' failed at %s:%u (%s): %m", text, file, line, func); > + abort(); > +diff --git a/src/shared/pager.c b/src/shared/pager.c > +index 75db3c985..681af9c40 100644 > +--- a/src/shared/pager.c > ++++ b/src/shared/pager.c > +@@ -47,7 +47,7 @@ static int stored_stderr = -1; > + static bool stdout_redirected = false; > + static bool stderr_redirected = false; > + > +-noreturn static void pager_fallback(void) { > ++_noreturn_ static void pager_fallback(void) { > + int r; > + > + r = copy_bytes(STDIN_FILENO, STDOUT_FILENO, (uint64_t) -1, 0); > +diff --git a/src/udev/collect/collect.c b/src/udev/collect/collect.c > +index 3e278bd63..c0761a374 100644 > +--- a/src/udev/collect/collect.c > ++++ b/src/udev/collect/collect.c > +@@ -58,7 +58,7 @@ static inline struct _mate *node_to_mate(struct udev_list_node *node) > + return container_of(node, struct _mate, node); > + } > + > +-noreturn static void sig_alrm(int signo) > ++_noreturn_ static void sig_alrm(int signo) > + { > + exit(4); > + } > +-- > +2.18.0-dev > + > diff --git a/meta/recipes-core/systemd/systemd_237.bb b/meta/recipes-core/systemd/systemd_237.bb > index 150f5b2e180..744d622ab86 100644 > --- a/meta/recipes-core/systemd/systemd_237.bb > +++ b/meta/recipes-core/systemd/systemd_237.bb > @@ -50,6 +50,7 @@ SRC_URI += "file://touchscreen.rules \ > file://0030-fix-missing-of-__register_atfork-for-non-glibc-build.patch \ > file://0031-fix-missing-ULONG_LONG_MAX-definition-in-case-of-mus.patch \ > file://0032-memfd.patch \ > + file://0001-basic-macros-rename-noreturn-into-_noreturn_-8456.patch \ > " > SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch" > > -- > 2.18.0-dev > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] go-native: use nonarch_libdir 2018-05-09 15:49 [PATCH 1/2] go-native: use nonarch_libdir Dan McGregor 2018-05-09 15:49 ` [PATCH 2/2] systemd: backport fix for newer gpg-error Dan McGregor @ 2018-05-09 15:58 ` Burton, Ross 2018-05-09 16:04 ` Dan McGregor 2018-05-09 16:31 ` [PATCH v2] go-native: use libdir_native Dan McGregor 2 siblings, 1 reply; 6+ messages in thread From: Burton, Ross @ 2018-05-09 15:58 UTC (permalink / raw) To: Dan McGregor; +Cc: OE-core [-- Attachment #1: Type: text/plain, Size: 1352 bytes --] Is that *right* though? Non-arch libdir is for architecture-independent pieces as the name suggests. Ross On 9 May 2018 at 16:49, Dan McGregor <danismostlikely@gmail.com> wrote: > From: Dan McGregor <dan.mcgregor@usask.ca> > > Setting staging_libdir to libdir caused unnecessary rebuilds of > go-native when switching from a multilib build to a non-multilib > build. Switch to nonarch_libdir because that's the same on both > multilib and regular builds. > > Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca> > --- > meta/recipes-devtools/go/go-native.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/go/go-native.inc > b/meta/recipes-devtools/go/go-native.inc > index b76fb0825e4..76c83848cd3 100644 > --- a/meta/recipes-devtools/go/go-native.inc > +++ b/meta/recipes-devtools/go/go-native.inc > @@ -1,6 +1,6 @@ > # Use immediate assingment here to get the original (/usr/lib) > # instead of the one rewritten by native.bbclass. > -nonstaging_libdir := "${libdir}" > +nonstaging_libdir := "${nonarch_libdir}" > > inherit native > > -- > 2.18.0-dev > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > [-- Attachment #2: Type: text/html, Size: 2141 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] go-native: use nonarch_libdir 2018-05-09 15:58 ` [PATCH 1/2] go-native: use nonarch_libdir Burton, Ross @ 2018-05-09 16:04 ` Dan McGregor 0 siblings, 0 replies; 6+ messages in thread From: Dan McGregor @ 2018-05-09 16:04 UTC (permalink / raw) To: Burton, Ross; +Cc: OE-core On 9 May 2018 at 09:58, Burton, Ross <ross.burton@intel.com> wrote: > Is that *right* though? Non-arch libdir is for architecture-independent > pieces as the name suggests. Looking at it again, no. It's not. That was just the first solution that came to my head. I think the right solution is to use libdir_native, which doesn't change at all, and nonstaging_libdir can go away entirely. > > Ross > > On 9 May 2018 at 16:49, Dan McGregor <danismostlikely@gmail.com> wrote: >> >> From: Dan McGregor <dan.mcgregor@usask.ca> >> >> Setting staging_libdir to libdir caused unnecessary rebuilds of >> go-native when switching from a multilib build to a non-multilib >> build. Switch to nonarch_libdir because that's the same on both >> multilib and regular builds. >> >> Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca> >> --- >> meta/recipes-devtools/go/go-native.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-devtools/go/go-native.inc >> b/meta/recipes-devtools/go/go-native.inc >> index b76fb0825e4..76c83848cd3 100644 >> --- a/meta/recipes-devtools/go/go-native.inc >> +++ b/meta/recipes-devtools/go/go-native.inc >> @@ -1,6 +1,6 @@ >> # Use immediate assingment here to get the original (/usr/lib) >> # instead of the one rewritten by native.bbclass. >> -nonstaging_libdir := "${libdir}" >> +nonstaging_libdir := "${nonarch_libdir}" >> >> inherit native >> >> -- >> 2.18.0-dev >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] go-native: use libdir_native 2018-05-09 15:49 [PATCH 1/2] go-native: use nonarch_libdir Dan McGregor 2018-05-09 15:49 ` [PATCH 2/2] systemd: backport fix for newer gpg-error Dan McGregor 2018-05-09 15:58 ` [PATCH 1/2] go-native: use nonarch_libdir Burton, Ross @ 2018-05-09 16:31 ` Dan McGregor 2 siblings, 0 replies; 6+ messages in thread From: Dan McGregor @ 2018-05-09 16:31 UTC (permalink / raw) To: openembedded-core From: Dan McGregor <dan.mcgregor@usask.ca> Setting staging_libdir to libdir caused unnecessary rebuilds of go-native when switching from a multilib build to a non-multilib build. Switch to libdir_native because it doesn't change based on target configuration. Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca> --- meta/recipes-devtools/go/go-native.inc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/meta/recipes-devtools/go/go-native.inc b/meta/recipes-devtools/go/go-native.inc index b76fb0825e4..207708745e0 100644 --- a/meta/recipes-devtools/go/go-native.inc +++ b/meta/recipes-devtools/go/go-native.inc @@ -1,7 +1,3 @@ -# Use immediate assingment here to get the original (/usr/lib) -# instead of the one rewritten by native.bbclass. -nonstaging_libdir := "${libdir}" - inherit native SRC_URI_append = " https://dl.google.com/go/go1.4-bootstrap-20171003.tar.gz;name=bootstrap;subdir=go1.4" @@ -20,7 +16,7 @@ do_configure() { } do_compile() { - export GOROOT_FINAL="${nonstaging_libdir}/go" + export GOROOT_FINAL="${libdir_native}/go" export GOROOT_BOOTSTRAP="${WORKDIR}/go1.4/go" cd src -- 2.18.0-dev ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-09 16:32 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-05-09 15:49 [PATCH 1/2] go-native: use nonarch_libdir Dan McGregor 2018-05-09 15:49 ` [PATCH 2/2] systemd: backport fix for newer gpg-error Dan McGregor 2018-05-09 15:59 ` Dan McGregor 2018-05-09 15:58 ` [PATCH 1/2] go-native: use nonarch_libdir Burton, Ross 2018-05-09 16:04 ` Dan McGregor 2018-05-09 16:31 ` [PATCH v2] go-native: use libdir_native Dan McGregor
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.