* [Buildroot] [PATCH 1/2] toolchain/buildroot: Fix symbol for uClibc
@ 2018-05-09 15:51 Petr Vorel
2018-05-09 15:51 ` [Buildroot] [PATCH 2/2] package/libmediaart: Fix default symbol for media art backend Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2018-05-09 15:51 UTC (permalink / raw)
To: buildroot
Symbol BR2_TOOLCHAIN_UCLIBC doesn't exist, it was meant to be
BR2_TOOLCHAIN_BUILDROOT_UCLIBC.
Fixes: 493b1177b9 toolchain/buildroot: default to uClibc
Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Error found while working with updated kconfig, which offers this
feature.
---
toolchain/toolchain-buildroot/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in
index 2f6624d217..75e8191f46 100644
--- a/toolchain/toolchain-buildroot/Config.in
+++ b/toolchain/toolchain-buildroot/Config.in
@@ -22,7 +22,7 @@ config BR2_TOOLCHAIN_BUILDROOT_VENDOR
choice
prompt "C library"
- default BR2_TOOLCHAIN_UCLIBC
+ default BR2_TOOLCHAIN_BUILDROOT_UCLIBC
default BR2_TOOLCHAIN_BUILDROOT_GLIBC if BR2_powerpc64
config BR2_TOOLCHAIN_BUILDROOT_UCLIBC
--
2.16.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 2/2] package/libmediaart: Fix default symbol for media art backend
2018-05-09 15:51 [Buildroot] [PATCH 1/2] toolchain/buildroot: Fix symbol for uClibc Petr Vorel
@ 2018-05-09 15:51 ` Petr Vorel
2018-05-09 15:55 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2018-05-09 15:51 UTC (permalink / raw)
To: buildroot
Symbol BR2_PACKAGE_LIBMEDIAART_BACKEND_NONE does not exist it was meant
to be BR2_PACKAGE_MEDIAART_BACKEND_NONE.
Fixes: c443830a57 libmediaart: new package
Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Error found while working with updated kconfig, which offers this
feature.
---
package/libmediaart/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libmediaart/Config.in b/package/libmediaart/Config.in
index e5e770d4fc..d3fea05ac4 100644
--- a/package/libmediaart/Config.in
+++ b/package/libmediaart/Config.in
@@ -18,7 +18,7 @@ if BR2_PACKAGE_LIBMEDIAART
choice
prompt "media art backend"
- default BR2_PACKAGE_LIBMEDIAART_BACKEND_NONE
+ default BR2_PACKAGE_MEDIAART_BACKEND_NONE
config BR2_PACKAGE_MEDIAART_BACKEND_NONE
bool "none"
--
2.16.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 2/2] package/libmediaart: Fix default symbol for media art backend
2018-05-09 15:51 ` [Buildroot] [PATCH 2/2] package/libmediaart: Fix default symbol for media art backend Petr Vorel
@ 2018-05-09 15:55 ` Thomas Petazzoni
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-05-09 15:55 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 9 May 2018 17:51:46 +0200, Petr Vorel wrote:
> Symbol BR2_PACKAGE_LIBMEDIAART_BACKEND_NONE does not exist it was meant
> to be BR2_PACKAGE_MEDIAART_BACKEND_NONE.
>
> Fixes: c443830a57 libmediaart: new package
>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> Error found while working with updated kconfig, which offers this
> feature.
Meh, in fact the real bug is that all those options should be prefixed
by BR2_PACKAGE_LIBMEDIAART and not BR2_PACKAGE_MEDIAART.
Could you fix that instead ? Config.in.legacy handling will however not
be possible, because those options are part of a Kconfig choice, and
you can't select an item of a choice.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-09 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 15:51 [Buildroot] [PATCH 1/2] toolchain/buildroot: Fix symbol for uClibc Petr Vorel
2018-05-09 15:51 ` [Buildroot] [PATCH 2/2] package/libmediaart: Fix default symbol for media art backend Petr Vorel
2018-05-09 15:55 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.